Skip to contentSkip to conversation

mosquitto: remove ipv6 depends

PATCH New Gustavo Zacarias 3 participants 3 messages Apr 22, 2015 – Apr 23, 2015

lore
Share & tools
lore

Gustavo Zacarias

author
#0 lore raw

PATCH 1/1 mosquitto: remove ipv6 depends

The package was added after the last iteration of the non-ipv6 toolchain removal, so adjust it.

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/mosquitto/Config.in | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
package/mosquitto/Config.in +2 -3
index 8f579f8..50937d0 100644
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_MOSQUITTO
 	bool "mosquitto"
 	depends on BR2_USE_MMU # fork()
-	depends on BR2_INET_IPV6
 	depends on !BR2_STATIC_LIBS # builds .so
 	help
 	  Mosquitto is an open source message broker that implements

@@ -14,6 +13,6 @@ config BR2_PACKAGE_MOSQUITTO
 
 	  http://mosquitto.org/
 
-comment "mosquitto needs a toolchain w/ IPv6, dynamic library"
+comment "mosquitto needs a toolchain w/ dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_INET_IPV6 || BR2_STATIC_LIBS
+	depends on BR2_STATIC_LIBS
Signature · 1 line
2.0.5
#1 lore raw

PATCH 1/1 mosquitto: remove ipv6 depends

Gustavo, All,

On 2015-04-22 19:13 -0300, Gustavo Zacarias spake thusly:

Quoted 4 lines

The package was added after the last iteration of the non-ipv6 toolchain removal, so adjust it.

Signed-off-by Gustavo Zacarias <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Now it occurs to me that we should probably have kep a hiden symbol, like so:

config BR2_INET_IPV6
bool
default y

so that existing out-of-tree packages (e.g. in some br2-external trees) continue to work seamlessly...

But them users would probably never notice the breakage, so maybe better break early...

Regards,
Yann E. MORIN.

Quoted 32 lines
---
 package/mosquitto/Config.in | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
package/mosquitto/Config.in +2 -3
index 8f579f8..50937d0 100644
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_MOSQUITTO
 	bool "mosquitto"
 	depends on BR2_USE_MMU # fork()
-	depends on BR2_INET_IPV6
 	depends on !BR2_STATIC_LIBS # builds .so
 	help
 	  Mosquitto is an open source message broker that implements

@@ -14,6 +13,6 @@ config BR2_PACKAGE_MOSQUITTO
 
 	  http://mosquitto.org/
 
-comment "mosquitto needs a toolchain w/ IPv6, dynamic library"
+comment "mosquitto needs a toolchain w/ dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_INET_IPV6 || BR2_STATIC_LIBS
+	depends on BR2_STATIC_LIBS
Signature · 6 lines
2.0.5

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH 1/1 mosquitto: remove ipv6 depends

In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 7 lines · Gustavo Zacarias

The package was added after the last iteration of the non-ipv6 toolchain removal, so adjust it.

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/mosquitto/Config.in | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com