Skip to contentSkip to conversation

integrator: stop zeroing the gd flags

PATCH New Linus Walleij 3 participants 3 messages Apr 21, 2015 – Apr 23, 2015

lore
Share & tools
lore

Linus Walleij

author
#0 lore raw

PATCH 1/2 integrator: stop zeroing the gd flags

This assignment conflicts with code that add flags with gd->flags |= FOO prior to the execution of this function. Seems like a historical artifact and creates bugs with early alloc().

Cc Masahiro Yamada <[email protected]>
Signed-off-by Linus Walleij <[email protected]>
---
 board/armltd/integrator/integrator.c | 2 --
 1 file changed, 2 deletions(-)
board/armltd/integrator/integrator.c +0 -2
index f0fe0fd3aabe..e94ac850c751 100644
@@ -54,8 +54,6 @@ int board_init (void)
 	/* adress of boot parameters */
 	gd->bd->bi_boot_params = 0x00000100;
 
-	gd->flags = 0;
-
 #ifdef CONFIG_CM_REMAP
 extern void cm_remap(void);
 	cm_remap();	/* remaps writeable memory to 0x00000000 */
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/2 integrator: stop zeroing the gd flags

Quoted 10 lines · Linus Walleij

This assignment conflicts with code that add flags with gd->flags |= FOO prior to the execution of this function. Seems like a historical artifact and creates bugs with early alloc().

Cc Masahiro Yamada <[email protected]>
Signed-off-by Linus Walleij <[email protected]>
---
 board/armltd/integrator/integrator.c | 2 --
 1 file changed, 2 deletions(-)
Acked-by Simon Glass <[email protected]>
#2 lore raw

PATCH 1/2 integrator: stop zeroing the gd flags

In reply to Linus Walleij
Quoted 8 lines · Linus Walleij

This assignment conflicts with code that add flags with gd->flags |= FOO prior to the execution of this function. Seems like a historical artifact and creates bugs with early alloc().

Cc Masahiro Yamada <[email protected]>
Signed-off-by Linus Walleij <[email protected]>
Acked-by Simon Glass <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150423/c92049d3/attachment.sig>