Skip to contentSkip to conversation

ARM: dts: imx28: Fix AUART4 TX-DMA interrupt name

PATCH Superseded Marek Vasut 2 participants 3 messages Apr 24, 2015

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: imx28: Fix AUART4 TX-DMA interrupt name

Fix a typo in the TX DMA interrupt name for AUART4. This patch makes AUART4 operational again.

Cc Shawn Guo <[email protected]>
Cc stable at vger.kernel.org
---
 arch/arm/boot/dts/imx28.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

NOTE: This bug goes all the way back to at least Linux 3.10
NOTE: I am not the author of the patch, but I am not allowed to disclose
the name of the original author due to the circumstances.

arch/arm/boot/dts/imx28.dtsi +1 -1
index 25e25f8..4e073e8 100644
@@ -913,7 +913,7 @@
 					      80 81 68 69
 					      70 71 72 73
 					      74 75 76 77>;
-				interrupt-names = "auart4-rx", "aurat4-tx", "spdif-tx", "empty",
+				interrupt-names = "auart4-rx", "auart4-tx", "spdif-tx", "empty",
 						  "saif0", "saif1", "i2c0", "i2c1",
 						  "auart0-rx", "auart0-tx", "auart1-rx", "auart1-tx",
 						  "auart2-rx", "auart2-tx", "auart3-rx", "auart3-tx";
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 ARM: dts: imx28: Fix AUART4 TX-DMA interrupt name

Hi Marek,

Am 24.04.2015 um 05:16 schrieb Marek Vasut:

Quoted 19 lines

Fix a typo in the TX DMA interrupt name for AUART4. This patch makes AUART4 operational again.

Cc Shawn Guo <[email protected]>
Cc stable at vger.kernel.org
---
 arch/arm/boot/dts/imx28.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

NOTE: This bug goes all the way back to at least Linux 3.10
NOTE: I am not the author of the patch, but I am not allowed to disclose
the name of the original author due to the circumstances.

arch/arm/boot/dts/imx28.dtsi +0 -0
index 25e25f8..4e073e8 100644

arch/arm/boot/dts/imx28.dtsi line 919

Quoted 8 lines
arch/arm/boot/dts/imx28.dtsi +1 -1
@@ -913,7 +913,7 @@
 					      80 81 68 69
 					      70 71 72 73
 					      74 75 76 77>;
-				interrupt-names = "auart4-rx", "aurat4-tx", "spdif-tx", "empty",
+				interrupt-names = "auart4-rx", "auart4-tx", "spdif-tx", "empty",
 						  "saif0", "saif1", "i2c0", "i2c1",
 						  "auart0-rx", "auart0-tx", "auart1-rx", "auart1-tx",
 						  "auart2-rx", "auart2-tx", "auart3-rx", "auart3-tx";

looks good, but shouldn't we patch also the wrong documentation?

Documentation/devicetree/bindings/dma/fsl-mxs-dma.txt

Best regards
Stefan

#2 lore raw

PATCH 1/1 ARM: dts: imx28: Fix AUART4 TX-DMA interrupt name

Quoted 25 lines · Stefan Wahren

Hi Marek,

Am 24.04.2015 um 05:16 schrieb Marek Vasut:

Quoted 22 lines

Fix a typo in the TX DMA interrupt name for AUART4. This patch makes AUART4 operational again.

Cc Shawn Guo <[email protected]>
Cc stable at vger.kernel.org

---

 arch/arm/boot/dts/imx28.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

NOTE: This bug goes all the way back to at least Linux 3.10
NOTE: I am not the author of the patch, but I am not allowed to disclose

the name of the original author due to the circumstances.

arch/arm/boot/dts/imx28.dtsi +0 -0
index 25e25f8..4e073e8 100644
@@ -913,7 +913,7 @@
 
Quoted 5 lines

arch/arm/boot/dts/imx28.dtsi

Quoted 5 lines
arch/arm/boot/dts/imx28.dtsi +0 -1
 					      80 81 68 69
 					      70 71 72 73
 					      74 75 76 77>;
 
-				interrupt-names = "auart4-rx", "aurat4-tx", 

"spdif-tx", "empty",

Quoted 1 line

arch/arm/boot/dts/imx28.dtsi line 918

Quoted 1 line
arch/arm/boot/dts/imx28.dtsi +1 -0
+				interrupt-names = "auart4-rx", "auart4-tx", 

"spdif-tx", "empty",

Quoted 2 lines

arch/arm/boot/dts/imx28.dtsi line 919

Quoted 2 lines
arch/arm/boot/dts/imx28.dtsi +0 -0
 						  "saif0", "saif1", "i2c0", 

"i2c1",

Quoted 1 line
Quoted 1 line

"auart0-rx", "auart0-tx",

"auart1-rx", "auart1-tx",

Quoted 1 line
Quoted 1 line

"auart2-rx", "auart2-tx",

"auart3-rx", "auart3-tx";

Quoted 4 lines

looks good, but shouldn't we patch also the wrong documentation?

Documentation/devicetree/bindings/dma/fsl-mxs-dma.txt

Nice catch, I sent out a fixed V2 patch.

Thank you!

Best regards,
Marek Vasut