libnfs: Without native RPC use libtirpc
PATCH 1/2 libnfs: Without native RPC use libtirpc
As it's done with nfs-utils, use libtirpc when no native rpc support exists in the toolchain.
--- package/libnfs/Config.in | 5 +---- package/libnfs/libnfs.mk | 4 ++++ 2 files changed, 5 insertions(+), 4 deletions(-)
package/libnfs/Config.in +1 -4
@@ -1,10 +1,7 @@ config BR2_PACKAGE_LIBNFS bool "libnfs" - depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC + select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC help nfs userspace implementation. http://github.com/sahlberg/libnfs - -comment "libnfs needs a toolchain w/ RPC" - depends on !BR2_TOOLCHAIN_HAS_NATIVE_RPC
package/libnfs/libnfs.mk +4 -0
@@ -13,4 +13,8 @@ LIBNFS_LICENSE = LGPLv2.1+ LIBNFS_LICENSE_FILES = LICENCE-LGPL-2.1.txt LIBNFS_DEPENDENCIES = host-pkgconf +ifeq ($(BR2_PACKAGE_LIBTIRPC),y) +LIBNFS_DEPENDENCIES += libtirpc +endif + $(eval $(autotools-package))
Signature · 1 line
2.1.4
PATCH 2/2 kodi: Without native RPC use libtirpc
The previous patch allow to build libnfs without native RPC support by using libtirpc. Report that dependency here.
--- package/kodi/Config.in | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
package/kodi/Config.in +1 -4
@@ -176,14 +176,11 @@ config BR2_PACKAGE_KODI_LIBMICROHTTPD config BR2_PACKAGE_KODI_LIBNFS bool "nfs" - depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_PACKAGE_LIBNFS + select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC help Enable NFS server support. -comment "nfs support needs a toolchain w/ RPC support" - depends on !BR2_TOOLCHAIN_HAS_NATIVE_RPC - config BR2_PACKAGE_KODI_RTMPDUMP bool "rtmp" select BR2_PACKAGE_RTMPDUMP
Signature · 1 line
2.1.4
PATCH 1/2 libnfs: Without native RPC use libtirpc
In reply to Maxime HadjinlianHi Maxime,
Quoted 14 lines · Maxime Hadjinlian
As it's done with nfs-utils, use libtirpc when no native rpc support exists in the toolchain.
Signed-off-by Maxime Hadjinlian <[email protected]>--- package/libnfs/Config.in | 5 +---- package/libnfs/libnfs.mk | 4 ++++ 2 files changed, 5 insertions(+), 4 deletions(-)package/libnfs/Config.in +0
-0
package/libnfs/Config.in line 3
Quoted 4 lines
package/libnfs/Config.in +1
-1@@ -1,10 +1,7 @@ config BR2_PACKAGE_LIBNFS bool "libnfs" - depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC + select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
What about libtirpc dependencies?
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH 1/2 libnfs: Without native RPC use libtirpc
Hi Baruch
Quoted 12 lines · Baruch Siach
Hi Maxime,
Quoted 9 lines · Maxime Hadjinlian
As it's done with nfs-utils, use libtirpc when no native rpc support exists in the toolchain.
Signed-off-by Maxime Hadjinlian <[email protected]>--- package/libnfs/Config.in | 5 +---- package/libnfs/libnfs.mk | 4 ++++ 2 files changed, 5 insertions(+), 4 deletions(-)
Quoted 11 lines
package/libnfs/Config.in line 3
Quoted 9 lines
package/libnfs/Config.in +1
-1@@ -1,10 +1,7 @@ config BR2_PACKAGE_LIBNFS bool "libnfs" - depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC + select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPCWhat about libtirpc dependencies?
There's only host-pkgconf, I don't think I have to add it to the dependency of libnfs, do I ?
Quoted 7 lines
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
PATCH 1/2 libnfs: Without native RPC use libtirpc
Dear Maxime Hadjinlian,
Quoted 3 lines · Maxime Hadjinlian
Quoted 1 line
What about libtirpc dependencies?
There's only host-pkgconf, I don't think I have to add it to the dependency of libnfs, do I ?
Config.in dependencies. From libtirpc/Config.in:
depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 depends on BR2_TOOLCHAIN_HAS_THREADS
They need to be propagated when you select BR2_PACKAGE_LIBTIRPC.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/2 libnfs: Without native RPC use libtirpc
In reply to Maxime HadjinlianDear Maxime Hadjinlian,
Quoted 8 lines · Maxime Hadjinlian
As it's done with nfs-utils, use libtirpc when no native rpc support exists in the toolchain.
Signed-off-by Maxime Hadjinlian <[email protected]>--- package/libnfs/Config.in | 5 +---- package/libnfs/libnfs.mk | 4 ++++ 2 files changed, 5 insertions(+), 4 deletions(-)
Both of your patches had comments, but you never addressed them. So I've marked the two patches as Changes Requested. Please address the comments and send an updated version. Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com