Skip to contentSkip to conversation

ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO

PATCH New Fabio Estevam 4 participants 4 messages Apr 14, 2015 – Apr 27, 2015

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO

On imx23-olinuxino the LED turns on when level logic high is aplied to GPIO2_1.

Fix the gpios property accordingly.

Reported-by Stefan Wahren <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx23-olinuxino.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx23-olinuxino.dts +2 -1
index 7e6eef2..839a3b9 100644
@@ -12,6 +12,7 @@
  */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "imx23.dtsi"
 
 / {

@@ -122,7 +123,7 @@
 
 		user {
 			label = "green";
-			gpios = <&gpio2 1 1>;
+			gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
 		};
 	};
 };
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO

Hi Fabio,

Quoted 4 lines

Fabio Estevam <[email protected]> hat am 14. April 2015 um 16:05 geschrieben:

Quoted 8 lines

On imx23-olinuxino the LED turns on when level logic high is aplied to GPIO2_1.

Fix the gpios property accordingly.

Reported-by Stefan Wahren <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---

Tested-by Stefan Wahren <[email protected]>

I did my tests only with iMX233-Olinuxino Maxi. How about your test equipment?

Thanks

Stefan

reviewer
#2 lore raw

PATCH 1/1 ARM: dts: imx23-olinuxino: Fix polarity of LED GPIO

Hi Stefan,

Quoted 3 lines · Stefan Wahren
Tested-by Stefan Wahren <[email protected]>

I did my tests only with iMX233-Olinuxino Maxi. How about your test equipment?

Thanks for testing.

Unfortunately, I don't have access to my mx23 olinuxino board and could not test it.

I have looked in all schematics (maxi, micro, mini and nano) and all of them require logic level high to turn on the LED.

Regards,

Fabio Estevam