Skip to contentSkip to conversation

python-pyxml: new package

PATCH Superseded Yegor Yefremov 2 participants 3 messages Feb 4, 2015 – Apr 27, 2015

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Yegor Yefremov

author
#0 lore raw

PATCH v5 1/1 python-pyxml: new package

From: Clayton Shotwell <[email protected]>

Signed-off-by Clayton Shotwell <[email protected]>
Signed-off-by Matthew Weber <[email protected]>

---
Changes:
v5: refresh the patch, so it can applied without errors
v3: updated to use python package type (Matt W)
added hash file (Matt W)

 package/Config.in                    |  1 +
 package/python-pyxml/Config.in       | 11 +++++++++++
 package/python-pyxml/python-xml.hash |  2 ++
 package/python-pyxml/python-xml.mk   | 32 ++++++++++++++++++++++++++++++++
 4 files changed, 46 insertions(+)
 create mode 100644 package/python-pyxml/Config.in
 create mode 100644 package/python-pyxml/python-xml.hash
 create mode 100644 package/python-pyxml/python-xml.mk
package/Config.in +1 -0
index fe3d3d0..581bc56 100644
@@ -561,6 +561,7 @@ menu "external python modules"
 	source "package/python-pysnmp-mibs/Config.in"
 	source "package/python-pyusb/Config.in"
 	source "package/python-pyxb/Config.in"
++	source "package/python-pyxml/Config.in"
 	source "package/python-pyzmq/Config.in"
 	source "package/python-requests/Config.in"
 	source "package/python-rtslib-fb/Config.in"
package/python-pyxml/Config.in new file +11 -0
new file mode 100644
index 0000000..420f3ad
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_PYTHON_PYXML
+	bool "python-pyxml"
+	depends on BR2_PACKAGE_PYTHON
+	help
+	  This is the Python XML package.  The distribution contains a
+	  validating XML parser, an implementation of the SAX and DOM
+	  programming interfaces, an interface to the Expat parser (and the
+	  Expat parser itself), and a C helper module that can speed up
+	  xmllib.py by a factor of 5.  There's even documentation!
+
+	  http://pyxml.sourceforge.net/topics/index.html
package/python-pyxml/python-xml.hash new file +2 -0
new file mode 100644
index 0000000..47fa4c1
@@ -0,0 +1,2 @@
+#Locally computed
+sha256 9fab66f9584fb8e67aebd8745a5c97bf1c5a2e2e461adf68862bcec64e448c13  PyXML-0.8.4.tar.gz
package/python-pyxml/python-xml.mk new file +32 -0
new file mode 100644
index 0000000..59bdc06
@@ -0,0 +1,32 @@
+################################################################################
+#
+# python-pyxml
+#
+################################################################################
+
+PYTHON_PYXML_VERSION = 0.8.4
+PYTHON_PYXML_SOURCE  = PyXML-$(PYTHON_PYXML_VERSION).tar.gz
+PYTHON_PYXML_SITE    = http://downloads.sourceforge.net/project/pyxml/pyxml/0.8.4/
+PYTHON_PYXML_LICENSE = BSD-3c
+PYTHON_PYXML_LICENSE_FILES = LICENSE
+PYTHON_PYXML_SETUP_TYPE = distutils
+PYTHON_PYXML_DEPENDENCIES = host-python python expat
+
+PYTHON_PYXML_INSTALL_STAGING = NO
+
+define PYTHON_PYXML_CONFIGURE_CMDS
+	(cd $(@D); \
+		$(HOST_DIR)/usr/bin/python setup.py \
+		config --with-libexpat=$(STAGING_DIR)/usr)
+endef
+
+HOST_PYTHON_PYXML_DEPENDENCIES = host-python host-expat
+
+define HOST_PYTHON_PYXML_CONFIGURE_CMDS
+	(cd $(@D); \
+		$(HOST_DIR)/usr/bin/python setup.py \
+		config --with-libexpat=$(HOST_DIR)/usr)
+endef
+
+$(eval $(python-package))
+$(eval $(host-python-package))
Signature · 1 line
2.1.0
author
#1 lore raw

PATCH v5 1/1 python-pyxml: new package

Quoted 4 lines · Yegor Yefremov

From: Clayton Shotwell <[email protected]>

Signed-off-by Clayton Shotwell <[email protected]>
Signed-off-by Matthew Weber <[email protected]>
Signed-off-by Yegor Yefremov <[email protected]>
Quoted 93 lines

---
Changes:
v5: refresh the patch, so it can applied without errors
v3: updated to use python package type (Matt W)
added hash file (Matt W)

 package/Config.in                    |  1 +
 package/python-pyxml/Config.in       | 11 +++++++++++
 package/python-pyxml/python-xml.hash |  2 ++
 package/python-pyxml/python-xml.mk   | 32 ++++++++++++++++++++++++++++++++
 4 files changed, 46 insertions(+)
 create mode 100644 package/python-pyxml/Config.in
 create mode 100644 package/python-pyxml/python-xml.hash
 create mode 100644 package/python-pyxml/python-xml.mk
package/Config.in +1 -0
index fe3d3d0..581bc56 100644
@@ -561,6 +561,7 @@ menu "external python modules"
        source "package/python-pysnmp-mibs/Config.in"
        source "package/python-pyusb/Config.in"
        source "package/python-pyxb/Config.in"
++      source "package/python-pyxml/Config.in"
        source "package/python-pyzmq/Config.in"
        source "package/python-requests/Config.in"
        source "package/python-rtslib-fb/Config.in"
package/python-pyxml/Config.in new file +11 -0
new file mode 100644
index 0000000..420f3ad
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_PYTHON_PYXML
+       bool "python-pyxml"
+       depends on BR2_PACKAGE_PYTHON
+       help
+         This is the Python XML package.  The distribution contains a
+         validating XML parser, an implementation of the SAX and DOM
+         programming interfaces, an interface to the Expat parser (and the
+         Expat parser itself), and a C helper module that can speed up
+         xmllib.py by a factor of 5.  There's even documentation!
+
+         http://pyxml.sourceforge.net/topics/index.html
package/python-pyxml/python-xml.hash new file +2 -0
new file mode 100644
index 0000000..47fa4c1
@@ -0,0 +1,2 @@
+#Locally computed
+sha256 9fab66f9584fb8e67aebd8745a5c97bf1c5a2e2e461adf68862bcec64e448c13  PyXML-0.8.4.tar.gz
package/python-pyxml/python-xml.mk new file +32 -1
new file mode 100644
index 0000000..59bdc06
@@ -0,0 +1,32 @@
+################################################################################
+#
+# python-pyxml
+#
+################################################################################
+
+PYTHON_PYXML_VERSION = 0.8.4
+PYTHON_PYXML_SOURCE  = PyXML-$(PYTHON_PYXML_VERSION).tar.gz
+PYTHON_PYXML_SITE    = http://downloads.sourceforge.net/project/pyxml/pyxml/0.8.4/
+PYTHON_PYXML_LICENSE = BSD-3c
+PYTHON_PYXML_LICENSE_FILES = LICENSE
+PYTHON_PYXML_SETUP_TYPE = distutils
+PYTHON_PYXML_DEPENDENCIES = host-python python expat
+
+PYTHON_PYXML_INSTALL_STAGING = NO
+
+define PYTHON_PYXML_CONFIGURE_CMDS
+       (cd $(@D); \
+               $(HOST_DIR)/usr/bin/python setup.py \
+               config --with-libexpat=$(STAGING_DIR)/usr)
+endef
+
+HOST_PYTHON_PYXML_DEPENDENCIES = host-python host-expat
+
+define HOST_PYTHON_PYXML_CONFIGURE_CMDS
+       (cd $(@D); \
+               $(HOST_DIR)/usr/bin/python setup.py \
+               config --with-libexpat=$(HOST_DIR)/usr)
+endef
+
+$(eval $(python-package))
+$(eval $(host-python-package))
--

2.1.0

#2 lore raw

PATCH v5 1/1 python-pyxml: new package

In reply to Yegor Yefremov

Dear Yegor Yefremov,

package/Config.in menu "external python modules" · line 564

Quoted 9 lines · Yegor Yefremov
package/Config.in +1 -0
index fe3d3d0..581bc56 100644
@@ -561,6 +561,7 @@ menu "external python modules"
 	source "package/python-pysnmp-mibs/Config.in"
 	source "package/python-pyusb/Config.in"
 	source "package/python-pyxb/Config.in"
++	source "package/python-pyxml/Config.in"

This seems weird, why are there two '+' signs here?

Quoted 26 lines
package/Config.in +0 -0
 	source "package/python-pyzmq/Config.in"
 	source "package/python-requests/Config.in"
 	source "package/python-rtslib-fb/Config.in"
package/python-pyxml/Config.in new file +11 -0
new file mode 100644
index 0000000..420f3ad
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_PYTHON_PYXML
+	bool "python-pyxml"
+	depends on BR2_PACKAGE_PYTHON
+	help
+	  This is the Python XML package.  The distribution contains a
+	  validating XML parser, an implementation of the SAX and DOM
+	  programming interfaces, an interface to the Expat parser (and the
+	  Expat parser itself), and a C helper module that can speed up
+	  xmllib.py by a factor of 5.  There's even documentation!
+
+	  http://pyxml.sourceforge.net/topics/index.html
package/python-pyxml/python-xml.hash new file +0 -0
new file mode 100644
index 0000000..47fa4c1

package/python-pyxml/python-xml.hash line 1

Quoted 1 line
package/python-pyxml/python-xml.hash new file +1 -0
@@ -0,0 +1,2 @@
+#Locally computed

Nit: space between # and Locally.

Quoted 7 lines
package/python-pyxml/python-xml.hash new file +1 -0
+sha256 9fab66f9584fb8e67aebd8745a5c97bf1c5a2e2e461adf68862bcec64e448c13  PyXML-0.8.4.tar.gz
package/python-pyxml/python-xml.mk new file +0 -0
new file mode 100644
index 0000000..59bdc06

package/python-pyxml/python-xml.mk line 9

Quoted 9 lines
package/python-pyxml/python-xml.mk new file +9 -0
@@ -0,0 +1,32 @@
+################################################################################
+#
+# python-pyxml
+#
+################################################################################
+
+PYTHON_PYXML_VERSION = 0.8.4
+PYTHON_PYXML_SOURCE  = PyXML-$(PYTHON_PYXML_VERSION).tar.gz
+PYTHON_PYXML_SITE    = http://downloads.sourceforge.net/project/pyxml/pyxml/0.8.4/

Please don't align '=' signs. I know we used to do it years ago, but we've stopped doing that, and fixed this all over the tree.

package/python-pyxml/python-xml.mk line 13

Quoted 4 lines
package/python-pyxml/python-xml.mk new file +4 -0
+PYTHON_PYXML_LICENSE = BSD-3c
+PYTHON_PYXML_LICENSE_FILES = LICENSE
+PYTHON_PYXML_SETUP_TYPE = distutils
+PYTHON_PYXML_DEPENDENCIES = host-python python expat

host-python and python not needed here, the python-package infrastructure takes care of that.

package/python-pyxml/python-xml.mk line 15

Quoted 1 line
package/python-pyxml/python-xml.mk new file +1 -0
+PYTHON_PYXML_INSTALL_STAGING = NO

Why?

package/python-pyxml/python-xml.mk line 21

Quoted 6 lines
package/python-pyxml/python-xml.mk new file +6 -0
+
+define PYTHON_PYXML_CONFIGURE_CMDS
+	(cd $(@D); \
+		$(HOST_DIR)/usr/bin/python setup.py \
+		config --with-libexpat=$(STAGING_DIR)/usr)
+endef

Since this is a bit unconventional, it would be good to have a comment above to explain why there is a configure step.

package/python-pyxml/python-xml.mk line 32

Quoted 11 lines
package/python-pyxml/python-xml.mk new file +11 -0
+
+HOST_PYTHON_PYXML_DEPENDENCIES = host-python host-expat
+
+define HOST_PYTHON_PYXML_CONFIGURE_CMDS
+	(cd $(@D); \
+		$(HOST_DIR)/usr/bin/python setup.py \
+		config --with-libexpat=$(HOST_DIR)/usr)
+endef
+
+$(eval $(python-package))
+$(eval $(host-python-package))

Why do we want host-python-pyxml? What other package is using it? Please mention that in the commit log at least.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com