trivial: GFS2: inode.c: indent with TABs, not spaces
Subsystems (13)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/12 trivial: HID: Makefile: fix alignment of objs-* entries
Most of the entries are aligned with TABs, fix those which are not.
--- drivers/hid/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hid/Makefile +3 -3
@@ -24,7 +24,7 @@ obj-$(CONFIG_HID_A4TECH) += hid-a4tech.o obj-$(CONFIG_HID_ACRUX) += hid-axff.o obj-$(CONFIG_HID_APPLE) += hid-apple.o obj-$(CONFIG_HID_APPLEIR) += hid-appleir.o -obj-$(CONFIG_HID_AUREAL) += hid-aureal.o +obj-$(CONFIG_HID_AUREAL) += hid-aureal.o obj-$(CONFIG_HID_BELKIN) += hid-belkin.o obj-$(CONFIG_HID_BETOP_FF) += hid-betopff.o obj-$(CONFIG_HID_CHERRY) += hid-cherry.o
@@ -46,12 +46,12 @@ obj-$(CONFIG_HID_ICADE) += hid-icade.o obj-$(CONFIG_HID_KENSINGTON) += hid-kensington.o obj-$(CONFIG_HID_KEYTOUCH) += hid-keytouch.o obj-$(CONFIG_HID_KYE) += hid-kye.o -obj-$(CONFIG_HID_LCPOWER) += hid-lcpower.o +obj-$(CONFIG_HID_LCPOWER) += hid-lcpower.o obj-$(CONFIG_HID_LENOVO) += hid-lenovo.o obj-$(CONFIG_HID_LOGITECH) += hid-logitech.o obj-$(CONFIG_HID_LOGITECH_DJ) += hid-logitech-dj.o obj-$(CONFIG_HID_LOGITECH_HIDPP) += hid-logitech-hidpp.o -obj-$(CONFIG_HID_MAGICMOUSE) += hid-magicmouse.o +obj-$(CONFIG_HID_MAGICMOUSE) += hid-magicmouse.o obj-$(CONFIG_HID_MICROSOFT) += hid-microsoft.o obj-$(CONFIG_HID_MONTEREY) += hid-monterey.o obj-$(CONFIG_HID_MULTITOUCH) += hid-multitouch.o
Signature · 1 line
2.1.4
Jiri Kosina
AppliedRe: [PATCH 01/12] trivial: HID: Makefile: fix alignment of objs-* entries
Quoted 3 lines · Antonio Ospite
Most of the entries are aligned with TABs, fix those which are not.
Signed-off-by Antonio Ospite <[email protected]>
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs
PATCH 2/12 trivial: GFS2: inode.c: indent with TABs, not spaces
In reply to a message not in the archiveFollow the same style used for the other functions in the same file.
--- fs/gfs2/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/gfs2/inode.c +2 -2
@@ -1227,8 +1227,8 @@ static int gfs2_mknod(struct inode *dir, struct dentry *dentry, umode_t mode,*/ static int gfs2_atomic_open (struct inode *dir,struct dentry *dentry, -struct file *file,unsigned flags, -umode_t mode,int *opened) +struct file *file,unsigned flags, +umode_t mode,int *opened) {struct dentry *d;bool excl = !!(flags &O_EXCL );
Signature · 1 line
2.1.4
PATCH 2/12 trivial: GFS2: inode.c: indent with TABs, not spaces
----- Original Message -----
Quoted 25 lines
Follow the same style used for the other functions in the same file.
Signed-off-by Antonio Ospite <[email protected]>Cc Steven Whitehouse <[email protected]>Cc Bob Peterson <[email protected]>Cc cluster-devel at redhat.com--- fs/gfs2/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/gfs2/inode.c +2
-2@@ -1227,8 +1227,8 @@ static int gfs2_mknod(struct inode *dir, struct dentry*dentry, umode_t mode, */ static int gfs2_atomic_open (struct inode *dir,struct dentry *dentry, -struct file *file,unsigned flags, -umode_t mode,int *opened) +struct file *file,unsigned flags, +umode_t mode,int *opened) {struct dentry *d;
Quoted 3 lines
bool excl = !!(flags &
O_EXCL);
--
2.1.4
Hi,
Thanks. This is now applied to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=86fbca4923f956dae31247e68dc73ffdfd6e5cb0
Regards,
Bob Peterson
Red Hat File Systems
PATCH 3/12 trivial: ASoC: pxa: pxa-ssp.c: indent with TABs, not spaces
In reply to a message not in the archive--- sound/soc/pxa/pxa-ssp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/pxa/pxa-ssp.c +1 -1
@@ -586,7 +586,7 @@ static int pxa_ssp_hw_params(struct snd_pcm_substream *substream,switch (priv->dai_fmt &SND_SOC_DAIFMT_FORMAT_MASK ) {case SND_SOC_DAIFMT_I2S : - sspsp =pxa_ssp_read_reg (ssp,SSPSP ); + sspsp =pxa_ssp_read_reg (ssp,SSPSP );if ((pxa_ssp_get_scr (ssp) ==4 ) && (width ==16 )) {/* This is a special case where the bitclk is 64fs
Signature · 1 line
2.1.4
PATCH 4/12 trivial: ARM: lib/lib1funcs.S: fix typo s/substractions/subtractions/
In reply to a message not in the archive--- arch/arm/lib/lib1funcs.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/lib/lib1funcs.S +2 -2
@@ -167,7 +167,7 @@ Boston, MA 02111-1307, USA. */ #endif - @ Perform all needed substractions to keep only the reminder. + @ Perform all needed subtractions to keep only the reminder. @ Do comparisons in batch of 4 first. subs \order, \order, #3 @ yes, 3 is intended here blt 2f
@@ -189,7 +189,7 @@ Boston, MA 02111-1307, USA. */ teqne \dividend, #0 beq 5f - @ Either 1, 2 or 3 comparison/substractions are left. + @ Either 1, 2 or 3 comparison/subtractions are left. 2: cmn \order, #2 blt 4f beq 3f
Signature · 1 line
2.1.4
PATCH 4/12 trivial: ARM: lib/lib1funcs.S: fix typo s/substractions/subtractions/
Quoted 13 lines · Antonio Ospite
Signed-off-by Antonio Ospite <[email protected]>Cc Russell King <[email protected]>Cc Christoffer Dall <[email protected]>Cc linux-arm-kernel at lists.infradead.org--- arch/arm/lib/lib1funcs.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/lib/lib1funcs.S +0
-0
arch/arm/lib/lib1funcs.S Boston, MA 02111-1307, USA. */ · line 170
Quoted 5 lines
arch/arm/lib/lib1funcs.S +1
-1@@ -167,7 +167,7 @@ Boston, MA 02111-1307, USA. */ #endif - @ Perform all needed substractions to keep only the reminder. + @ Perform all needed subtractions to keep only the reminder.
While you're at it, you should perhaps correct the other typo in this line as well?
(remAinder)
arch/arm/lib/lib1funcs.S Boston, MA 02111-1307, USA. */ · line 192
Quoted 9 lines
arch/arm/lib/lib1funcs.S +1
-1@ Do comparisons in batch of 4 first. subs \order, \order, #3 @ yes, 3 is intended here blt 2f@@ -189,7 +189,7 @@ Boston, MA 02111-1307, USA. */ teqne \dividend, #0 beq 5f - @ Either 1, 2 or 3 comparison/substractions are left. + @ Either 1, 2 or 3 comparison/subtractions are left.
Same here -> comparisonS (plural)
Quoted 11 lines
arch/arm/lib/lib1funcs.S +0
-12: cmn \order, #2 blt 4f beq 3f --2.1.4
_______________________________________________
linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 1/1 ARM: lib/lib1funcs.S: fix typo s/substractions/subtractions/
While at it also fix some other typos in the affected lines:
s/reminder/remainder/
s/comparison/comparisons/
---
Changes since v1:
- fix the other typos as suggested by Ard.
Ciao,
Antonio
arch/arm/lib/lib1funcs.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/lib/lib1funcs.S +2 -2
@@ -167,7 +167,7 @@ Boston, MA 02111-1307, USA. */ #endif - @ Perform all needed substractions to keep only the reminder. + @ Perform all needed subtractions to keep only the remainder. @ Do comparisons in batch of 4 first. subs \order, \order, #3 @ yes, 3 is intended here blt 2f
@@ -189,7 +189,7 @@ Boston, MA 02111-1307, USA. */ teqne \dividend, #0 beq 5f - @ Either 1, 2 or 3 comparison/substractions are left. + @ Either 1, 2 or 3 comparisons/subtractions are left. 2: cmn \order, #2 blt 4f beq 3f
Signature · 1 line
2.1.4
PATCH 4/12 trivial: ARM: lib/lib1funcs.S: fix typo s/substractions/subtractions/
In reply to Antonio OspiteQuoted 2 lines · Antonio Ospite
Signed-off-by Antonio Ospite <[email protected]>Cc Russell King <[email protected]>
Thanks.
Quoted 31 lines
Cc Christoffer Dall <[email protected]>Cc linux-arm-kernel at lists.infradead.org--- arch/arm/lib/lib1funcs.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/lib/lib1funcs.S +2
-2@@ -167,7 +167,7 @@ Boston, MA 02111-1307, USA. */ #endif - @ Perform all needed substractions to keep only the reminder. + @ Perform all needed subtractions to keep only the reminder. @ Do comparisons in batch of 4 first. subs \order, \order, #3 @ yes, 3 is intended here blt 2f@@ -189,7 +189,7 @@ Boston, MA 02111-1307, USA. */ teqne \dividend, #0 beq 5f - @ Either 1, 2 or 3 comparison/substractions are left. + @ Either 1, 2 or 3 comparison/subtractions are left. 2: cmn \order, #2 blt 4f beq 3fSignature · 1 line
2.1.4
Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.
PATCH 5/12 trivial: ASoC: adau1977: fix typo s/Substraction/Subtraction/
In reply to a message not in the archive--- sound/soc/codecs/adau1977.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/adau1977.c +1 -1
@@ -202,7 +202,7 @@ static const struct snd_soc_dapm_route adau1977_dapm_routes[] = { ADAU1977_REG_DC_HPF_CAL, (x) - 1, 1, 0)#define ADAU1977_DC_SUB_SWITCH (x) \ - SOC_SINGLE("ADC" #x " DC Substraction Capture Switch", \ + SOC_SINGLE("ADC" #x " DC Subtraction Capture Switch", \ ADAU1977_REG_DC_HPF_CAL, (x) + 3, 1, 0)static const struct snd_kcontrol_new adau1977_snd_controls[] = {
Signature · 1 line
2.1.4
Re: [PATCH 05/12] trivial: ASoC: adau1977: fix typo s/Substraction/Subtraction/
Quoted 4 lines · Antonio Ospite
Signed-off-by Antonio Ospite <[email protected]>Cc Lars-Peter Clausen <[email protected]>Cc Mark Brown <[email protected]>
Thanks.
Re: [PATCH 05/12] trivial: ASoC: adau1977: fix typo s/Substraction/Subtraction/
In reply to Antonio OspiteQuoted 1 line · Antonio Ospite
Signed-off-by Antonio Ospite <[email protected]>
Applied, but please use subject lines reflecting the style for the subsystem and don't send only a single patch for a series.
Re: [PATCH 05/12] trivial: ASoC: adau1977: fix typo s/Substraction/Subtraction/
Quoted 5 lines · On Tue, 28 Apr 2015 17:00:24 +0100 Mark Brown <[email protected]> wrote:
Quoted 1 line · Antonio Ospite
Signed-off-by Antonio Ospite <[email protected]>Applied, but please use subject lines reflecting the style for the subsystem and don't send only a single patch for a series.
Hi Mark,
I tried to follow the subject style for the subsystem, but then I prefixed it with "trivial" to highlight that I was sending an aggregate set of unrelated patches to [email protected], that's also why I didn't want to CC everyone on every patch: to reduce noise.
Maybe involving [email protected] for changes which apply to a _specific_ subsystem is not necessary at all, next time I will just aggregate by subsystem.
As a rule of thumb I will use [email protected] only for trivial changes which span different subsystems and still make sense to have in a single patch.
Thanks for making me notice that.
Ciao,
Antonio
Signature · 6 lines
Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Mark Brown
maintainerRe: [PATCH 05/12] trivial: ASoC: adau1977: fix typo s/Substraction/Subtraction/
Quoted 4 lines · Antonio Ospite
I tried to follow the subject style for the subsystem, but then I prefixed it with "trivial" to highlight that I was sending an aggregate set of unrelated patches to [email protected], that's also why I didn't want to CC everyone on every patch: to reduce noise.
That's not really helpful - it means that the patch is more likely to be missed and that the patch sticks out in the changelog.
Quoted 3 lines
Maybe involving [email protected] for changes which apply to a _specific_ subsystem is not necessary at all, next time I will just aggregate by subsystem.
That's generally better, the expectation should be that maintainers are going to apply even trivial patches and it does make life easier if things go that way (less chance of conflicting changes for example).
PATCH 6/12 trivial: MIPS: Netlogic: xlp/ahci-init-xlp2.c fix 0x0x prefixes
In reply to a message not in the archiveFix the 0x0x prefix in integer constants, in this case the registers interval is actually 0x8065 .. 0x80A4 as confirmed some lines above in the code.
--- arch/mips/netlogic/xlp/ahci-init-xlp2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/netlogic/xlp/ahci-init-xlp2.c +1 -1
@@ -152,7 +152,7 @@ static const u8 sata_phy_config1[] = {0xC9 ,0xC9 ,0x07 ,0x07 ,0x18 ,0x18 ,0x01 ,0x01 ,0x22 ,0x00 }; -/* SATA PHY config for register block 2 0x0x8065 .. 0x0x80A4 */ +/* SATA PHY config for register block 2 0x8065 .. 0x80A4 */ static const u8 sata_phy_config2[] = {0xAA ,0x00 ,0x4C ,0xC9 ,0xC9 ,0x07 ,0x07 ,0x18 , 0x18, 0x05, 0x0C, 0x10, 0x00, 0x10, 0x00, 0xFF,
Signature · 1 line
2.1.4
PATCH 7/12 trivial: [media] cx25821: cx25821-medusa-reg.h: fix 0x0x prefix
In reply to a message not in the archiveFix the 0x0x prefix in integer constants.
In this case a padding 0 must also be inserted to make the constants look like all the other 16 bits ones.
--- drivers/media/pci/cx25821/cx25821-medusa-reg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/pci/cx25821/cx25821-medusa-reg.h +3 -3
@@ -84,9 +84,9 @@#define ABIST_BIN4_VGA3 0x01D4#define ABIST_BIN5_VGA4 0x01D8#define ABIST_BIN6_VGA5 0x01DC -#define ABIST_BIN7_VGA6 0x0x1E0 -#define ABIST_CLAMP_A 0x0x1E4 -#define ABIST_CLAMP_B 0x0x1E8 +#define ABIST_BIN7_VGA6 0x01E0 +#define ABIST_CLAMP_A 0x01E4 +#define ABIST_CLAMP_B 0x01E8#define ABIST_CLAMP_C 0x01EC#define ABIST_CLAMP_D 0x01F0#define ABIST_CLAMP_E 0x01F4
Signature · 1 line
2.1.4
Re: [PATCH 07/12] trivial: [media] cx25821: cx25821-medusa-reg.h: fix 0x0x prefix
Quoted 8 lines · Antonio Ospite
Fix the 0x0x prefix in integer constants.
In this case a padding 0 must also be inserted to make the constants look like all the other 16 bits ones.
Signed-off-by Antonio Ospite <[email protected]>Cc Mauro Carvalho Chehab <[email protected]>
Doesn't seem to be in linux-next as of today. I am picking it up.
Quoted 24 lines
--- drivers/media/pci/cx25821/cx25821-medusa-reg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/media/pci/cx25821/cx25821-medusa-reg.h +3
-3@@ -84,9 +84,9 @@#define ABIST_BIN4_VGA3 0x01D4#define ABIST_BIN5_VGA4 0x01D8#define ABIST_BIN6_VGA5 0x01DC -#define ABIST_BIN7_VGA6 0x0x1E0 -#define ABIST_CLAMP_A 0x0x1E4 -#define ABIST_CLAMP_B 0x0x1E8 +#define ABIST_BIN7_VGA6 0x01E0 +#define ABIST_CLAMP_A 0x01E4 +#define ABIST_CLAMP_B 0x01E8#define ABIST_CLAMP_C 0x01EC#define ABIST_CLAMP_D 0x01F0#define ABIST_CLAMP_E 0x01F4Signature · 1 line
2.1.4
Signature · 2 lines
Jiri Kosina SUSE Labs
PATCH 8/12 trivial: net: atl1e: atl1e_hw.h: fix 0x0x prefix
In reply to a message not in the archiveFix the 0x0x prefix in an integer constant.
--- drivers/net/ethernet/atheros/atl1e/atl1e_hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/atheros/atl1e/atl1e_hw.h +1 -1
@@ -129,7 +129,7 @@ s32 atl1e_restart_autoneg(struct atl1e_hw *hw);#define TWSI_CTRL_LD_SLV_ADDR_SHIFT 8#define TWSI_CTRL_SW_LDSTART 0x800#define TWSI_CTRL_HW_LDSTART 0x1000 -#define TWSI_CTRL_SMB_SLV_ADDR_MASK 0x0x7F +#define TWSI_CTRL_SMB_SLV_ADDR_MASK 0x7F#define TWSI_CTRL_SMB_SLV_ADDR_SHIFT 15#define TWSI_CTRL_LD_EXIST 0x400000#define TWSI_CTRL_READ_FREQ_SEL_MASK 0x3
Signature · 1 line
2.1.4
Re: [PATCH 08/12] trivial: net: atl1e: atl1e_hw.h: fix 0x0x prefix
From: Antonio Ospite <[email protected]>
Date: Tue, 28 Apr 2015 13:11:27 +0200
Quoted 3 lines
Fix the 0x0x prefix in an integer constant.
Signed-off-by Antonio Ospite <[email protected]>
Applied.
PATCH 10/12 trivial: net: systemport: bcmsysport.h: fix 0x0x prefix
In reply to a message not in the archiveFix the 0x0x prefix in an integer constant.
In this case, while at it, also fix a typo (s/unitcast/unicast/).
--- drivers/net/ethernet/broadcom/bcmsysport.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/broadcom/bcmsysport.h +1 -1
@@ -543,7 +543,7 @@ struct bcm_sysport_tx_counters {u32 jbr;/* RO # of xmited jabber count*/ u32 bytes;/* RO # of xmited byte count */ u32 pok;/* RO # of xmited good pkt */ -u32 uc;/* RO (0x0x4f0)# of xmited unitcast pkt */ +u32 uc;/* RO (0x4f0) # of xmited unicast pkt */ };struct bcm_sysport_mib {
Signature · 1 line
2.1.4
Re: [PATCH 10/12] trivial: net: systemport: bcmsysport.h: fix 0x0x prefix
From: Antonio Ospite <[email protected]>
Date: Tue, 28 Apr 2015 13:11:29 +0200
Quoted 5 lines
Fix the 0x0x prefix in an integer constant.
In this case, while at it, also fix a typo (s/unitcast/unicast/).
Signed-off-by Antonio Ospite <[email protected]>
Applied.