Skip to contentSkip to conversation

clk/samsung fixes for 4.1

GIT PULL Sylwester Nawrocki 2 participants 5 messages Apr 29, 2015 – May 7, 2015

Subsystems (2)
Common clk Arm Samsung Exynos
lore
Share & tools
lore

Sylwester Nawrocki

author
#0 lore raw

The following changes since commit b787f68c36d49bb1d9236f403813641efa74a031:

Linux 4.1-rc1 (2015-04-26 17:59:10 -0700)

are available in the git repository at:

git://linuxtv.org/snawrocki/samsung.git tags/clk-samsung-fixes-4.1

for you to fetch changes up to 6f14d70a32756551a3645efd9508f2bae44e7127:

clk: exynos5420: Restore GATE_BUS_TOP on suspend (2015-04-29 17:44:59 +0200)

----------------------------------------------------------------
clk/samsung fixes for 4.1

Fixes of clk definitions in recently added clock controller driver for exynos5433 SoC and enhancements for DVFS, proper system sleep and secure monitor calls support in this SoC. The exynos5420 patch fixes a serious system sleep regression introduced in 3.19.

----------------------------------------------------------------
Chanwoo Choi (4):
clk: Use CONFIG_ARCH_EXYNOS instead of CONFIG_ARCH_EXYNOS5433
clk: exynos5433: Fix wrong parent clock of sclk_apollo clock
clk: exynos5433: Fix wrong PMS value of exynos5433_pll_rates
clk: exynos5433: Add CLK_SET_RATE_PARENT to support DVFS for big.LITTLE core

Hyungwon Hwang (1):
clk: exynos5433: Add DIV_CPIF to the list of stored registers on suspend

Javier Martinez Canillas (1):
clk: exynos5420: Restore GATE_BUS_TOP on suspend

Jonghwa Lee (3):
clk: exynos5433: Fix wrong offset of PCLK_MSCL_SECURE_SMMU_JPEG
clk: exynos5433: Fix CLK_PCLK_MONOTONIC_CNT clk register assignment
clk: exynos5433: Add CLK_IGNORE_UNUSED flag to clocks for SMC

Joonyoung Shim (1):
clk: exynos5433: Add clock flag to support the DVFS of GPU

 drivers/clk/samsung/Makefile         |    2 +-
 drivers/clk/samsung/clk-exynos5420.c |    1 +
 drivers/clk/samsung/clk-exynos5433.c |   93 +++++++++++++++++-----------------
 3 files changed, 48 insertions(+), 48 deletions(-)
#1 lore raw

Quoting Sylwester Nawrocki (2015-04-29 09:24:12)

Quoted 3 lines

=

The following changes since commit b787f68c36d49bb1d9236f403813641efa74a0=

31:

Quoted 8 lines

=

Linux 4.1-rc1 (2015-04-26 17:59:10 -0700)
=

are available in the git repository at:
=

Quoted 7 lines

git://linuxtv.org/snawrocki/samsung.git tags/clk-samsung-fixes-4.1
=

for you to fetch changes up to 6f14d70a32756551a3645efd9508f2bae44e7127:
=

clk: exynos5420: Restore GATE_BUS_TOP on suspend (2015-04-29 17:44:59 +=

0200)

Quoted 12 lines

=

----------------------------------------------------------------
clk/samsung fixes for 4.1
=

Fixes of clk definitions in recently added clock controller driver for exynos5433 SoC and enhancements for DVFS, proper system sleep and secure monitor calls support in this SoC. The exynos5420 patch fixes a serious system sleep regression introduced in 3.19.
=

Quoted 5 lines

----------------------------------------------------------------
Chanwoo Choi (4):
clk: Use CONFIG_ARCH_EXYNOS instead of CONFIG_ARCH_EXYNOS5433
clk: exynos5433: Fix wrong parent clock of sclk_apollo clock
clk: exynos5433: Fix wrong PMS value of exynos5433_pll_rates

Above 3 look OK.

Quoted 1 line

clk: exynos5433: Add CLK_SET_RATE_PARENT to support DVFS for big.LI=

TTLE core

Above patch doesn't look like a fix for an introduced regression.

Quoted 4 lines

=

Hyungwon Hwang (1):
clk: exynos5433: Add DIV_CPIF to the list of stored registers on su=

spend

Above patch doesn't look like a fix for an introduced regression.

Quoted 9 lines

=

Javier Martinez Canillas (1):
clk: exynos5420: Restore GATE_BUS_TOP on suspend
=

Jonghwa Lee (3):
clk: exynos5433: Fix wrong offset of PCLK_MSCL_SECURE_SMMU_JPEG
clk: exynos5433: Fix CLK_PCLK_MONOTONIC_CNT clk register assignment

Above 3 look OK.

Quoted 1 line

clk: exynos5433: Add CLK_IGNORE_UNUSED flag to clocks for SMC

Above patch doesn't look like a fix for an introduced regression.

Quoted 4 lines

=

Joonyoung Shim (1):
clk: exynos5433: Add clock flag to support the DVFS of GPU

Above patch doesn't look like a fix for an introduced regression.

Regards,
Mike

Quoted 5 lines

=

 drivers/clk/samsung/Makefile         |    2 +-
 drivers/clk/samsung/clk-exynos5420.c |    1 +

drivers/clk/samsung/clk-exynos5433.c | 93 +++++++++++++++++-----------=

------

Quoted 1 line
 3 files changed, 48 insertions(+), 48 deletions(-)
author
#2 lore raw

Hello Mike,

Quoted 21 lines · Michael Turquette

Quoting Sylwester Nawrocki (2015-04-29 09:24:12)

Quoted 11 lines

----------------------------------------------------------------
clk/samsung fixes for 4.1

Fixes of clk definitions in recently added clock controller driver for exynos5433 SoC and enhancements for DVFS, proper system sleep and secure monitor calls support in this SoC. The exynos5420 patch fixes a serious system sleep regression introduced in 3.19.

----------------------------------------------------------------

clk: exynos5433: Add CLK_SET_RATE_PARENT to support DVFS for big.LITTLE core

Above patch doesn't look like a fix for an introduced regression.

Quoted 2 lines

Hyungwon Hwang (1):
clk: exynos5433: Add DIV_CPIF to the list of stored registers on suspend

Above patch doesn't look like a fix for an introduced regression.

Quoted 8 lines
Quoted 1 line

clk: exynos5433: Add CLK_IGNORE_UNUSED flag to clocks for SMC

Above patch doesn't look like a fix for an introduced regression.

Quoted 2 lines

Joonyoung Shim (1):
clk: exynos5433: Add clock flag to support the DVFS of GPU

Above patch doesn't look like a fix for an introduced regression.

Apologies for mixing them up, I'm going to resend above 4 patches for 4.2. The DVFS related patches are indeed not critical, I thought especially the second and third patch above are good for early -rc, since they fix bugs in a driver which was first added in 4.1-rc1. Anyway, I'll resend the dropped patches for 4.2, thanks for queueing the remaining ones.

Signature · 2 lines
Regards,
Sylwester
author
#3 lore raw
In reply to Sylwester Nawrocki

Mike,

this is a corrected version of pull request I sent on 29/04/15.

The following changes since commit b787f68c36d49bb1d9236f403813641efa74a031:

Linux 4.1-rc1 (2015-04-26 17:59:10 -0700)

are available in the git repository at:

git://linuxtv.org/snawrocki/samsung.git tags/clk-samsung-fixes-4.1-2

for you to fetch changes up to 97372e5a99449b4fffa824a382ad6358066a9918:

clk: exynos5420: Restore GATE_BUS_TOP on suspend (2015-05-05 10:51:04 +0200)

----------------------------------------------------------------
clk/samsung fixes for 4.1

- missing CONFIG_ARCH_EXYNOS5433 -> CONFIG_ARCH_EXYNOS substitution to actually enable clk-exynos5433.c compilation,
- fixes of exynos5433 clk tree definitions: register offsets, parent clocks, PLL coefficients,
- fix for exynos5420 system sleep regression introduced in 3.19.

----------------------------------------------------------------
Chanwoo Choi (3):
clk: Use CONFIG_ARCH_EXYNOS instead of CONFIG_ARCH_EXYNOS5433
clk: exynos5433: Fix wrong parent clock of sclk_apollo clock
clk: exynos5433: Fix wrong PMS value of exynos5433_pll_rates

Javier Martinez Canillas (1):
clk: exynos5420: Restore GATE_BUS_TOP on suspend

Jonghwa Lee (2):
clk: exynos5433: Fix wrong offset of PCLK_MSCL_SECURE_SMMU_JPEG
clk: exynos5433: Fix CLK_PCLK_MONOTONIC_CNT clk register assignment

 drivers/clk/samsung/Makefile         |    2 +-
 drivers/clk/samsung/clk-exynos5420.c |    1 +
 drivers/clk/samsung/clk-exynos5433.c |   12 ++++++------
 3 files changed, 8 insertions(+), 7 deletions(-)
Signature · 2 lines
Thanks,
Sylwester
#4 lore raw

Quoting Sylwester Nawrocki (2015-05-05 02:39:50)

Quoted 7 lines

Mike,
=

this is a corrected version of pull request I sent on 29/04/15. =

The following changes since commit b787f68c36d49bb1d9236f403813641efa74a0=

31:

Quoted 9 lines

=

Linux 4.1-rc1 (2015-04-26 17:59:10 -0700)
=

are available in the git repository at:
=

git://linuxtv.org/snawrocki/samsung.git tags/clk-samsung-fixes-4.1-2

Pulled into clk-fixes.

Thanks for for the resend!

Regards,
Mike

Quoted 6 lines

=

for you to fetch changes up to 97372e5a99449b4fffa824a382ad6358066a9918:
=

clk: exynos5420: Restore GATE_BUS_TOP on suspend (2015-05-05 10:51:04 +=

0200)

Quoted 39 lines

=

----------------------------------------------------------------
clk/samsung fixes for 4.1
=

- missing CONFIG_ARCH_EXYNOS5433 -> CONFIG_ARCH_EXYNOS substitution to actually enable clk-exynos5433.c compilation,
- fixes of exynos5433 clk tree definitions: register offsets, parent clocks, PLL coefficients,
- fix for exynos5420 system sleep regression introduced in 3.19.
=

----------------------------------------------------------------
Chanwoo Choi (3):
clk: Use CONFIG_ARCH_EXYNOS instead of CONFIG_ARCH_EXYNOS5433
clk: exynos5433: Fix wrong parent clock of sclk_apollo clock
clk: exynos5433: Fix wrong PMS value of exynos5433_pll_rates
=

Javier Martinez Canillas (1):
clk: exynos5420: Restore GATE_BUS_TOP on suspend
=

Jonghwa Lee (2):
clk: exynos5433: Fix wrong offset of PCLK_MSCL_SECURE_SMMU_JPEG
clk: exynos5433: Fix CLK_PCLK_MONOTONIC_CNT clk register assignment
=

 drivers/clk/samsung/Makefile         |    2 +-
 drivers/clk/samsung/clk-exynos5420.c |    1 +
 drivers/clk/samsung/clk-exynos5433.c |   12 ++++++------
 3 files changed, 8 insertions(+), 7 deletions(-)

=

-- =

Thanks,
Sylwester