ARM: vexpress: Add unified-cache Device Tree property
Subsystems (2)
PATCH 1/1 ARM: vexpress: Add unified-cache Device Tree property
Without this propergy, we get this boot warning:
"L2C: device tree omits to specify unified cache"
--- arch/arm/boot/dts/vexpress-v2p-ca9.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/vexpress-v2p-ca9.dts +1 -0
@@ -170,6 +170,7 @@ compatible = "arm,pl310-cache"; reg = <0x1e00a000 0x1000>; interrupts = <0 43 4>; + cache-unified; cache-level = <2>; arm,data-latency = <1 1 1>; arm,tag-latency = <1 1 1>;
Signature · 1 line
2.1.4
PATCH 1/1 ARM: vexpress: Add unified-cache Device Tree property
Quoted 2 lines · Robert Schwebel
Without this propergy, we get this boot warning:
^^property
Quoted 3 lines
"L2C: device tree omits to specify unified cache"
Signed-off-by Robert Schwebel <[email protected]>
Quoted 17 lines
--- arch/arm/boot/dts/vexpress-v2p-ca9.dts | 1 + 1 file changed, 1 insertion(+)arch/arm/boot/dts/vexpress-v2p-ca9.dts +1
-0@@ -170,6 +170,7 @@ compatible = "arm,pl310-cache"; reg = <0x1e00a000 0x1000>; interrupts = <0 43 4>; + cache-unified; cache-level = <2>; arm,data-latency = <1 1 1>; arm,tag-latency = <1 1 1>;
PATCH 1/1 ARM: vexpress: Add unified-cache Device Tree property
Quoted 4 lines · Sudeep Holla
Quoted 2 lines · Robert Schwebel
Without this propergy, we get this boot warning:
^^property
Uh, sorry, will fix.
Quoted 5 lines
Quoted 3 lines
"L2C: device tree omits to specify unified cache"
Signed-off-by Robert Schwebel <[email protected]>Acked-by Sudeep Holla <[email protected]>
Thanks.
rsc
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
In reply to Sudeep HollaWithout this property, we get this boot warning:
"L2C: device tree omits to specify unified cache"
--- arch/arm/boot/dts/vexpress-v2p-ca9.dts | 1 + 1 file changed, 1 insertion(+)
Changes since v1:
* fix typo in patch description
arch/arm/boot/dts/vexpress-v2p-ca9.dts +1 -0
@@ -170,6 +170,7 @@ compatible = "arm,pl310-cache"; reg = <0x1e00a000 0x1000>; interrupts = <0 43 4>; + cache-unified; cache-level = <2>; arm,data-latency = <1 1 1>; arm,tag-latency = <1 1 1>;
Signature · 1 line
2.1.4
PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
Hi Liviu,
Quoted 27 lines · Robert Schwebel
Without this property, we get this boot warning:
"L2C: device tree omits to specify unified cache"
Signed-off-by Robert Schwebel <[email protected]>Acked-by Sudeep Holla <[email protected]>--- arch/arm/boot/dts/vexpress-v2p-ca9.dts | 1 + 1 file changed, 1 insertion(+)Changes since v1:
* fix typo in patch descriptionarch/arm/boot/dts/vexpress-v2p-ca9.dts +1
-0@@ -170,6 +170,7 @@ compatible = "arm,pl310-cache"; reg = <0x1e00a000 0x1000>; interrupts = <0 43 4>; + cache-unified; cache-level = <2>; arm,data-latency = <1 1 1>; arm,tag-latency = <1 1 1>;Signature · 1 line
2.1.4
Gentle ping, this patch didn't make it into 4.1-rc1.
rsc
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Liviu Dudau
maintainerPATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
Quoted 16 lines · Robert Schwebel
Hi Liviu,
Quoted 13 lines · Robert Schwebel
Without this property, we get this boot warning:
"L2C: device tree omits to specify unified cache"
Signed-off-by Robert Schwebel <[email protected]>Acked-by Sudeep Holla <[email protected]>--- arch/arm/boot/dts/vexpress-v2p-ca9.dts | 1 + 1 file changed, 1 insertion(+)Changes since v1:
* fix typo in patch description
Quoted 16 lines
Quoted 14 lines
arch/arm/boot/dts/vexpress-v2p-ca9.dts +1
-0@@ -170,6 +170,7 @@ compatible = "arm,pl310-cache"; reg = <0x1e00a000 0x1000>; interrupts = <0 43 4>; + cache-unified; cache-level = <2>; arm,data-latency = <1 1 1>; arm,tag-latency = <1 1 1>;Signature · 1 line
2.1.4Gentle ping, this patch didn't make it into 4.1-rc1.
Sorry Robert, this fell through the cracks. VExpress gets very few patches in general and we're new to this :(
Arnd/Olof, can we add this and Sudeep's patch for Juno into one of the later 4.1-rc pull requests?
Best regards,
Liviu
Quoted 13 lines
rsc
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 8 lines
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
?\_(?)_/?PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
Hi Liviu,
Quoted 2 lines · Liviu Dudau
Sorry Robert, this fell through the cracks. VExpress gets very few patches in general and we're new to this :(
Thanks for the help!
I still see these errors with 4.1-rc1:
[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link [ 0.426298] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller at 100e0000 [ 0.426799] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller at 100e1000 [ 0.427099] of_amba_device_create(): amba_device_add() failed (-19) for /watchdog at 100e5000 [ 0.433206] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga at 7,00000000/sysctl at 01000 [ 0.438165] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga at 7,00000000/wdt at 0f000
Do you have an idea what might go wrong?
rsc
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Liviu Dudau
maintainerPATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
Quoted 22 lines · Robert Schwebel
Hi Liviu,
Quoted 2 lines · Liviu Dudau
Sorry Robert, this fell through the cracks. VExpress gets very few patches in general and we're new to this :(
Thanks for the help!
I still see these errors with 4.1-rc1:
[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link [ 0.426298] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller at 100e0000 [ 0.426799] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller at 100e1000 [ 0.427099] of_amba_device_create(): amba_device_add() failed (-19) for /watchdog at 100e5000 [ 0.433206] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga at 7,00000000/sysctl at 01000 [ 0.438165] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga at 7,00000000/wdt at 0f000
Quoted 1 line
Do you have an idea what might go wrong?
No, not yet. I will give it a go on my TC2 board.
Best regards,
Liviu
Quoted 8 lines
rsc
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Signature · 8 lines
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
?\_(?)_/?PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
In reply to Robert SchwebelQuoted 8 lines · Robert Schwebel
Hi Liviu,
Quoted 2 lines · Liviu Dudau
Sorry Robert, this fell through the cracks. VExpress gets very few patches in general and we're new to this :(
Thanks for the help!
Quoted 8 lines
I still see these errors with 4.1-rc1:
[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link
I see above errors even on my Vexpress TC2, but
Quoted 6 lines
[ 0.426298] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller at 100e0000 [ 0.426799] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller at 100e1000 [ 0.427099] of_amba_device_create(): amba_device_add() failed (-19) for /watchdog at 100e5000 [ 0.433206] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga at 7,00000000/sysctl at 01000 [ 0.438165] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga at 7,00000000/wdt at 0f000
.. not theses ones
Quoted 2 lines
Do you have an idea what might go wrong?
I will give it a spin on my CA9 coretile.
Regards,Sudeep
PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
Quoted 15 lines · Sudeep Holla
Quoted 6 lines
[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node linkI see above errors even on my Vexpress TC2, but
Quoted 6 lines
[ 0.426298] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller at 100e0000 [ 0.426799] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller at 100e1000 [ 0.427099] of_amba_device_create(): amba_device_add() failed (-19) for /watchdog at 100e5000 [ 0.433206] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga at 7,00000000/sysctl at 01000 [ 0.438165] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga at 7,00000000/wdt at 0f000
Quoted 6 lines
.. not theses ones
Quoted 2 lines
Do you have an idea what might go wrong?
I will give it a spin on my CA9 coretile.
I'm testing on qemu (and not even the latest one), so this might be a reason.
rsc
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
Quoted 18 lines · Robert Schwebel
Quoted 17 lines · Sudeep Holla
Quoted 6 lines
[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node linkI see above errors even on my Vexpress TC2, but
Quoted 6 lines
[ 0.426298] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller at 100e0000 [ 0.426799] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller at 100e1000 [ 0.427099] of_amba_device_create(): amba_device_add() failed (-19) for /watchdog at 100e5000 [ 0.433206] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga at 7,00000000/sysctl at 01000 [ 0.438165] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga at 7,00000000/wdt at 0f000.. not theses ones
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Do you have an idea what might go wrong?
I will give it a spin on my CA9 coretile.
I'm testing on qemu (and not even the latest one), so this might be a reason.
OK, I tried on my CA9 coretile and don't see these errors on it either. However the "... creating of_node link" is present on both and I will look at that issue.
Regards,
Sudeep
PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
In reply to Robert SchwebelQuoted 8 lines · Robert Schwebel
Hi Liviu,
Quoted 2 lines · Liviu Dudau
Sorry Robert, this fell through the cracks. VExpress gets very few patches in general and we're new to this :(
Thanks for the help!
Quoted 8 lines
I still see these errors with 4.1-rc1:
[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link
OK, I was able to debug this, it boils down to initcall ordering. Both of_init where the firmware sysfs is initialized and vexpress_sysreg_init are at same core_initcall level. Needs some thinking and more time to fix this.
Regards,
Sudeep
PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
Hi Sudeep,
Quoted 9 lines · Sudeep Holla
Quoted 8 lines
I still see these errors with 4.1-rc1:
[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link
Quoted 4 lines
OK, I was able to debug this, it boils down to initcall ordering. Both
of_initwhere the firmware sysfs is initialized andvexpress_sysreg_initare at samecore_initcalllevel. Needs some thinking and more time to fix this.
Did you find out something in the meantime?
I just tested 4.1-rc3 and the issues are still confirmed.
Thanks,
rsc
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
Quoted 12 lines · Robert Schwebel
Hi Sudeep,
Quoted 9 lines · Sudeep Holla
Quoted 8 lines
I still see these errors with 4.1-rc1:
[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link
Quoted 8 lines
Quoted 4 lines
OK, I was able to debug this, it boils down to initcall ordering. Both
of_initwhere the firmware sysfs is initialized andvexpress_sysreg_initare at samecore_initcalllevel. Needs some thinking and more time to fix this.Did you find out something in the meantime?
I just tested 4.1-rc3 and the issues are still confirmed.
Ah sorry, forgot to include you or your Reported-by(will fix that if/when I have to repost a newer version) I posted the patch but not yet pulled in mainline yet [1]
Regards,
Sudeep
PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
In reply to Robert SchwebelHi Sundeep,
Quoted 10 lines · Robert Schwebel
Quoted 9 lines · Sudeep Holla
Quoted 8 lines
I still see these errors with 4.1-rc1:
[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link
Quoted 7 lines
Quoted 4 lines
OK, I was able to debug this, it boils down to initcall ordering. Both
of_initwhere the firmware sysfs is initialized andvexpress_sysreg_initare at samecore_initcalllevel. Needs some thinking and more time to fix this.Did you find out something in the meantime?
I just tested 4.1-rc3 and the issues are still confirmed.
Gentle ping ...
rsc
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH v2 1/1 ARM: vexpress: Add unified-cache Device Tree property
Quoted 4 lines · Robert Schwebel
Quoted 2 lines
Did you find out something in the meantime?
I just tested 4.1-rc3 and the issues are still confirmed.Gentle ping ...
Sorry, missed the other mail and found it in the mean time :)
rsc
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |