Skip to contentSkip to conversation

ARM: vexpress: Add interrupt-affinity

PATCH New Robert Schwebel 2 participants 3 messages Apr 30, 2015 – May 1, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 ARM: vexpress: Add interrupt-affinity

Without this property, we get this boot warning:

[    0.459361] CPU PMU: Failed to parse <no-node>/interrupt-affinity[0]
---
 arch/arm/boot/dts/vexpress-v2p-ca9.dts | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
arch/arm/boot/dts/vexpress-v2p-ca9.dts +9 -4
index a411274..9d71493 100644
@@ -33,28 +33,28 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		cpu at 0 {
+		A9_0: cpu at 0 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a9";
 			reg = <0>;
 			next-level-cache = <&L2>;
 		};
 
-		cpu at 1 {
+		A9_1: cpu at 1 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a9";
 			reg = <1>;
 			next-level-cache = <&L2>;
 		};
 
-		cpu at 2 {
+		A9_2: cpu at 2 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a9";
 			reg = <2>;
 			next-level-cache = <&L2>;
 		};
 
-		cpu at 3 {
+		A9_3: cpu at 3 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a9";
 			reg = <3>;
@@ -182,6 +182,11 @@
 			     <0 61 4>,
 			     <0 62 4>,
 			     <0 63 4>;
+		interrupt-affinity = <&A9_0>,
+		                     <&A9_1>,
+		                     <&A9_2>,
+		                     <&A9_3>;
+
 	};
 
 	dcc {
Signature · 1 line
2.1.4
#1 lore raw

PATCH 2/2 ARM: vexpress: Add interrupt-affinity

Quoted 5 lines · Robert Schwebel

Without this property, we get this boot warning:

[    0.459361] CPU PMU: Failed to parse <no-node>/interrupt-affinity[0]

However, with this patch applied, the messages above disappear, but I still get this:

[    0.495280] CPU PMU: Failed to find logical CPU for cpu

on a kernel configured with CONFIG_SMP=n. nr_cpu_ids is 1 there, while the loop still loops over all available cores. Ths makes the logic fail.

rsc

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#2 lore raw

PATCH 2/2 ARM: vexpress: Add interrupt-affinity

Quoted 6 lines · Robert Schwebel
Quoted 5 lines · Robert Schwebel

Without this property, we get this boot warning:

[    0.459361] CPU PMU: Failed to parse <no-node>/interrupt-affinity[0]

May be you can also mention the commit introducing the change in the log something like:

"
Commit 9fd85eb502a7 ("ARM: pmu: add support for interrupt-affinity property") added optional optional "interrupt-affinity" property, to specify CPU affinity for each SPI listed in the interrupts property.

Without this property, we get this boot warning:
CPU PMU: Failed to parse <no-node>/interrupt-affinity[0]

This patch add interrupt-affinity to the PMU node in CA9x4 device tree. "

Otherwise:

Quoted 8 lines

However, with this patch applied, the messages above disappear, but I still get this:

[    0.495280] CPU PMU: Failed to find logical CPU for cpu

on a kernel configured with CONFIG_SMP=n. nr_cpu_ids is 1 there, while the loop still loops over all available cores. Ths makes the logic fail.

This is a different issue. You must also see warning from devtree.c when parsing CPUs complaining about more CPU nodes found in DT. IIUC the functionality still works fine.

Regards,
Sudeep