Skip to contentSkip to conversation

A10s Olinuxino Micro DT SPI patches

PATCH In review Michal Suchanek 2 participants 7 messages Apr 29, 2015 – May 1, 2015

Subsystems (2)
Device tree bindings Arm/Allwinner sunXi SoC support
lore
Share & tools
lore

Michal Suchanek

author
#0 lore raw

cover A10s Olinuxino Micro DT SPI patches

Hello,

this adds spi2 bus on A10s Olinuxino Micro board.

Thanks

Michal

Michal Suchanek (4):
ARM: dts: sunxi: sun5i: add spi2_pins_b.
ARM: dts: sunxi: sun5i-a10s: add spi2_pins_a.
ARM: dts: sunxi: A10s Olinuxino Micro: add spi2.
ARM: dts: sunxi: Add SPI aliases on A10s Olinuxino.

 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 9 +++++++++
 arch/arm/boot/dts/sun5i-a10s.dtsi                | 8 ++++++++
 arch/arm/boot/dts/sun5i.dtsi                     | 7 +++++++
 3 files changed, 24 insertions(+)
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 1/4 ARM: dts: sunxi: sun5i: add spi2_pins_b.

spi2_pins_a are only available on A10s

Signed-off-by Michal Suchanek <[email protected]>
---
 arch/arm/boot/dts/sun5i.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/sun5i.dtsi +7 -0
index 186d25f..9f22c28 100644
@@ -551,6 +551,13 @@
 				allwinner,drive = <SUN4I_PINCTRL_30_MA>;
 				allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
 			};
+
+			spi2_pins_b: spi2 at 1 {
+				allwinner,pins = "PE00", "PE01", "PE02", "PE03";
+				allwinner,function = "spi2";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
 		};
 
 		timer at 01c20c00 {
Signature · 1 line
2.1.4
#2 lore raw

Re: [PATCH 1/4] ARM: dts: sunxi: sun5i: add spi2_pins_b.

Quoted 1 line · Michal Suchanek

spi2_pins_a are only available on A10s

spi2_pins_a doesn't mean anything without any context.

Anyone should be able to read this commit log alone and understand what it's about and why you are doing it.

It's clearly not the case here.

Quoted 11 lines
Signed-off-by Michal Suchanek <[email protected]>
---
 arch/arm/boot/dts/sun5i.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/sun5i.dtsi +0 -0
index 186d25f..9f22c28 100644

arch/arm/boot/dts/sun5i.dtsi line 555

Quoted 5 lines
arch/arm/boot/dts/sun5i.dtsi +2 -0
@@ -551,6 +551,13 @@
 				allwinner,drive = <SUN4I_PINCTRL_30_MA>;
 				allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
 			};
+
+			spi2_pins_b: spi2 at 1 {

You should probably name that group spi2_pins_a. It feels a bit weird to have a spi2_pins_b group without its "a" counterpart.

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150501/7496b708/attachment-0001.sig>
author
#3 lore raw

PATCH 2/4 ARM: dts: sunxi: sun5i-a10s: add spi2_pins_a.

In reply to Michal Suchanek

Extra SPI pins on A10s not shared with A13.

Signed-off-by Michal Suchanek <[email protected]>
---
 arch/arm/boot/dts/sun5i-a10s.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/sun5i-a10s.dtsi +8 -0
index a78c95d..3cdd122 100644
@@ -198,4 +198,12 @@
 		allwinner,drive = <SUN4I_PINCTRL_30_MA>;
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 	};
+
+	spi2_pins_a: spi2 at 0 {
+		allwinner,pins = "PB11", "PB12", "PB13", "PB14";
+		allwinner,function = "spi2";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+	};
+
 };
Signature · 1 line
2.1.4
author
#4 lore raw

PATCH 3/4 ARM: dts: sunxi: A10s Olinuxino Micro: add spi2.

In reply to Michal Suchanek

spi2 is exposed on the UEXT connector.

Signed-off-by Michal Suchanek <[email protected]>
---
 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts +6 -0
index aa88ee8..cd8d08a 100644
@@ -182,6 +182,12 @@
 	status = "okay";
 };
 
+&spi2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi2_pins_a>;
+	status = "okay";
+};
+
 &ohci0 {
 	status = "okay";
 };
Signature · 1 line
2.1.4
author
#5 lore raw

PATCH 4/4 ARM: dts: sunxi: Add SPI aliases on A10s Olinuxino.

In reply to Michal Suchanek

SPI aliases give nicer spidev device node names.

Signed-off-by Michal Suchanek <[email protected]>
---
 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts +3 -0
index cd8d08a..a49fc6a 100644
@@ -63,6 +63,9 @@
 		serial0 = &uart0;
 		serial1 = &uart2;
 		serial2 = &uart3;
+		spi0 = &spi0;
+		spi1 = &spi1;
+		spi2 = &spi2;
 	};
 
 	leds {
Signature · 1 line
2.1.4
#6 lore raw

Re: [PATCH 4/4] ARM: dts: sunxi: Add SPI aliases on A10s Olinuxino.

Quoted 12 lines · Michal Suchanek

SPI aliases give nicer spidev device node names.

Signed-off-by Michal Suchanek <[email protected]>
---
 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts +0 -0
index cd8d08a..a49fc6a 100644

arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts line 68

Quoted 6 lines
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts +3 -0
@@ -63,6 +63,9 @@
 		serial0 = &uart0;
 		serial1 = &uart2;
 		serial2 = &uart3;
+		spi0 = &spi0;
+		spi1 = &spi1;
+		spi2 = &spi2;

That patch should be merged with the patch 3, and since there's only spi2 in use on that board, it should be aliased to spi0.

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150501/48a47c75/attachment-0001.sig>