Skip to contentSkip to conversation

autobuild-run: do not build evtest using extrenal arc-2014.12 toolchain

PATCH New Alexey Brodkin 2 participants 2 messages Mar 24, 2015 – May 1, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 autobuild-run: do not build evtest using extrenal arc-2014.12 toolchain

This external arc-2014.12 toolchain has uClibc with disabled UCLIBC_HAS_PROGRAM_INVOCATION_NAME.

Because of this following build failure happens in autobuilder -
http://autobuild.buildroot.net/results/0fd/0fd36a0d79c4d82aedebb5aca8d3ce4214b1ed61/
--->8---
evtest.c: In function 'version':
evtest.c:730:20: error: 'program_invocation_short_name' undeclared (first use in this function)

  printf("%s %s\n", program_invocation_short_name, PACKAGE_VERSION);
                    ^

evtest.c:730:20: note: each undeclared identifier is reported only once for each function it appears in evtest.c: In function 'usage':
evtest.c:742:38: error: 'program_invocation_short_name' undeclared (first use in this function)
printf(" %s /dev/input/eventX\n", program_invocation_short_name);
--->8---

Mentioned config option was recently enabled in uClibc's defconfig for ARC:
https://github.com/foss-for-synopsys-dwc-arc-processors/uClibc/commit/c2460b9b7b8c76098dfb1313be4aa4a4a65ff619

So newer ARC uClibc toolchains should build evtest perfectly well.

Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Peter Seiderer <[email protected]>
---
 scripts/autobuild-run | 4 ++++
 1 file changed, 4 insertions(+)
scripts/autobuild-run +4 -0
index 872ee9d..69637f2 100755
@@ -420,6 +420,10 @@ def fixup_config(**kwargs):
     if 'BR2_PACKAGE_WESTON=y\n' in configlines and \
        'BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/mipsel-ctng-linux-uclibc.tar.xz"\n' in configlines:
         return False
+    # This ARC uClibc toolchain fails to build the evtest package
+    if 'BR2_PACKAGE_EVTEST=y\n' in configlines and \
+       'BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_2014_12=y\n' in configlines:
+        return False
 
     with open(os.path.join(outputdir, ".config"), "w+") as configf:
         configf.writelines(configlines)
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 autobuild-run: do not build evtest using extrenal arc-2014.12 toolchain

Dear Alexey Brodkin,

Quoted 8 lines · Alexey Brodkin

This external arc-2014.12 toolchain has uClibc with disabled UCLIBC_HAS_PROGRAM_INVOCATION_NAME.

Because of this following build failure happens in autobuilder -
http://autobuild.buildroot.net/results/0fd/0fd36a0d79c4d82aedebb5aca8d3ce4214b1ed61/
--->8---
evtest.c: In function 'version':
evtest.c:730:20: error: 'program_invocation_short_name' undeclared (first use in this function)

Quoted 7 lines
  printf("%s %s\n", program_invocation_short_name, PACKAGE_VERSION);
                    ^

evtest.c:730:20: note: each undeclared identifier is reported only once for each function it appears in evtest.c: In function 'usage':
evtest.c:742:38: error: 'program_invocation_short_name' undeclared (first use in this function)
printf(" %s /dev/input/eventX\n", program_invocation_short_name);
--->8---

I've marked this patch as Rejected, since I have committed another patch to mark the Synopsys ARC external toolchain as "broken" because the uClibc configuration is too far from the default Buildroot uClibc configuration. We'll re-enable this toolchain once a new release is made upstream, as we discussed.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com