package/efl/libevas: x-includes and x-libraries must be set for cross-compiling
PATCH 1/1 package/efl/libevas: x-includes and x-libraries must be set for cross-compiling
evas_engine_software_xlib_cflags and evas_engine_software_xlib_libs contains unsafe libraries paths if x-include and x-libraries are not set in libevas.mk.
config.log:
evas_engine_software_xlib_cflags='-I/usr/X11R6/include' evas_engine_software_xlib_libs='-L/usr/X11R6/lib -lX11 -lXext'
Fixes:
http://autobuild.buildroot.net/results/e5f/e5fb1e62cb634b20233751b4ea3b0630de70e9e0/
--- package/efl/libevas/libevas.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
package/efl/libevas/libevas.mk +4 -1
@@ -63,7 +63,10 @@ LIBEVAS_CONF_OPTS += --enable-buffer endif ifeq ($(BR2_PACKAGE_LIBEVAS_X11),y) -LIBEVAS_CONF_OPTS += --enable-software-xlib +LIBEVAS_CONF_OPTS += --enable-software-xlib \ + --with-x=$(STAGING_DIR) \ + --x-includes=$(STAGING_DIR)/usr/include \ + --x-libraries=$(STAGING_DIR)/usr/lib LIBEVAS_DEPENDENCIES += xlib_libX11 xlib_libXext else LIBEVAS_CONF_OPTS += --disable-software-xlib
Signature · 1 line
1.9.3
PATCH 1/1 package/efl/libevas: x-includes and x-libraries must be set for cross-compiling
Dear Romain Naour,
Quoted 8 lines · Romain Naour
evas_engine_software_xlib_cflagsandevas_engine_software_xlib_libscontains unsafe libraries paths if x-include and x-libraries are not set in libevas.mk.config.log:
evas_engine_software_xlib_cflags='-I/usr/X11R6/include' evas_engine_software_xlib_libs='-L/usr/X11R6/lib -lX11 -lXext'
Quoted 7 lines
Fixes:
http://autobuild.buildroot.net/results/e5f/e5fb1e62cb634b20233751b4ea3b0630de70e9e0/Signed-off-by Romain Naour <[email protected]>--- package/efl/libevas/libevas.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks. I've done a second commit on libecore with the exact same fix, because the exact same problem occurred on libecore in my test build. See
http://git.buildroot.net/buildroot/commit/?id=0d9d8984a9240a27f5ed2e15f1977ada67266906.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 package/efl/libevas: x-includes and x-libraries must be set for cross-compiling
Hi Thomas,
Le 03/05/2015 11:46, Thomas Petazzoni a ?crit :
Quoted 19 lines
Dear Romain Naour,
Quoted 8 lines · Romain Naour
evas_engine_software_xlib_cflagsandevas_engine_software_xlib_libscontains unsafe libraries paths if x-include and x-libraries are not set in libevas.mk.config.log:
evas_engine_software_xlib_cflags='-I/usr/X11R6/include' evas_engine_software_xlib_libs='-L/usr/X11R6/lib -lX11 -lXext'Quoted 7 lines
Fixes:
http://autobuild.buildroot.net/results/e5f/e5fb1e62cb634b20233751b4ea3b0630de70e9e0/Signed-off-by Romain Naour <[email protected]>--- package/efl/libevas/libevas.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 4 lines
Applied, thanks. I've done a second commit on libecore with the exact same fix, because the exact same problem occurred on libecore in my test build. See
http://git.buildroot.net/buildroot/commit/?id=0d9d8984a9240a27f5ed2e15f1977ada67266906.
This is what this path does ;)
http://patchwork.ozlabs.org/patch/467259/
Thanks for fixing this.
Best regards,
Romain
Quoted 5 lines
Best regards,
Thomas
PATCH 1/1 package/efl/libevas: x-includes and x-libraries must be set for cross-compiling
Dear Romain Naour,
Quoted 2 lines · Romain Naour
This is what this path does ;)
http://patchwork.ozlabs.org/patch/467259/
Ah, shit, I messed up. I marked this patch as superseded because for me it was an incorrect previous version of the libevas patch. Sorry about that :-/
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 package/efl/libevas: x-includes and x-libraries must be set for cross-compiling
Hi Thomas,
Le 03/05/2015 12:15, Thomas Petazzoni a ?crit :
Quoted 10 lines
Dear Romain Naour,
Quoted 2 lines · Romain Naour
This is what this path does ;)
http://patchwork.ozlabs.org/patch/467259/Ah, shit, I messed up. I marked this patch as superseded because for me it was an incorrect previous version of the libevas patch. Sorry about that :-/
No problem at all :)
I only marked the first patch as Rejected in the patchwork. I had to send the complete series, instead of send a separate patch.
Best regards,
Romain
Quoted 3 lines
Thomas