arm64: Add multiboot support (via fdt) for Xen boot

PATCH Superseded Fu Wei 4 participants 9 messages Dec 18, 2014 – May 6, 2015

lore

Share & tools

lore

Fu Wei

author

2014-12-18 17:55 UTC #0 lore raw

cover arm64: Add multiboot support (via fdt) for Xen boot

- This multiboot support is built into linux module for aarch64.

- The implementation for Xen is following <Multiboot on ARM Specification>:
http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot
and xen/docs/misc/arm/device-tree/booting.txt in Xen source code.

- The example of this support is <How to boot Xen with GRUB on AArch64 the Foundation FVP model>
https://wiki.linaro.org/LEG/Engineering/Grub2/Xen_booting_on_Foundation_FVP_model_by_GRUB

- This adds support for the Xen Multiboot on ARM specification for arm64, enabling config file portability across the architectures.

- The multiboot command is currently x86-only, so reusing these command names should not conflict with any future additions of ARM support to multiboot2.

- The reason of adding this functionality to the existing "linux" module rather than "multiboot(2)"
(1)multiboot is x86 only
(2)Multiboot is added to "linux" module because it reuses existing code.

- Some changes in original linux module code
Move some #define from grub-core/loader/arm64/linux.c to include/grub/arm64/linux.h Make some shared functions for multiboot.c
Remove "loaded" checking in the grub_cmd_devicetree of linux.c

- Add grub_fdt_set_reg64 macro into fdt.h header file for inserting "reg" properiy, while #address-cells = <0x2> and #size-cells = <0x2>

- Add the introduction of multiboot/module command in docs/grub.texi

This multiboot support will be built in linux module for aarch64, and can not be used alone.

 docs/grub.texi                     |  10 +
 grub-core/Makefile.core.def        |   1 +
 grub-core/loader/arm64/linux.c     |  72 ++---
 grub-core/loader/arm64/multiboot.c | 593 +++++++++++++++++++++++++++++++++++++
 include/grub/arm64/linux.h         |  11 +
 include/grub/arm64/multiboot.h     | 115 +++++++
 include/grub/fdt.h                 |  12 +
 7 files changed, 778 insertions(+), 36 deletions(-)
 create mode 100644 grub-core/loader/arm64/multiboot.c
 create mode 100644 include/grub/arm64/multiboot.h

Signed-off-by Fu Wei <[email protected]>

Reviewed-by Leif Lindholm <[email protected]>

Signature · 1 line

1.8.3.1

Ian Campbell

Tested-by on the v1 series

2015-01-08 16:38 UTC #1 lore raw

Quoted 2 lines · Fu Wei

Signed-off-by Fu Wei <[email protected]>
Reviewed-by Leif Lindholm <[email protected]>

I've tested the code at
git://git.linaro.org/people/fu.wei/grub.git#multiboot_xen_support_upstream_v4.0
which I believe is the same as this posting on an AMD Seattle system with a 40_custom containing:

        menuentry 'Baremetal' {
        	insmod gzio
        	insmod part_msdos
        	insmod ext2
        	set root='hd0,msdos2'
        	search --no-floppy --fs-uuid --set=root d4178d5c-96a8-46ee-a304-0d87baa545cd
        	linux /boot/vmlinuz console=ttyAMA0,115200n8 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
        }
        menuentry 'Xen' {
        	insmod gzio
        	insmod part_msdos
        	insmod ext2
        	set root='hd0,msdos2'
        	search --no-floppy --fs-uuid --set=root d4178d5c-96a8-46ee-a304-0d87baa545cd
        	multiboot /boot/xen no-bootscrub console=dtuart conswitch=x dtuart=/smb/serial@e1010000 noreboot sync_console dom0_mem=256M dom0_max_vcpus=1
        	module /boot/vmlinuz-xen console=hvc0 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
        }

(my system is too confused for 10_linux or 20_linux_xen right now, but I believe this is representative of what they would emit)

The result was that I could boot both Baremetal and Xen via grub. So:

Tested-by Ian Campbell <[email protected]>

I've not looked at the code (although I did review several older iterations), would it be useful to the grub maintainers for me to do so?

Ian.

Fu Wei

author

2015-01-21 14:07 UTC #2 lore raw

Hi everybody,

any suggestion for my patchset?
if these patches look fine, can they be merged?

Any feedback is welcome! :-)
Great thanks !

Quoted 47 lines · Ian Campbell

Quoted 2 lines · Fu Wei
Signed-off-by Fu Wei <[email protected]>
Reviewed-by Leif Lindholm <[email protected]>
I've tested the code at
git://
git.linaro.org/people/fu.wei/grub.git#multiboot_xen_support_upstream_v4.0 which I believe is the same as this posting on an AMD Seattle system with a 40_custom containing:
        menuentry 'Baremetal' {
                insmod gzio
                insmod part_msdos
                insmod ext2
                set root='hd0,msdos2'
                search --no-floppy --fs-uuid --set=root
d4178d5c-96a8-46ee-a304-0d87baa545cd
                linux /boot/vmlinuz console=ttyAMA0,115200n8
earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
        }
        menuentry 'Xen' {
                insmod gzio
                insmod part_msdos
                insmod ext2
                set root='hd0,msdos2'
                search --no-floppy --fs-uuid --set=root
d4178d5c-96a8-46ee-a304-0d87baa545cd
multiboot /boot/xen no-bootscrub console=dtuart
conswitch=x dtuart=/smb/serial@e1010000 noreboot sync_console dom0_mem=256M dom0_max_vcpus=1
module /boot/vmlinuz-xen console=hvc0
earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
        }
(my system is too confused for 10_linux or 20_linux_xen right now, but I believe this is representative of what they would emit)
The result was that I could boot both Baremetal and Xen via grub. So:
Tested-by Ian Campbell <[email protected]>
I've not looked at the code (although I did review several older iterations), would it be useful to the grub maintainers for me to do so?
Ian.

Signature · 10 lines

Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021

Stefano Stabellini

2015-01-26 14:32 UTC #3 lore raw

Ping?

I think it would be great to have multiboot support in grub. As a matter of fact without it grub cannot load xen on arm.

Quoted 54 lines · Fu Wei

Hi everybody,
any suggestion for my patchset?
if these patches look fine, can they be merged?
Any feedback is welcome! :-)
Great thanks !
On 9 January 2015 at 00:38, Ian Campbell <[email protected]> wrote:
On Fri, 2014-12-19 at 01:55 +0800, Fu Wei wrote:
> Signed-off-by: Fu Wei <[email protected]>
> Reviewed-by: Leif Lindholm <[email protected]>
I've tested the code at
git://git.linaro.org/people/fu.wei/grub.git#multiboot_xen_support_upstream_v4.0
which I believe is the same as this posting on an AMD Seattle system with a 40_custom containing:
menuentry 'Baremetal' {
insmod gzio
insmod part_msdos
insmod ext2
set root='hd0,msdos2'
search --no-floppy --fs-uuid --set=root d4178d5c-96a8-46ee-a304-0d87baa545cd linux /boot/vmlinuz console=ttyAMA0,115200n8 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait }
menuentry 'Xen' {
insmod gzio
insmod part_msdos
insmod ext2
set root='hd0,msdos2'
search --no-floppy --fs-uuid --set=root d4178d5c-96a8-46ee-a304-0d87baa545cd multiboot /boot/xen no-bootscrub console=dtuart conswitch=x dtuart=/smb/serial@e1010000 noreboot sync_console dom0_mem=256M dom0_max_vcpus=1
module /boot/vmlinuz-xen console=hvc0 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait }
(my system is too confused for 10_linux or 20_linux_xen right now, but I believe this is representative of what they would emit)
The result was that I could boot both Baremetal and Xen via grub. So:
Tested-by Ian Campbell <[email protected]>
I've not looked at the code (although I did review several older iterations), would it be useful to the grub maintainers for me to do so?
Ian.
--
Best regards,

Quoted 10 lines

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Fu Wei

author

2015-04-10 02:32 UTC #4 lore raw

Hi everybody,
any suggestion for my patchset?
Please let me know if there are some place need to be fixed or improved, if these patches look good to you, can they be merged?

Any feedback or suggestion is welcome! :-)
Great thanks !

Quoted 89 lines · Stefano Stabellini

Ping?
I think it would be great to have multiboot support in grub. As a matter of fact without it grub cannot load xen on arm.
Quoted 8 lines · Fu Wei
Hi everybody,
any suggestion for my patchset?
if these patches look fine, can they be merged?
Any feedback is welcome! :-)
Great thanks !
On 9 January 2015 at 00:38, Ian Campbell <[email protected]>
Quoted 6 lines · wrote:
On Fri, 2014-12-19 at 01:55 +0800, Fu Wei wrote:
> Signed-off-by: Fu Wei <[email protected]>
> Reviewed-by: Leif Lindholm <[email protected]>
I've tested the code at
git://
git.linaro.org/people/fu.wei/grub.git#multiboot_xen_support_upstream_v4.0
Quoted 1 line
which I believe is the same as this posting on an AMD Seattle
system
Quoted 8 lines
      with a 40_custom containing:

              menuentry 'Baremetal' {
                      insmod gzio
                      insmod part_msdos
                      insmod ext2
                      set root='hd0,msdos2'
                      search --no-floppy --fs-uuid --set=root
d4178d5c-96a8-46ee-a304-0d87baa545cd
Quoted 1 line
                      linux /boot/vmlinuz console=ttyAMA0,115200n8
earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
Quoted 7 lines
              }
              menuentry 'Xen' {
                      insmod gzio
                      insmod part_msdos
                      insmod ext2
                      set root='hd0,msdos2'
                      search --no-floppy --fs-uuid --set=root
d4178d5c-96a8-46ee-a304-0d87baa545cd
Quoted 1 line
multiboot /boot/xen no-bootscrub console=dtuart
conswitch=x dtuart=/smb/serial@e1010000 noreboot
Quoted 2 lines
sync_console dom0_mem=256M dom0_max_vcpus=1
module /boot/vmlinuz-xen console=hvc0
earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
Quoted 3 lines
}
(my system is too confused for 10_linux or 20_linux_xen right now,
but I
Quoted 3 lines
believe this is representative of what they would emit)
The result was that I could boot both Baremetal and Xen via grub.
So:
Quoted 5 lines
Tested-by Ian Campbell <[email protected]>
I've not looked at the code (although I did review several older iterations), would it be useful to the grub maintainers for me to
do so?
Quoted 9 lines
Ian.
--
Best regards,
Quoted 10 lines
Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021
_______________________________________________
Linaro-uefi mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/linaro-uefi

Signature · 10 lines

Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Ian Campbell

2015-04-15 11:35 UTC #5 lore raw

Quoted 2 lines · Fu Wei

Hi everybody,
any suggestion for my patchset?

Your CC list contains grub-devel, some other lists and a bunch of individuals who are not actually grub developers, who are the ones I think you actually need to be pinging. Perhaps try addressing some relevant grub developer(s) directly?

Quoted 116 lines

Please let me know if there are some place need to be fixed or improved, if these patches look good to you, can they be merged?
Any feedback or suggestion is welcome! :-)
Great thanks !
On 26 January 2015 at 22:32, Stefano Stabellini
<[email protected]> wrote:
Ping?
I think it would be great to have multiboot support in grub. As a matter of fact without it grub cannot load xen on arm.
On Wed, 21 Jan 2015, Fu Wei wrote:
> Hi everybody,
> any suggestion for my patchset?
> if these patches look fine, can they be merged? >
> Any feedback is welcome! :-)
> Great thanks !
>
> On 9 January 2015 at 00:38, Ian Campbell <[email protected]> wrote:
> On Fri, 2014-12-19 at 01:55 +0800, Fu Wei wrote:
> > Signed-off-by: Fu Wei <[email protected]>
> > Reviewed-by: Leif Lindholm
<[email protected]>
>
> I've tested the code at
>
git://git.linaro.org/people/fu.wei/grub.git#multiboot_xen_support_upstream_v4.0
> which I believe is the same as this posting on an AMD
Seattle system
> with a 40_custom containing:
>
> menuentry 'Baremetal' {
> insmod gzio
> insmod part_msdos
> insmod ext2
> set root='hd0,msdos2'
> search --no-floppy --fs-uuid
--set=root d4178d5c-96a8-46ee-a304-0d87baa545cd
> linux /boot/vmlinuz
console=ttyAMA0,115200n8 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
> }
> menuentry 'Xen' {
> insmod gzio
> insmod part_msdos
> insmod ext2
> set root='hd0,msdos2'
> search --no-floppy --fs-uuid
--set=root d4178d5c-96a8-46ee-a304-0d87baa545cd
> multiboot /boot/xen no-bootscrub
console=dtuart conswitch=x dtuart=/smb/serial@e1010000 noreboot
> sync_console dom0_mem=256M dom0_max_vcpus=1
> module /boot/vmlinuz-xen console=hvc0
earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
> }
>
> (my system is too confused for 10_linux or
20_linux_xen right now, but I
> believe this is representative of what they would
emit)
>
> The result was that I could boot both Baremetal and
Xen via grub. So:
>
> Tested-by: Ian Campbell <[email protected]>
>
> I've not looked at the code (although I did review
several older
> iterations), would it be useful to the grub
maintainers for me to do so?
>
> Ian.
>
>
>
>
> --
> Best regards,
>
> Fu Wei
> Software Engineer
> Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch > Ph: +86 21 61221326(direct)
> Ph: +86 186 2020 4684 (mobile)
> Room 1512, Regus One Corporate Avenue,Level 15, > One Corporate Avenue,222 Hubin Road,Huangpu District, > Shanghai,China 200021
>
>
_______________________________________________
Linaro-uefi mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/linaro-uefi
Signature · 10 lines
Best regards, 

Fu Wei 
Software Engineer 
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch 
Ph: +86 21 61221326(direct) 
Ph: +86 186 2020 4684 (mobile) 
Room 1512, Regus One Corporate Avenue,Level 15, 
One Corporate Avenue,222 Hubin Road,Huangpu District, 
Shanghai,China 200021 

Andrei Borzenkov

2015-05-03 18:55 UTC #6 lore raw

In reply to Fu Wei

В Fri, 10 Apr 2015 10:32:15 +0800
Fu Wei <[email protected]> пишет:

Quoted 8 lines

Hi everybody,
any suggestion for my patchset?
Please let me know if there are some place need to be fixed or improved, if these patches look good to you, can they be merged?
Any feedback or suggestion is welcome! :-)
Great thanks !

Sorry for delay. grub-devel is not overcrowded right now; I started to review them but got distracted. I'll try to find time.

Quoted 86 lines

Quoted 83 lines · Stefano Stabellini
Ping?
I think it would be great to have multiboot support in grub. As a matter of fact without it grub cannot load xen on arm.
Quoted 8 lines · Fu Wei
Hi everybody,
any suggestion for my patchset?
if these patches look fine, can they be merged?
Any feedback is welcome! :-)
Great thanks !
On 9 January 2015 at 00:38, Ian Campbell <[email protected]>
Quoted 6 lines · wrote:
On Fri, 2014-12-19 at 01:55 +0800, Fu Wei wrote:
> Signed-off-by: Fu Wei <[email protected]>
> Reviewed-by: Leif Lindholm <[email protected]>
I've tested the code at
git://
git.linaro.org/people/fu.wei/grub.git#multiboot_xen_support_upstream_v4.0
Quoted 1 line
which I believe is the same as this posting on an AMD Seattle
system
Quoted 8 lines
      with a 40_custom containing:

              menuentry 'Baremetal' {
                      insmod gzio
                      insmod part_msdos
                      insmod ext2
                      set root='hd0,msdos2'
                      search --no-floppy --fs-uuid --set=root
d4178d5c-96a8-46ee-a304-0d87baa545cd
Quoted 1 line
                      linux /boot/vmlinuz console=ttyAMA0,115200n8
earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
Quoted 7 lines
              }
              menuentry 'Xen' {
                      insmod gzio
                      insmod part_msdos
                      insmod ext2
                      set root='hd0,msdos2'
                      search --no-floppy --fs-uuid --set=root
d4178d5c-96a8-46ee-a304-0d87baa545cd
Quoted 1 line
multiboot /boot/xen no-bootscrub console=dtuart
conswitch=x dtuart=/smb/serial@e1010000 noreboot
Quoted 2 lines
sync_console dom0_mem=256M dom0_max_vcpus=1
module /boot/vmlinuz-xen console=hvc0
earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
Quoted 3 lines
}
(my system is too confused for 10_linux or 20_linux_xen right now,
but I
Quoted 3 lines
believe this is representative of what they would emit)
The result was that I could boot both Baremetal and Xen via grub.
So:
Quoted 5 lines
Tested-by Ian Campbell <[email protected]>
I've not looked at the code (although I did review several older iterations), would it be useful to the grub maintainers for me to
do so?
Quoted 19 lines
Ian.
--
Best regards,
Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021

Quoted 8 lines

Quoted 6 lines
_______________________________________________
Linaro-uefi mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/linaro-uefi

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Fu Wei

author

2015-05-06 14:53 UTC #7 lore raw

Hi Andrie,

Great thanks for your reply!
Please let me know your suggestion for my patch, then I can improve it ASAP!

:-)
Thanks!

Quoted 117 lines · Andrei Borzenkov

В Fri, 10 Apr 2015 10:32:15 +0800
Fu Wei <[email protected]> пишет:
Quoted 3 lines
Hi everybody,
any suggestion for my patchset?
Please let me know if there are some place need to be fixed or improved,
if
Quoted 5 lines
these patches look good to you, can they be merged?
Any feedback or suggestion is welcome! :-)
Great thanks !
Sorry for delay. grub-devel is not overcrowded right now; I started to review them but got distracted. I'll try to find time.
Quoted 18 lines
Quoted 15 lines · Stefano Stabellini
Ping?
I think it would be great to have multiboot support in grub. As a matter of fact without it grub cannot load xen on arm.
Quoted 8 lines · Fu Wei
Hi everybody,
any suggestion for my patchset?
if these patches look fine, can they be merged?
Any feedback is welcome! :-)
Great thanks !
On 9 January 2015 at 00:38, Ian Campbell <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 6 lines · wrote:
On Fri, 2014-12-19 at 01:55 +0800, Fu Wei wrote:
> Signed-off-by: Fu Wei <[email protected]>
> Reviewed-by: Leif Lindholm <[email protected]>
I've tested the code at
git://
git.linaro.org/people/fu.wei/grub.git#multiboot_xen_support_upstream_v4.0
Quoted 21 lines
Quoted 21 lines
Quoted 1 line
which I believe is the same as this posting on an AMD Seattle
system
Quoted 8 lines
      with a 40_custom containing:

              menuentry 'Baremetal' {
                      insmod gzio
                      insmod part_msdos
                      insmod ext2
                      set root='hd0,msdos2'
                      search --no-floppy --fs-uuid --set=root
d4178d5c-96a8-46ee-a304-0d87baa545cd
Quoted 1 line
                      linux /boot/vmlinuz console=ttyAMA0,115200n8
earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
Quoted 7 lines
              }
              menuentry 'Xen' {
                      insmod gzio
                      insmod part_msdos
                      insmod ext2
                      set root='hd0,msdos2'
                      search --no-floppy --fs-uuid --set=root
d4178d5c-96a8-46ee-a304-0d87baa545cd
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
multiboot /boot/xen no-bootscrub console=dtuart
conswitch=x dtuart=/smb/serial@e1010000 noreboot
Quoted 2 lines
sync_console dom0_mem=256M dom0_max_vcpus=1
module /boot/vmlinuz-xen console=hvc0
earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait
Quoted 3 lines
}
(my system is too confused for 10_linux or 20_linux_xen right
now,
Quoted 4 lines
Quoted 4 lines
but I
Quoted 3 lines
believe this is representative of what they would emit)
The result was that I could boot both Baremetal and Xen via
grub.
Quoted 5 lines
Quoted 5 lines
So:
Quoted 4 lines
Tested-by Ian Campbell <[email protected]>
I've not looked at the code (although I did review several
older
Quoted 1 line
Quoted 1 line
Quoted 1 line
iterations), would it be useful to the grub maintainers for me
to
Quoted 29 lines
Quoted 27 lines
do so?
Quoted 9 lines
Ian.
--
Best regards,
Quoted 10 lines
Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021
_______________________________________________
Linaro-uefi mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/linaro-uefi

Signature · 10 lines

Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Stefano Stabellini

2015-01-26 14:34 UTC #8 lore raw

In reply to Fu Wei

Ping?

I think it would be great to have multiboot support in grub. As a matter of fact without it grub cannot load xen on arm.

Quoted 54 lines · Fu Wei

Hi everybody,
any suggestion for my patchset?
if these patches look fine, can they be merged?
Any feedback is welcome! :-)
Great thanks !
On 9 January 2015 at 00:38, Ian Campbell <[email protected]> wrote:
On Fri, 2014-12-19 at 01:55 +0800, Fu Wei wrote:
> Signed-off-by: Fu Wei <[email protected]>
> Reviewed-by: Leif Lindholm <[email protected]>
I've tested the code at
git://git.linaro.org/people/fu.wei/grub.git#multiboot_xen_support_upstream_v4.0
which I believe is the same as this posting on an AMD Seattle system with a 40_custom containing:
menuentry 'Baremetal' {
insmod gzio
insmod part_msdos
insmod ext2
set root='hd0,msdos2'
search --no-floppy --fs-uuid --set=root d4178d5c-96a8-46ee-a304-0d87baa545cd linux /boot/vmlinuz console=ttyAMA0,115200n8 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait }
menuentry 'Xen' {
insmod gzio
insmod part_msdos
insmod ext2
set root='hd0,msdos2'
search --no-floppy --fs-uuid --set=root d4178d5c-96a8-46ee-a304-0d87baa545cd multiboot /boot/xen no-bootscrub console=dtuart conswitch=x dtuart=/smb/serial@e1010000 noreboot sync_console dom0_mem=256M dom0_max_vcpus=1
module /boot/vmlinuz-xen console=hvc0 earlycon=pl011,0xe1010000 root=/dev/sda2 rootwait }
(my system is too confused for 10_linux or 20_linux_xen right now, but I believe this is representative of what they would emit)
The result was that I could boot both Baremetal and Xen via grub. So:
Tested-by Ian Campbell <[email protected]>
I've not looked at the code (although I did review several older iterations), would it be useful to the grub maintainers for me to do so?
Ian.
--
Best regards,

Quoted 10 lines

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel