Skip to contentSkip to conversation

staging: adm8211: fix checkpatch error for trailing statements on next line

PATCH Superseded Okash Khawaja 2 participants 4 messages May 3, 2015 – May 5, 2015

Subsystems (3)
Networking Network drivers Networking drivers (wireless)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Okash Khawaja

author
#0 lore raw

PATCH 1/1 staging: adm8211: fix checkpatch error for trailing statements on next line

This patch fixes the checkpatch.pl error:

ERROR: trailing statements should be on next line

More specifically, the fix has been applied to the four occurances of the error listed below.

ERROR: trailing statements should be on next line
#1101: FILE: drivers/net/wireless/adm8211.c:1101:
+ case 0x8: reg |= (0x1 << 14);

ERROR: trailing statements should be on next line
#1103: FILE: drivers/net/wireless/adm8211.c:1103:
+ case 0x16: reg |= (0x2 << 14);

ERROR: trailing statements should be on next line
#1105: FILE: drivers/net/wireless/adm8211.c:1105:
+ case 0x32: reg |= (0x3 << 14);

ERROR: trailing statements should be on next line
#1107: FILE: drivers/net/wireless/adm8211.c:1107:
+ default: reg |= (0x0 << 14);

Signed-off-by Okash Khawaja <[email protected]>
---
 drivers/net/wireless/adm8211.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)
drivers/net/wireless/adm8211.c +12 -8
index f07a618..79e4e5f 100644
@@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
 		pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline);
 
 		switch (cline) {
-		case  0x8: reg |= (0x1 << 14);
-			   break;
-		case 0x16: reg |= (0x2 << 14);
-			   break;
-		case 0x32: reg |= (0x3 << 14);
-			   break;
-		  default: reg |= (0x0 << 14);
-			   break;
+		case  0x8:
+			reg |= (0x1 << 14);
+			break;
+		case 0x16:
+			reg |= (0x2 << 14);
+			break;
+		case 0x32:
+			reg |= (0x3 << 14);
+			break;
+		  default:
+			reg |= (0x0 << 14);
+			break;
 		}
 	}
Signature · 5 lines
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 18 lines · Okash Khawaja

This patch fixes the checkpatch.pl error:

ERROR: trailing statements should be on next line

More specifically, the fix has been applied to the four occurances of the error listed below.

ERROR: trailing statements should be on next line
#1101: FILE: drivers/net/wireless/adm8211.c:1101:
+ case 0x8: reg |= (0x1 << 14);

ERROR: trailing statements should be on next line
#1103: FILE: drivers/net/wireless/adm8211.c:1103:
+ case 0x16: reg |= (0x2 << 14);

ERROR: trailing statements should be on next line
#1105: FILE: drivers/net/wireless/adm8211.c:1105:
+ case 0x32: reg |= (0x3 << 14);

Quoted 8 lines

ERROR: trailing statements should be on next line
#1107: FILE: drivers/net/wireless/adm8211.c:1107:
+ default: reg |= (0x0 << 14);

Signed-off-by Okash Khawaja <[email protected]>
---
 drivers/net/wireless/adm8211.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

The patch has incorrectly "staging:" prefix in the title, please fix that. "adm8211:" is enough, you don't need anything for drivers in drivers/net/wireless.

Signature · 1 line
Kalle Valo
author
#2 lore raw

Re: [PATCH v2] adm8211: fix checkpatch error for trailing statements on next line

Quoted 24 lines · Kalle Valo
Quoted 22 lines · Okash Khawaja

This patch fixes the checkpatch.pl error:

ERROR: trailing statements should be on next line

More specifically, the fix has been applied to the four occurances of the error listed below.

ERROR: trailing statements should be on next line
#1101: FILE: drivers/net/wireless/adm8211.c:1101:
+ case 0x8: reg |= (0x1 << 14);

ERROR: trailing statements should be on next line
#1103: FILE: drivers/net/wireless/adm8211.c:1103:
+ case 0x16: reg |= (0x2 << 14);

ERROR: trailing statements should be on next line
#1105: FILE: drivers/net/wireless/adm8211.c:1105:
+ case 0x32: reg |= (0x3 << 14);

ERROR: trailing statements should be on next line
#1107: FILE: drivers/net/wireless/adm8211.c:1107:
+ default: reg |= (0x0 << 14);

Quoted 11 lines
Quoted 4 lines
Signed-off-by Okash Khawaja <[email protected]>
---
 drivers/net/wireless/adm8211.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

The patch has incorrectly "staging:" prefix in the title, please fix that. "adm8211:" is enough, you don't need anything for drivers in drivers/net/wireless.

Signature · 1 line
Kalle Valo

Thanks Kalle for clarifying. I have removed "staging:" prefix and pasted the patch below.

Signed-off-by Okash Khawaja <[email protected]>
---
 drivers/net/wireless/adm8211.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)
drivers/net/wireless/adm8211.c +12 -8
index f07a618..79e4e5f 100644
@@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
                pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline);
 
                switch (cline) {
-               case  0x8: reg |= (0x1 << 14);
-                          break;
-               case 0x16: reg |= (0x2 << 14);
-                          break;
-               case 0x32: reg |= (0x3 << 14);
-                          break;
-                 default: reg |= (0x0 << 14);
-                          break;
+               case  0x8:
+                       reg |= (0x1 << 14);
+                       break;
+               case 0x16:
+                       reg |= (0x2 << 14);
+                       break;
+               case 0x32:
+                       reg |= (0x3 << 14);
+                       break;
+                 default:
+                       reg |= (0x0 << 14);
+                       break;
                }
        }
Signature · 6 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw

Re: [PATCH v2] adm8211: fix checkpatch error for trailing statements on next line

Quoted 34 lines · Okash Khawaja
Quoted 33 lines · Kalle Valo
Quoted 18 lines · Okash Khawaja

This patch fixes the checkpatch.pl error:

ERROR: trailing statements should be on next line

More specifically, the fix has been applied to the four occurances of the error listed below.

ERROR: trailing statements should be on next line
#1101: FILE: drivers/net/wireless/adm8211.c:1101:
+ case 0x8: reg |= (0x1 << 14);

ERROR: trailing statements should be on next line
#1103: FILE: drivers/net/wireless/adm8211.c:1103:
+ case 0x16: reg |= (0x2 << 14);

ERROR: trailing statements should be on next line
#1105: FILE: drivers/net/wireless/adm8211.c:1105:
+ case 0x32: reg |= (0x3 << 14);

Quoted 8 lines

ERROR: trailing statements should be on next line
#1107: FILE: drivers/net/wireless/adm8211.c:1107:
+ default: reg |= (0x0 << 14);

Signed-off-by Okash Khawaja <[email protected]>
---
 drivers/net/wireless/adm8211.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

The patch has incorrectly "staging:" prefix in the title, please fix that. "adm8211:" is enough, you don't need anything for drivers in drivers/net/wireless.

Quoted 6 lines
Quoted 2 lines
Signature · 1 line
Kalle Valo

Thanks Kalle for clarifying. I have removed "staging:" prefix and pasted the patch below.

Signed-off-by Okash Khawaja <[email protected]>

I cannot apply the mail directly as you added the old discussion to the commit log. Please just resend the whole patch with clean commit log.

Signature · 1 line
Kalle Valo