Skip to contentSkip to conversation

video: backlight: da9052: Constify platform_device_id

PATCH Applied Krzysztof Kozlowski 3 participants 12 messages May 1, 2015 – Jun 3, 2015

Subsystems (6)
Arm i.MX and Layerscape Framebuffer layer Backlight class/subsystem Dialog semiconductor drivers +2 more subsystems
lore
Share & tools
lore

Krzysztof Kozlowski

author
#0 lore raw

PATCH 1/4 video: backlight: da9052: Constify platform_device_id

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/backlight/da9052_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/backlight/da9052_bl.c +1 -1
index b1943e7735a1..fd2be417aa64 100644
@@ -152,7 +152,7 @@ static int da9052_backlight_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static struct platform_device_id da9052_wled_ids[] = {
+static const struct platform_device_id da9052_wled_ids[] = {
 	{
 		.name		= "da9052-wled1",
 		.driver_data	= DA9052_TYPE_WLED1,
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 2/4 video: fbdev: imxfb: Constify platform_device_id

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/imxfb.c +1 -1
index 84d1d29e532c..cee88603efc9 100644
@@ -170,7 +170,7 @@ struct imxfb_info {
 	struct regulator	*lcd_pwr;
 };
 
-static struct platform_device_id imxfb_devtype[] = {
+static const struct platform_device_id imxfb_devtype[] = {
 	{
 		.name = "imx1-fb",
 		.driver_data = IMX1_FB,
Signature · 1 line
2.1.4
Applied
#2 lore raw

Re: [PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

Quoted 7 lines · Krzysztof Kozlowski

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Quoted 13 lines
drivers/video/fbdev/imxfb.c +1 -1
index 84d1d29e532c..cee88603efc9 100644
@@ -170,7 +170,7 @@ struct imxfb_info {
 	struct regulator	*lcd_pwr;
 };
 
-static struct platform_device_id imxfb_devtype[] = {
+static const struct platform_device_id imxfb_devtype[] = {
 	{
 		.name = "imx1-fb",
 		.driver_data = IMX1_FB,
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#3 lore raw

Re: [PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

Hi Lee,

Quoted 11 lines · Lee Jones
Quoted 7 lines · Krzysztof Kozlowski

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

You applied the fbdev changes in this series also, not only the backlight changes?

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150603/c312ae26/attachment.sig>

#4 lore raw

Re: [PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

Quoted 13 lines · Tomi Valkeinen

Hi Lee,

Quoted 10 lines · Lee Jones
Quoted 7 lines · Krzysztof Kozlowski

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines
Quoted 1 line

Applied, thanks.

You applied the fbdev changes in this series also, not only the backlight changes?

Ah, yes I did. I assumed they were all due for Backlight.

Would you like me to un-apply the non-Backlight patches?

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#5 lore raw

Re: [PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

Quoted 15 lines · Lee Jones
Quoted 13 lines · Tomi Valkeinen

Hi Lee,

Quoted 10 lines · Lee Jones
Quoted 7 lines · Krzysztof Kozlowski

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Applied, thanks.

You applied the fbdev changes in this series also, not only the backlight changes?

Ah, yes I did. I assumed they were all due for Backlight.

Would you like me to un-apply the non-Backlight patches?

If you can easily remove them, yes.

But chances for conflict are quite minimal, so if you already have a pile of commits on top of these, it's fine if they go via backlight tree.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150603/4f8a3b5b/attachment.sig>

#6 lore raw

Re: [PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

Quoted 21 lines · Tomi Valkeinen
Quoted 20 lines · Lee Jones
Quoted 17 lines · Tomi Valkeinen

Hi Lee,

Quoted 11 lines · Lee Jones
Quoted 7 lines · Krzysztof Kozlowski

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

You applied the fbdev changes in this series also, not only the backlight changes?

Quoted 8 lines
Quoted 3 lines

Ah, yes I did. I assumed they were all due for Backlight.

Would you like me to un-apply the non-Backlight patches?

If you can easily remove them, yes.

But chances for conflict are quite minimal, so if you already have a pile of commits on top of these, it's fine if they go via backlight tree.

I can easily remove them, no problem.

Consider them unapplied.

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#7 lore raw

PATCH 3/4 video: fbdev: mxsfb: Constify platform_device_id

In reply to Krzysztof Kozlowski

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/fbdev/mxsfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/mxsfb.c +1 -1
index f8ac4a452f26..497971c82bb1 100644
@@ -814,7 +814,7 @@ static void mxsfb_free_videomem(struct mxsfb_info *host)
 	free_pages_exact(fb_info->screen_base, fb_info->fix.smem_len);
 }
 
-static struct platform_device_id mxsfb_devtype[] = {
+static const struct platform_device_id mxsfb_devtype[] = {
 	{
 		.name = "imx23-fb",
 		.driver_data = MXSFB_V3,
Signature · 1 line
2.1.4
Applied
#8 lore raw

Re: [PATCH 3/4] video: fbdev: mxsfb: Constify platform_device_id

Quoted 7 lines · Krzysztof Kozlowski

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/fbdev/mxsfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Quoted 13 lines
drivers/video/fbdev/mxsfb.c +1 -1
index f8ac4a452f26..497971c82bb1 100644
@@ -814,7 +814,7 @@ static void mxsfb_free_videomem(struct mxsfb_info *host)
 	free_pages_exact(fb_info->screen_base, fb_info->fix.smem_len);
 }
 
-static struct platform_device_id mxsfb_devtype[] = {
+static const struct platform_device_id mxsfb_devtype[] = {
 	{
 		.name = "imx23-fb",
 		.driver_data = MXSFB_V3,
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#9 lore raw

PATCH 4/4 video: fbdev: s3c-fb: Constify platform_device_id

In reply to Krzysztof Kozlowski

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/fbdev/s3c-fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/s3c-fb.c +1 -1
index 7e3a05fc47aa..f72dd12456f9 100644
@@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = {
 	},
 };
 
-static struct platform_device_id s3c_fb_driver_ids[] = {
+static const struct platform_device_id s3c_fb_driver_ids[] = {
 	{
 		.name		= "s3c-fb",
 		.driver_data	= (unsigned long)&s3c_fb_data_64xx,
Signature · 1 line
2.1.4
Applied
#10 lore raw

Re: [PATCH 4/4] video: fbdev: s3c-fb: Constify platform_device_id

Quoted 7 lines · Krzysztof Kozlowski

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/fbdev/s3c-fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Quoted 13 lines
drivers/video/fbdev/s3c-fb.c +1 -1
index 7e3a05fc47aa..f72dd12456f9 100644
@@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = {
 	},
 };
 
-static struct platform_device_id s3c_fb_driver_ids[] = {
+static const struct platform_device_id s3c_fb_driver_ids[] = {
 	{
 		.name		= "s3c-fb",
 		.driver_data	= (unsigned long)&s3c_fb_data_64xx,
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Applied
#11 lore raw
In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski

The platform_device_id is not modified by the driver and core uses it as const.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/video/backlight/da9052_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Quoted 13 lines
drivers/video/backlight/da9052_bl.c +1 -1
index b1943e7735a1..fd2be417aa64 100644
@@ -152,7 +152,7 @@ static int da9052_backlight_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static struct platform_device_id da9052_wled_ids[] = {
+static const struct platform_device_id da9052_wled_ids[] = {
 	{
 		.name		= "da9052-wled1",
 		.driver_data	= DA9052_TYPE_WLED1,
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog