Skip to contentSkip to conversation

drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h: No such file or directory

PATCH Varun Sethi 4 participants 10 messages Mar 25, 2015 – May 6, 2015 12 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 201503240804.8vcZXNOY%[email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 63 lines

-----Original Message-----
From: Emil Medve [mailto:[email protected]]
Sent: Tuesday, March 24, 2015 2:10 PM
To: [email protected]; Sethi Varun-B16395
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Hello Varun,

Quoted 1 line · kbuild test robot

tree: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git

ppc/pamu

Quoted 2 lines
head:   f2fafdd954d743a0e68e5cd76dbef2f2454deefa
commit: f2fafdd954d743a0e68e5cd76dbef2f2454deefa [1/1] iommu/fsl:

PAMU

Quoted 4 lines

is also present on 64-bit SoC(s)
config: microblaze-allyesconfig (attached as .config) reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-

tests.git/plain/sbin/make.cross -O ~/bin/make.cross

Quoted 10 lines

chmod +x ~/bin/make.cross
git checkout f2fafdd954d743a0e68e5cd76dbef2f2454deefa

  # save the attached .config to linux build tree
  make.cross ARCH=microblaze

All error/warnings:

In file included from drivers/iommu/fsl_pamu.c:21:0:

Quoted 2 lines
Quoted 2 lines

drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h:
No such file or directory

Quoted 7 lines
    #include <asm/fsl_pamu_stash.h>
                                   ^

compilation terminated.

vim +24 drivers/iommu/fsl_pamu.h

695093e3 Varun Sethi 2013-07-15 8 * MERCHANTABILITY or FITNESS FOR

A PARTICULAR PURPOSE. See the

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 9 * GNU General Public License for

more details.

Quoted 2 lines
695093e3 Varun Sethi 2013-07-15  10   *
695093e3 Varun Sethi 2013-07-15  11   * You should have received a copy of

the GNU General Public License

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 12 * along with this program; if not,

write to the Free Software

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 13 * Foundation, 51 Franklin Street, Fifth

Floor, Boston, MA 02110-1301, USA.

Quoted 2 lines
695093e3 Varun Sethi 2013-07-15  14   *
695093e3 Varun Sethi 2013-07-15  15   * Copyright (C) 2013 Freescale

Semiconductor, Inc.

Quoted 9 lines
695093e3 Varun Sethi 2013-07-15  16   *
695093e3 Varun Sethi 2013-07-15  17   */
695093e3 Varun Sethi 2013-07-15  18
695093e3 Varun Sethi 2013-07-15  19  #ifndef __FSL_PAMU_H
695093e3 Varun Sethi 2013-07-15  20  #define __FSL_PAMU_H
695093e3 Varun Sethi 2013-07-15  21
cd70d465 Emil Medve  2015-01-28  22  #include <linux/iommu.h>
cd70d465 Emil Medve  2015-01-28  23

695093e3 Varun Sethi 2013-07-15 @24 #include <asm/fsl_pamu_stash.h>

Quoted 4 lines

The patch just triggered the build and for some reason these folks are building the driver on non-e500mc arches/defconfigs

Hmm.... I believe PAMU driver got included due to the COMPILE_TEST dependency. This is an issue, if we add the COMPILE_TEST dependency, then we can't include architecture specific include files?

-Varun

A message that is not in the archive (sent off-list or not yet received): BN3PR0301MB12195D8782612E67CDE2BFD9EA0B0-CEkquS/Gb81uuip9JPHoc5wN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/[email protected]

#5 lore raw

Hello Varun,

Quoted 61 lines · On 03/25/2015 12:46 AM, Sethi Varun-B16395 wrote:
Quoted 61 lines

-----Original Message-----
From: Emil Medve [mailto:[email protected]]
Sent: Tuesday, March 24, 2015 2:10 PM
To: [email protected]; Sethi Varun-B16395
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Hello Varun,

Quoted 1 line · kbuild test robot

tree: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git

ppc/pamu

Quoted 2 lines
head:   f2fafdd954d743a0e68e5cd76dbef2f2454deefa
commit: f2fafdd954d743a0e68e5cd76dbef2f2454deefa [1/1] iommu/fsl:

PAMU

Quoted 4 lines

is also present on 64-bit SoC(s)
config: microblaze-allyesconfig (attached as .config) reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-

tests.git/plain/sbin/make.cross -O ~/bin/make.cross

Quoted 10 lines

chmod +x ~/bin/make.cross
git checkout f2fafdd954d743a0e68e5cd76dbef2f2454deefa

  # save the attached .config to linux build tree
  make.cross ARCH=microblaze

All error/warnings:

In file included from drivers/iommu/fsl_pamu.c:21:0:

Quoted 2 lines
Quoted 2 lines

drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h:
No such file or directory

Quoted 7 lines
    #include <asm/fsl_pamu_stash.h>
                                   ^

compilation terminated.

vim +24 drivers/iommu/fsl_pamu.h

695093e3 Varun Sethi 2013-07-15 8 * MERCHANTABILITY or FITNESS FOR

A PARTICULAR PURPOSE. See the

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 9 * GNU General Public License for

more details.

Quoted 2 lines
695093e3 Varun Sethi 2013-07-15  10   *
695093e3 Varun Sethi 2013-07-15  11   * You should have received a copy of

the GNU General Public License

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 12 * along with this program; if not,

write to the Free Software

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 13 * Foundation, 51 Franklin Street, Fifth

Floor, Boston, MA 02110-1301, USA.

Quoted 2 lines
695093e3 Varun Sethi 2013-07-15  14   *
695093e3 Varun Sethi 2013-07-15  15   * Copyright (C) 2013 Freescale

Semiconductor, Inc.

Quoted 9 lines
695093e3 Varun Sethi 2013-07-15  16   *
695093e3 Varun Sethi 2013-07-15  17   */
695093e3 Varun Sethi 2013-07-15  18
695093e3 Varun Sethi 2013-07-15  19  #ifndef __FSL_PAMU_H
695093e3 Varun Sethi 2013-07-15  20  #define __FSL_PAMU_H
695093e3 Varun Sethi 2013-07-15  21
cd70d465 Emil Medve  2015-01-28  22  #include <linux/iommu.h>
cd70d465 Emil Medve  2015-01-28  23

695093e3 Varun Sethi 2013-07-15 @24 #include <asm/fsl_pamu_stash.h>

Quoted 6 lines
Quoted 3 lines

The patch just triggered the build and for some reason these folks are building the driver on non-e500mc arches/defconfigs

Hmm.... I believe PAMU driver got included due to the COMPILE_TEST dependency. This is an issue, if we add the COMPILE_TEST dependency, then we can't include architecture specific include files?

What in fsl_pamu_stash.h is "even more" arch/platform specific then the content of drivers/iommu/fsl_pamu*?

Cheers,

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw

Hi Emil,

Quoted 81 lines

-----Original Message-----
From: Emil Medve [mailto:[email protected]]
Sent: Wednesday, March 25, 2015 11:41 AM
To: Sethi Varun-B16395; [email protected]; [email protected]
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Hello Varun,

Quoted 32 lines · On 03/25/2015 12:46 AM, Sethi Varun-B16395 wrote:
Quoted 32 lines

-----Original Message-----
From: Emil Medve [mailto:[email protected]]
Sent: Tuesday, March 24, 2015 2:10 PM
To: [email protected]; Sethi Varun-B16395
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32:
fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Hello Varun,

Quoted 1 line · kbuild test robot

tree: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git

ppc/pamu

Quoted 2 lines
head:   f2fafdd954d743a0e68e5cd76dbef2f2454deefa
commit: f2fafdd954d743a0e68e5cd76dbef2f2454deefa [1/1] iommu/fsl:

PAMU

Quoted 4 lines

is also present on 64-bit SoC(s)
config: microblaze-allyesconfig (attached as .config) reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-

tests.git/plain/sbin/make.cross -O ~/bin/make.cross

Quoted 10 lines

chmod +x ~/bin/make.cross
git checkout f2fafdd954d743a0e68e5cd76dbef2f2454deefa

  # save the attached .config to linux build tree
  make.cross ARCH=microblaze

All error/warnings:

In file included from drivers/iommu/fsl_pamu.c:21:0:

Quoted 2 lines
Quoted 2 lines

drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h:
No such file or directory

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
    #include <asm/fsl_pamu_stash.h>
                                   ^

compilation terminated.

vim +24 drivers/iommu/fsl_pamu.h

695093e3 Varun Sethi 2013-07-15 8 * MERCHANTABILITY or FITNESS

FOR

Quoted 5 lines
Quoted 5 lines

A PARTICULAR PURPOSE. See the

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 9 * GNU General Public License for

more details.

Quoted 2 lines
695093e3 Varun Sethi 2013-07-15  10   *
695093e3 Varun Sethi 2013-07-15  11   * You should have received a copy

of

Quoted 4 lines
Quoted 4 lines

the GNU General Public License

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 12 * along with this program; if not,

write to the Free Software

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 13 * Foundation, 51 Franklin Street,

Fifth

Quoted 4 lines
Quoted 4 lines

Floor, Boston, MA 02110-1301, USA.

Quoted 2 lines
695093e3 Varun Sethi 2013-07-15  14   *
695093e3 Varun Sethi 2013-07-15  15   * Copyright (C) 2013 Freescale

Semiconductor, Inc.

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
695093e3 Varun Sethi 2013-07-15  16   *
695093e3 Varun Sethi 2013-07-15  17   */
695093e3 Varun Sethi 2013-07-15  18
695093e3 Varun Sethi 2013-07-15  19  #ifndef __FSL_PAMU_H
695093e3 Varun Sethi 2013-07-15  20  #define __FSL_PAMU_H
695093e3 Varun Sethi 2013-07-15  21
cd70d465 Emil Medve  2015-01-28  22  #include <linux/iommu.h>
cd70d465 Emil Medve  2015-01-28  23

695093e3 Varun Sethi 2013-07-15 @24 #include

<asm/fsl_pamu_stash.h>

Quoted 4 lines
Quoted 4 lines

The patch just triggered the build and for some reason these folks are building the driver on non-e500mc arches/defconfigs

Quoted 7 lines
Quoted 3 lines

Hmm.... I believe PAMU driver got included due to the COMPILE_TEST dependency. This is an issue, if we add the COMPILE_TEST dependency, then we can't include architecture specific include files?

What in fsl_pamu_stash.h is "even more" arch/platform specific then the content of drivers/iommu/fsl_pamu*?

This was discussed during early PAMU driver reviews. Joerg's idea was that PAMU would specific to the Power architecture platform, so we should place the include file in the arch specific directory (originally I had placed it under include/linux).

-Varun

A message that is not in the archive (sent off-list or not yet received): BN3PR0301MB12193C6929AE8CF767B8A78AEA0B0-CEkquS/Gb81uuip9JPHoc5wN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/[email protected]

#9 lore raw

Hello Varun,

Quoted 87 lines · On 03/25/2015 01:25 AM, Sethi Varun-B16395 wrote:

Hi Emil,

Quoted 85 lines

-----Original Message-----
From: Emil Medve [mailto:[email protected]]
Sent: Wednesday, March 25, 2015 11:41 AM
To: Sethi Varun-B16395; [email protected]; [email protected]
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Hello Varun,

Quoted 32 lines · On 03/25/2015 12:46 AM, Sethi Varun-B16395 wrote:
Quoted 32 lines

-----Original Message-----
From: Emil Medve [mailto:[email protected]]
Sent: Tuesday, March 24, 2015 2:10 PM
To: [email protected]; Sethi Varun-B16395
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32:
fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Hello Varun,

Quoted 1 line · kbuild test robot

tree: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git

ppc/pamu

Quoted 2 lines
head:   f2fafdd954d743a0e68e5cd76dbef2f2454deefa
commit: f2fafdd954d743a0e68e5cd76dbef2f2454deefa [1/1] iommu/fsl:

PAMU

Quoted 4 lines

is also present on 64-bit SoC(s)
config: microblaze-allyesconfig (attached as .config) reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-

tests.git/plain/sbin/make.cross -O ~/bin/make.cross

Quoted 10 lines

chmod +x ~/bin/make.cross
git checkout f2fafdd954d743a0e68e5cd76dbef2f2454deefa

  # save the attached .config to linux build tree
  make.cross ARCH=microblaze

All error/warnings:

In file included from drivers/iommu/fsl_pamu.c:21:0:

Quoted 2 lines
Quoted 2 lines

drivers/iommu/fsl_pamu.h:24:32: fatal error: asm/fsl_pamu_stash.h:
No such file or directory

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
    #include <asm/fsl_pamu_stash.h>
                                   ^

compilation terminated.

vim +24 drivers/iommu/fsl_pamu.h

695093e3 Varun Sethi 2013-07-15 8 * MERCHANTABILITY or FITNESS

FOR

Quoted 5 lines
Quoted 5 lines

A PARTICULAR PURPOSE. See the

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 9 * GNU General Public License for

more details.

Quoted 2 lines
695093e3 Varun Sethi 2013-07-15  10   *
695093e3 Varun Sethi 2013-07-15  11   * You should have received a copy

of

Quoted 4 lines
Quoted 4 lines

the GNU General Public License

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 12 * along with this program; if not,

write to the Free Software

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 13 * Foundation, 51 Franklin Street,

Fifth

Quoted 4 lines
Quoted 4 lines

Floor, Boston, MA 02110-1301, USA.

Quoted 2 lines
695093e3 Varun Sethi 2013-07-15  14   *
695093e3 Varun Sethi 2013-07-15  15   * Copyright (C) 2013 Freescale

Semiconductor, Inc.

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
695093e3 Varun Sethi 2013-07-15  16   *
695093e3 Varun Sethi 2013-07-15  17   */
695093e3 Varun Sethi 2013-07-15  18
695093e3 Varun Sethi 2013-07-15  19  #ifndef __FSL_PAMU_H
695093e3 Varun Sethi 2013-07-15  20  #define __FSL_PAMU_H
695093e3 Varun Sethi 2013-07-15  21
cd70d465 Emil Medve  2015-01-28  22  #include <linux/iommu.h>
cd70d465 Emil Medve  2015-01-28  23

695093e3 Varun Sethi 2013-07-15 @24 #include

<asm/fsl_pamu_stash.h>

Quoted 7 lines
Quoted 4 lines

The patch just triggered the build and for some reason these folks are building the driver on non-e500mc arches/defconfigs

Hmm.... I believe PAMU driver got included due to the COMPILE_TEST dependency. This is an issue, if we add the COMPILE_TEST dependency, then we can't include architecture specific include files?

Quoted 7 lines
Quoted 3 lines

What in fsl_pamu_stash.h is "even more" arch/platform specific then the content of drivers/iommu/fsl_pamu*?

This was discussed during early PAMU driver reviews. Joerg's idea was that PAMU would specific to the Power architecture platform, so we should place the include file in the arch specific directory (originally I had placed it under include/linux).

But the only content that ended up in arch/powerpc is one file with two definitions that don't seem particularly specific. The line is a bit blurry and until (if ever) we get different PAMU integration I doubt we can reasonably make it sharper

Anyway, I'm unsure what an immediately acceptable answer is. I mean if we're to spend time supporting universal builds of the PAMU driver there is a list of (some non-trivial) changes we ought to do. This particular build issue is just the first

Cheers,

A message that is not in the archive (sent off-list or not yet received): [email protected]

#11 lore raw

Hi Joerg,
Following issue was observed while building (compile test) for a non-powerpc (e500mc) based platform. The pamu driver includes a file which is available in the architecture include directory. Should we move the header file to general Linux kernel include directory?

Regards
Varun

Quoted 123 lines

-----Original Message-----
From: Emil Medve [mailto:[email protected]]
Sent: Wednesday, March 25, 2015 1:07 PM
To: Sethi Varun-B16395; [email protected]; [email protected]
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Hello Varun,

Quoted 31 lines · On 03/25/2015 01:25 AM, Sethi Varun-B16395 wrote:

Hi Emil,

Quoted 29 lines

-----Original Message-----
From: Emil Medve [mailto:[email protected]]
Sent: Wednesday, March 25, 2015 11:41 AM
To: Sethi Varun-B16395; [email protected]; [email protected]
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32:
fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Hello Varun,

Quoted 16 lines · On 03/25/2015 12:46 AM, Sethi Varun-B16395 wrote:
Quoted 16 lines

-----Original Message-----
From: Emil Medve [mailto:[email protected]]
Sent: Tuesday, March 24, 2015 2:10 PM
To: [email protected]; Sethi Varun-B16395
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32:
fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Hello Varun,

Quoted 1 line · kbuild test robot

tree: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git

ppc/pamu

Quoted 2 lines
head:   f2fafdd954d743a0e68e5cd76dbef2f2454deefa
commit: f2fafdd954d743a0e68e5cd76dbef2f2454deefa [1/1]

iommu/fsl:

Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines

PAMU

Quoted 4 lines

is also present on 64-bit SoC(s)
config: microblaze-allyesconfig (attached as .config) reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-

tests.git/plain/sbin/make.cross -O ~/bin/make.cross

Quoted 5 lines

chmod +x ~/bin/make.cross
git checkout f2fafdd954d743a0e68e5cd76dbef2f2454deefa

  # save the attached .config to linux build tree
  make.cross ARCH=microblaze
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

All error/warnings:

In file included from drivers/iommu/fsl_pamu.c:21:0:

Quoted 1 line
Quoted 1 line

drivers/iommu/fsl_pamu.h:24:32: fatal error:

asm/fsl_pamu_stash.h:

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line

No such file or directory

    #include <asm/fsl_pamu_stash.h>
                                   ^

compilation terminated.

vim +24 drivers/iommu/fsl_pamu.h

Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

695093e3 Varun Sethi 2013-07-15 8 * MERCHANTABILITY or FITNESS

FOR

Quoted 5 lines
Quoted 5 lines

A PARTICULAR PURPOSE. See the

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 9 * GNU General Public License for

more details.

Quoted 2 lines
695093e3 Varun Sethi 2013-07-15  10   *
695093e3 Varun Sethi 2013-07-15  11   * You should have received a

copy

Quoted 28 lines
Quoted 28 lines

of

Quoted 4 lines
Quoted 4 lines

the GNU General Public License

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 12 * along with this program; if not,

write to the Free Software

Quoted 1 line

695093e3 Varun Sethi 2013-07-15 13 * Foundation, 51 Franklin Street,

Fifth

Quoted 4 lines
Quoted 4 lines

Floor, Boston, MA 02110-1301, USA.

Quoted 2 lines
695093e3 Varun Sethi 2013-07-15  14   *
695093e3 Varun Sethi 2013-07-15  15   * Copyright (C) 2013 Freescale

Semiconductor, Inc.

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
695093e3 Varun Sethi 2013-07-15  16   *
695093e3 Varun Sethi 2013-07-15  17   */
695093e3 Varun Sethi 2013-07-15  18
695093e3 Varun Sethi 2013-07-15  19  #ifndef __FSL_PAMU_H
695093e3 Varun Sethi 2013-07-15  20  #define __FSL_PAMU_H
695093e3 Varun Sethi 2013-07-15  21
cd70d465 Emil Medve  2015-01-28  22  #include <linux/iommu.h>
cd70d465 Emil Medve  2015-01-28  23

695093e3 Varun Sethi 2013-07-15 @24 #include

<asm/fsl_pamu_stash.h>

Quoted 7 lines
Quoted 4 lines

The patch just triggered the build and for some reason these folks are building the driver on non-e500mc arches/defconfigs

Hmm.... I believe PAMU driver got included due to the COMPILE_TEST dependency. This is an issue, if we add the COMPILE_TEST dependency, then we can't include architecture specific include files?

Quoted 7 lines
Quoted 3 lines

What in fsl_pamu_stash.h is "even more" arch/platform specific then the content of drivers/iommu/fsl_pamu*?

This was discussed during early PAMU driver reviews. Joerg's idea was that PAMU would specific to the Power architecture platform, so we should place the include file in the arch specific directory (originally I had placed it under include/linux).

But the only content that ended up in arch/powerpc is one file with two definitions that don't seem particularly specific. The line is a bit blurry and until (if ever) we get different PAMU integration I doubt we can reasonably make it sharper

Anyway, I'm unsure what an immediately acceptable answer is. I mean if we're to spend time supporting universal builds of the PAMU driver there is a list of (some non-trivial) changes we ought to do. This particular build issue is just the first

Cheers,

A message that is not in the archive (sent off-list or not yet received): BN3PR0301MB12198F55BD2619F392B58AD4EAFC0-CEkquS/Gb81uuip9JPHoc5wN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/[email protected]

#13 lore raw

Hi Varun,

Quoted 4 lines · Varun Sethi

Following issue was observed while building (compile test) for a non-powerpc (e500mc) based platform. The pamu driver includes a file which is available in the architecture include directory. Should we move the header file to general Linux kernel include directory?

Before I added the COMPILE_TEST dependency it looked like this:

depends on PPC_E500MC

Which means the driver was only buildable on e500mc and now you are telling me that this is broken. What am I missing?

Joerg

A message that is not in the archive (sent off-list or not yet received): [email protected]

#15 lore raw

Hi Joerg,

Quoted 17 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: Tuesday, May 05, 2015 6:47 PM
To: Sethi Varun-B16395
Cc: [email protected]; iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org; Bucur Madalin- Cristian-B32716
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Hi Varun,

Quoted 4 lines · Varun Sethi

Following issue was observed while building (compile test) for a non-powerpc (e500mc) based platform. The pamu driver includes a file which is available in the architecture include directory. Should we move the header file to general Linux kernel include directory?

Quoted 7 lines

Before I added the COMPILE_TEST dependency it looked like this:

depends on PPC_E500MC

Which means the driver was only buildable on e500mc and now you are telling me that this is broken. What am I missing?

PPC_E500MC dependency is fine, but with the COMPIL_TEST flag ("or" condition) the PAMU driver code would be built on any platform if the compile test is selected.

-Varun

A message that is not in the archive (sent off-list or not yet received): BN1PR0301MB06271FBAE46B4CBDD9781D0FEAD10-RQSpjbwlmjSD1ymB6+i1+JwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/[email protected]

#17 lore raw
Quoted 6 lines · Varun Sethi
Quoted 3 lines

Which means the driver was only buildable on e500mc and now you are telling me that this is broken. What am I missing?

PPC_E500MC dependency is fine, but with the COMPIL_TEST flag ("or" condition) the PAMU driver code would be built on any platform if the compile test is selected.

You said it is now also selected on non-ppc platforms, but there is a PPC32 dependency, so this shouldn't happen. It should build fine on any ppc platform as the include file is in arch/powerpc/include/asm, no?

Joerg

A message that is not in the archive (sent off-list or not yet received): [email protected]

#19 lore raw

Hi Joerg,

Quoted 15 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: Tuesday, May 05, 2015 7:13 PM
To: Sethi Varun-B16395
Cc: [email protected]; iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org; Bucur Madalin- Cristian-B32716
Subject: Re: [iommu:ppc/pamu 1/1] drivers/iommu/fsl_pamu.h:24:32: fatal
error: asm/fsl_pamu_stash.h: No such file or directory

Quoted 3 lines · Varun Sethi
Quoted 3 lines

Which means the driver was only buildable on e500mc and now you are telling me that this is broken. What am I missing?

Quoted 7 lines
Quoted 3 lines

PPC_E500MC dependency is fine, but with the COMPIL_TEST flag ("or" condition) the PAMU driver code would be built on any platform if the compile test is selected.

You said it is now also selected on non-ppc platforms, but there is a PPC32 dependency, so this shouldn't happen. It should build fine on any ppc platform as the include file is in arch/powerpc/include/asm, no?

Actually PPC32 dependency is incorrect, that's what Emil's patch removed. As a result PAMU driver got built on other platforms as well. commit f2fafdd954d743a0e68e5cd76dbef2f2454deefa

PAMU driver should depend on PPC_E500MC.

-Varun

A message that is not in the archive (sent off-list or not yet received): BN1PR0301MB0627F543CF6AE00CFED18B47EAD10-RQSpjbwlmjSD1ymB6+i1+JwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/[email protected]

#21 lore raw

Hi Varun,

Quoted 5 lines · Varun Sethi

Actually PPC32 dependency is incorrect, that's what Emil's patch removed. As a result PAMU driver got built on other platforms as well. commit f2fafdd954d743a0e68e5cd76dbef2f2454deefa

PAMU driver should depend on PPC_E500MC.

Instead of only removing the PPC32 dependency you guys should have replaced it with the correct architecture config symbol to prevent it from being built on anything else than PPC. I am pretty sure there is one you can rely on.

Joerg