adm8211: fix the possible pci cache line sizes inside switch-case
Subsystems (3)
PATCH 1/1 adm8211: fix the possible pci cache line sizes inside switch-case
The PCI cache line size value, stored in cline variable, was being compared against decimal values written as hex literals. This patch changes those literals to correct hex values.
Please note that this patch is on top of
another code cleanup patch '[PATCH] adm8211: fix checkpatch errors for indentation and new line around switch-case'.
--- drivers/net/wireless/adm8211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/adm8211.c +2 -2
@@ -1101,10 +1101,10 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)case 0x8 : reg |= (0x1 <<14 );break ; -case 0x16 : +case 0x10 : reg |= (0x2 <<14 );break ; -case 0x32 : +case 0x20 : reg |= (0x3 <<14 );break ;default :
Signature · 1 line
1.9.1
Quoted 3 lines · Okash Khawaja
The PCI cache line size value, stored in cline variable, was being compared against decimal values written as hex literals. This patch changes those literals to correct hex values.
This is fine.
The grammar might be better as something like:
The PCI cache line size value was being compared against decimal values prefixed with 0x.
Fix the literals to use the correct hex values.
Quoted 3 lines
Please note that this patch is on top of
another code cleanup patch '[PATCH] adm8211: fix checkpatch errors for indentation and new line around switch-case'.
But this information doesn't belong here as
it would also be in a git log when someone
uses git am to apply it to a tree.
It'd be better to send a patch series using
"git format-email --cover-letter -2 -o <dir>"
and use git send-email for the series.
Quoted 18 lines · Joe Perches
Quoted 3 lines · Okash Khawaja
The PCI cache line size value, stored in cline variable, was being compared against decimal values written as hex literals. This patch changes those literals to correct hex values.
This is fine.
The grammar might be better as something like:
The PCI cache line size value was being compared against decimal values prefixed with 0x.
Fix the literals to use the correct hex values.
Quoted 3 lines
Please note that this patch is on top of
another code cleanup patch '[PATCH] adm8211: fix checkpatch errors for indentation and new line around switch-case'.
Quoted 9 lines
But this information doesn't belong here as
it would also be in a git log when someone
uses git am to apply it to a tree.It'd be better to send a patch series using
"git format-email --cover-letter -2 -o <dir>"
and use git send-email for the series.
This is my first time going throug the process of submitting patches, something you may have already noticed. I have created and submitted patch series.Thanks