Skip to contentSkip to conversation

python-pyqt: fix opengl build failure

PATCH New Gwenhael Goavec-Merou 2 participants 4 messages May 6, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 python-pyqt: fix opengl build failure

From: Gwenhael Goavec-Merou <[email protected]>

Fix:
http://autobuild.buildroot.net/results/206/2062208c171207428c9121215971e00c52bf306a/

According to configure-ng.py, PyQt_NoOpenGLES must be added to qtdetail when QT_OPENGL_ES is set.

---
 package/python-pyqt/python-pyqt.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/python-pyqt/python-pyqt.mk +4 -0
index 2445567..f10d508 100644
@@ -40,6 +40,10 @@ ifeq ($(BR2_PACKAGE_QT_OPENSSL),)
 PYTHON_PYQT_QTDETAIL_DISABLE_FEATURES += PyQt_OpenSSL
 endif
 
+ifeq ($(BR2_PACKAGE_QT_OPENGL_ES),y)
+PYTHON_PYQT_QTDETAIL_DISABLE_FEATURES += PyQt_NoOpenGLES
+endif
+
 # PyQt_qreal_double must be disabled on a number of architectures that
 # use float for qreal.
 ifeq ($(BR2_PACKAGE_PYTHON_PYQT_ARCH_USES_QREAL_FLOAT),y)
Signature · 1 line
2.3.6
#1 lore raw

PATCH 1/1 python-pyqt: fix opengl build failure

Dear Gwenhael Goavec-Merou,

package/python-pyqt/python-pyqt.mk ifeq ($(BR2_PACKAGE_QT_OPENSSL),) · line 45

Quoted 3 lines · Gwenhael Goavec-Merou
package/python-pyqt/python-pyqt.mk +3 -0
+ifeq ($(BR2_PACKAGE_QT_OPENGL_ES),y)
+PYTHON_PYQT_QTDETAIL_DISABLE_FEATURES += PyQt_NoOpenGLES
+endif

Wow, this is a lot of negation.

So, when OpenGL ES is available, you need to disable the fact of not using OpenGL ES.

Interesting :-)

Maybe a comment above this piece of code would be useful, because it's a bit twisted.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 python-pyqt: fix opengl build failure

Yes.
There are something funny in the logic of this disabling the disable of something to enabling openglES support...
Gwen

Quoted 23 lines · On Wed, 6 May 2015 17:14:50 +0200 Thomas Petazzoni…

Dear Gwenhael Goavec-Merou,

package/python-pyqt/python-pyqt.mk ifeq ($(BR2_PACKAGE_QT_OPENSSL),) · line 45

Quoted 3 lines · Gwenhael Goavec-Merou
package/python-pyqt/python-pyqt.mk +3 -0
+ifeq ($(BR2_PACKAGE_QT_OPENGL_ES),y)
+PYTHON_PYQT_QTDETAIL_DISABLE_FEATURES += PyQt_NoOpenGLES
+endif

Wow, this is a lot of negation.

So, when OpenGL ES is available, you need to disable the fact of not using OpenGL ES.

Interesting :-)

Maybe a comment above this piece of code would be useful, because it's a bit twisted.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 python-pyqt: fix opengl build failure

In reply to Gwenhael Goavec-Merou

Dear Gwenhael Goavec-Merou,

Quoted 5 lines · Gwenhael Goavec-Merou

From: Gwenhael Goavec-Merou <[email protected]>

Fix:
http://autobuild.buildroot.net/results/206/2062208c171207428c9121215971e00c52bf306a/

Quoted 7 lines

According to configure-ng.py, PyQt_NoOpenGLES must be added to qtdetail when QT_OPENGL_ES is set.

---
 package/python-pyqt/python-pyqt.mk | 4 ++++
 1 file changed, 4 insertions(+)

Applied after adding a comment explaining the weird things happening with the double negation. Thanks for the investigation and fix!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com