Skip to contentSkip to conversation

google-breakpad: disable on AArch64

PATCH New Thomas Petazzoni 2 participants 3 messages May 6, 2015

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 google-breakpad: disable on AArch64

Currently doesn't build, will be fixed upstream in a later version.

Fixes:

http://autobuild.buildroot.org/results/f45/f45925e63dd6ce09e41e1ce9a449d8fd57575314/

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/google-breakpad/Config.in      | 4 +++-
 package/lua-periphery/lua-periphery.mk | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)
package/google-breakpad/Config.in +3 -1
index a95bf63..401a983 100644
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 	bool
-	default y if BR2_i386 || BR2_x86_64 || BR2_arm || BR2_aarch64 || \
+	# Even though the source code pretends to support aarch64, it
+	# doesn't build as of Google Breakpad r1373.
+	default y if BR2_i386 || BR2_x86_64 || BR2_arm || \
 		BR2_mips || BR2_mipsel
 
 config BR2_PACKAGE_GOOGLE_BREAKPAD
package/lua-periphery/lua-periphery.mk +1 -0
index 0717a27..9bf38de 100644
@@ -9,5 +9,6 @@ LUA_PERIPHERY_VERSION = $(LUA_PERIPHERY_VERSION_UPSTREAM)-1
 LUA_PERIPHERY_SUBDIR = lua-periphery
 LUA_PERIPHERY_LICENSE = MIT
 LUA_PERIPHERY_LICENSE_FILES = $(LUA_PERIPHERY_SUBDIR)/LICENSE
+LUA_PERIPHERY_DEPENDENCIES = c-periphery
 
 $(eval $(luarocks-package))
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 google-breakpad: disable on AArch64

Hi Thomas,

Le 06/05/2015 21:28, Thomas Petazzoni a ?crit :

Quoted 1 line

Currently doesn't build, will be fixed upstream in a later version.

If you try with the aarch64 cs toolchain and the patch [1], google-breakpad build fine.
But I don't have a aarch64 cpu to do a runtime test through.

[1] http://patchwork.ozlabs.org/patch/467857/

Quoted 30 lines

Fixes:

http://autobuild.buildroot.org/results/f45/f45925e63dd6ce09e41e1ce9a449d8fd57575314/

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/google-breakpad/Config.in      | 4 +++-
 package/lua-periphery/lua-periphery.mk | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)
package/google-breakpad/Config.in +3 -1
index a95bf63..401a983 100644
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 	bool
-	default y if BR2_i386 || BR2_x86_64 || BR2_arm || BR2_aarch64 || \
+	# Even though the source code pretends to support aarch64, it
+	# doesn't build as of Google Breakpad r1373.
+	default y if BR2_i386 || BR2_x86_64 || BR2_arm || \
 		BR2_mips || BR2_mipsel
 
 config BR2_PACKAGE_GOOGLE_BREAKPAD
package/lua-periphery/lua-periphery.mk +0 -0
index 0717a27..9bf38de 100644

package/lua-periphery/lua-periphery.mk LUA_PERIPHERY_VERSION = $(LUA_PERIPHERY_VERSION_UPSTREAM)-1 · line 12

Quoted 4 lines
package/lua-periphery/lua-periphery.mk +1 -0
@@ -9,5 +9,6 @@ LUA_PERIPHERY_VERSION = $(LUA_PERIPHERY_VERSION_UPSTREAM)-1
 LUA_PERIPHERY_SUBDIR = lua-periphery
 LUA_PERIPHERY_LICENSE = MIT
 LUA_PERIPHERY_LICENSE_FILES = $(LUA_PERIPHERY_SUBDIR)/LICENSE
+LUA_PERIPHERY_DEPENDENCIES = c-periphery

This is not related to google-breakpad ;-)

Best regards,
Romain

Quoted 3 lines
package/lua-periphery/lua-periphery.mk +0 -0
 $(eval $(luarocks-package))
author
#2 lore raw

PATCH 1/1 google-breakpad: disable on AArch64

Dear Romain Naour,

Quoted 10 lines · Romain Naour

Hi Thomas,

Le 06/05/2015 21:28, Thomas Petazzoni a ?crit :

Quoted 1 line

Currently doesn't build, will be fixed upstream in a later version.

If you try with the aarch64 cs toolchain and the patch [1], google-breakpad build fine.
But I don't have a aarch64 cpu to do a runtime test through.

[1] http://patchwork.ozlabs.org/patch/467857/

With the Linaro toolchain, it fails with:

http://autobuild.buildroot.org/results/f45/f45925e63dd6ce09e41e1ce9a449d8fd57575314/build-end.log

But if it builds with the CS AArch64 toolchain, then the issue is different.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com