Skip to contentSkip to conversation

ARM: imx: using unsigned variable for do_div

PATCH New Anson Huang 3 participants 3 messages May 7, 2015

Subsystems (3)
Arm i.MX and Layerscape Common clk NXP i.MX clock drivers
lore
Share & tools
lore

Anson Huang

author
#0 lore raw

PATCH 1/1 ARM: imx: using unsigned variable for do_div

The definition of do_div uses unsigned long long
variable as its first parameter, better to pass
a u64 variable as first parameter when calling
do_div function.

Signed-off-by Anson Huang <[email protected]>
---
 drivers/clk/imx/clk-pllv3.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/imx/clk-pllv3.c +2 -2
index e34a925..8a94fa6 100644
@@ -220,7 +220,7 @@ static long clk_pllv3_av_round_rate(struct clk_hw *hw, unsigned long rate,
 	unsigned long max_rate = parent_rate * 54;
 	u32 div;
 	u32 mfn, mfd = 1000000;
-	s64 temp64;
+	u64 temp64;
 
 	if (rate > max_rate)
 		rate = max_rate;

@@ -244,7 +244,7 @@ static int clk_pllv3_av_set_rate(struct clk_hw *hw, unsigned long rate,
 	unsigned long max_rate = parent_rate * 54;
 	u32 val, div;
 	u32 mfn, mfd = 1000000;
-	s64 temp64;
+	u64 temp64;
 
 	if (rate < min_rate || rate > max_rate)
 		return -EINVAL;
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: imx: using unsigned variable for do_div

Quoted 6 lines · Anson Huang

The definition of do_div uses unsigned long long
variable as its first parameter, better to pass
a u64 variable as first parameter when calling
do_div function.

Signed-off-by Anson Huang <[email protected]>
Acked-by Uwe Kleine-K?nig <[email protected]>

Thanks
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Applied
#2 lore raw

PATCH 1/1 ARM: imx: using unsigned variable for do_div

In reply to Anson Huang
Quoted 6 lines · Anson Huang

The definition of do_div uses unsigned long long
variable as its first parameter, better to pass
a u64 variable as first parameter when calling
do_div function.

Signed-off-by Anson Huang <[email protected]>

Applied, thanks.