tools/thermal: tmon: fixed the 'make install' command

PATCH In review Anand Moon 3 participants 3 messages May 7, 2015 – May 8, 2015 Thermal

lore

Share & tools

lore

Anand Moon

author

2015-05-07 18:09 UTC #0 lore raw

PATCH 1/1 tools/thermal: tmon: fixed the 'make install' command

To install tmon we issue "make install" which produces bellow error.

root@odroidxu3:/usr/src/odroidxu3-4.y-testing/tools/thermal/tmon# make install
mkdir -p /usr/bin
install -m 755 -p "tmon" "/usr/bin/tmon"
mkdir -p /
install -m 644 -p "" "/"
install: cannot stat ‘’: No such file or directory
make: [install] Error 1 (ignored)

Signed-off-by Anand Moon <[email protected]>

---
 tools/thermal/tmon/Makefile | 8 --------
 1 file changed, 8 deletions(-)

tools/thermal/tmon/Makefile +0 -8

index 0788621..2e83dd3 100644
@@ -12,10 +12,6 @@ TARGET=tmon
 INSTALL_PROGRAM=install -m 755 -p
 DEL_FILE=rm -f
 
-INSTALL_CONFIGFILE=install -m 644 -p
-CONFIG_FILE=
-CONFIG_PATH=
-
 # Static builds might require -ltinfo, for instance
 ifneq ($(findstring -static, $(LDFLAGS)),)
 STATIC := --static

@@ -38,13 +34,9 @@ valgrind: tmon
 install:
 	- mkdir -p $(INSTALL_ROOT)/$(BINDIR)
 	- $(INSTALL_PROGRAM) "$(TARGET)" "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
-	- mkdir -p $(INSTALL_ROOT)/$(CONFIG_PATH)
-	- $(INSTALL_CONFIGFILE) "$(CONFIG_FILE)" "$(INSTALL_ROOT)/$(CONFIG_PATH)"
 
 uninstall:
 	$(DEL_FILE) "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
-	$(CONFIG_FILE) "$(CONFIG_PATH)"
-
 
 clean:
 	find . -name "*.o" | xargs $(DEL_FILE)

Signature · 1 line

1.9.1

Zhang Rui

reviewer

2015-05-08 03:05 UTC #2 lore raw

Quoted 10 lines · Jacob Pan

Quoted 2 lines · On Fri, 8 May 2015 03:39:04 +0930 Anand Moon <[email protected]> wrote:
To install tmon we issue "make install" which produces bellow error.
looks good, there is no config file for now.
Thanks for the fix.
Acked-by Jacob Pan <[email protected]>

patch applied. Thanks!

BTW, next time when sending a thermal related change, please cc [email protected], or else the change may got because we usually rely on https://patchwork.kernel.org/project/linux-pm/list/ to review and scrub the patches. :)

thanks,
rui

Quoted 45 lines

Quoted 37 lines
root@odroidxu3:/usr/src/odroidxu3-4.y-testing/tools/thermal/tmon# make install mkdir -p /usr/bin
install -m 755 -p "tmon" "/usr/bin/tmon"
mkdir -p /
install -m 644 -p "" "/"
install: cannot stat ‘’: No such file or directory
make: [install] Error 1 (ignored)
Signed-off-by Anand Moon <[email protected]>
---
 tools/thermal/tmon/Makefile | 8 --------
 1 file changed, 8 deletions(-)
tools/thermal/tmon/Makefile +0 -4
index 0788621..2e83dd3 100644
@@ -12,10 +12,6 @@ TARGET=tmon
 INSTALL_PROGRAM=install -m 755 -p
 DEL_FILE=rm -f
 
-INSTALL_CONFIGFILE=install -m 644 -p
-CONFIG_FILE=
-CONFIG_PATH=
-
 # Static builds might require -ltinfo, for instance
 ifneq ($(findstring -static, $(LDFLAGS)),)
 STATIC := --static
@@ -38,13 +34,9 @@ valgrind: tmon
 install:
 	- mkdir -p $(INSTALL_ROOT)/$(BINDIR)
 	- $(INSTALL_PROGRAM) "$(TARGET)"
"$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
tools/thermal/tmon/Makefile +0 -2
-	- mkdir -p $(INSTALL_ROOT)/$(CONFIG_PATH)
-	- $(INSTALL_CONFIGFILE) "$(CONFIG_FILE)"
"$(INSTALL_ROOT)/$(CONFIG_PATH)"
uninstall:
tools/thermal/tmon/Makefile valgrind: tmon · line 42
Quoted 6 lines
tools/thermal/tmon/Makefile +0 -2
 	$(DEL_FILE) "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
-	$(CONFIG_FILE) "$(CONFIG_PATH)"
-
 
 clean:
 	find . -name "*.o" | xargs $(DEL_FILE)
[Jacob Pan]