RAS queue for 4.2
Borislav Petkov
maintainerHi Ingo,
please pull,
thanks.
---
The following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22:
Linux 4.1-rc2 (2015-05-03 19:22:23 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git tags/ras_for_4.2
for you to fetch changes up to 3490c0e45f7e5a5b1e5c62e4c60b0e55b2e75e71:
x86/mce/amd: Zap changelog (2015-05-07 12:06:43 +0200)
----------------------------------------------------------------
RAS: Add support for deferred errors on AMD (Aravind Gopalakrishnan)
This is an important RAS feature which adds hardware support for poisoned data. That means roughly that the hardware marks data which it has detected as corrupted but wasn't able to correct, as poisoned data and raises an APIC interrupt to signal that in the form of a deferred error. It is the OS's responsibility then to take proper recovery action and thus prolonge system lifetime as far as possible.
Misc cleanups ontop. (Borislav Petkov)
----------------------------------------------------------------
Aravind Gopalakrishnan (6):
x86/mce/amd: Factor out logging mechanism x86/mce/amd: Collect valid address before logging an error x86/mce: Add support for deferred errors on AMD x86/mce/amd: Introduce deferred error interrupt handler x86/irq: Cleanup ordering of vector numbers x86/mce/amd: Rename setup_APIC_mce
Borislav Petkov (2):
x86/traps: Remove superfluous weak definitions and dead code x86/mce/amd: Zap changelog
arch/x86/include/asm/entry_arch.h | 3 + arch/x86/include/asm/hardirq.h | 3 + arch/x86/include/asm/hw_irq.h | 2 + arch/x86/include/asm/irq_vectors.h | 11 +-- arch/x86/include/asm/mce.h | 18 +++- arch/x86/include/asm/trace/irq_vectors.h | 6 ++ arch/x86/include/asm/traps.h | 3 +- arch/x86/kernel/cpu/mcheck/mce.c | 10 ++- arch/x86/kernel/cpu/mcheck/mce_amd.c | 141 ++++++++++++++++++++++++++----- arch/x86/kernel/entry_64.S | 5 ++ arch/x86/kernel/irq.c | 6 ++ arch/x86/kernel/irqinit.c | 4 + arch/x86/kernel/traps.c | 12 --- 13 files changed, 182 insertions(+), 42 deletions(-)
arch/x86/include/asm/entry_arch.h +3 -0
@@ -50,4 +50,7 @@ BUILD_INTERRUPT(thermal_interrupt,THERMAL_APIC_VECTOR) BUILD_INTERRUPT(threshold_interrupt,THRESHOLD_APIC_VECTOR)#endif +#ifdef CONFIG_X86_MCE_AMD +BUILD_INTERRUPT(deferred_error_interrupt, DEFERRED_ERROR_VECTOR) +#endif #endif
arch/x86/include/asm/hardirq.h +3 -0
@@ -33,6 +33,9 @@ typedef struct {#ifdef CONFIG_X86_MCE_THRESHOLD unsigned int irq_threshold_count;#endif +#ifdef CONFIG_X86_MCE_AMD +unsigned int irq_deferred_error_count; +#endif #if IS_ENABLED (CONFIG_HYPERV ) || defined(CONFIG_XEN )unsigned int irq_hv_callback_count;#endif
arch/x86/include/asm/hw_irq.h +2 -0
@@ -73,6 +73,7 @@ extern asmlinkage void invalidate_interrupt31(void); extern asmlinkage void irq_move_cleanup_interrupt(void); extern asmlinkage void reboot_interrupt(void); extern asmlinkage void threshold_interrupt(void); +extern asmlinkage void deferred_error_interrupt(void); extern asmlinkage void call_function_interrupt(void); extern asmlinkage void call_function_single_interrupt(void);
@@ -87,6 +88,7 @@ extern void trace_spurious_interrupt(void);extern void trace_thermal_interrupt (void );extern void trace_reschedule_interrupt (void );extern void trace_threshold_interrupt (void ); +extern void trace_deferred_error_interrupt (void );extern void trace_call_function_interrupt (void );extern void trace_call_function_single_interrupt (void );#define trace_irq_move_cleanup_interrupt irq_move_cleanup_interrupt
arch/x86/include/asm/irq_vectors.h +6 -5
@@ -102,21 +102,22 @@*/ #define X86_PLATFORM_IPI_VECTOR 0xf7 -/* Vector for KVM to deliver posted interrupt IPI */ -#ifdef CONFIG_HAVE_KVM -#define POSTED_INTR_VECTOR 0xf2 -#endif -/* * IRQ work vector: */ #define IRQ_WORK_VECTOR 0xf6#define UV_BAU_MESSAGE 0xf5 +#define DEFERRED_ERROR_VECTOR 0xf4/* Vector on which hypervisor callbacks will be delivered */ #define HYPERVISOR_CALLBACK_VECTOR 0xf3 +/* Vector for KVM to deliver posted interrupt IPI */ +#ifdef CONFIG_HAVE_KVM +#define POSTED_INTR_VECTOR 0xf2 +#endif +/* * Local APIC timer IRQ vector is on a different priority level, * to work around the 'lost local interrupt if more than 2 IRQ
arch/x86/include/asm/mce.h +16 -2
@@ -117,8 +117,19 @@ struct mca_config { };struct mce_vendor_flags { -__u64 overflow_recov :1 ,/* cpuid_ebx(80000007) */ - __reserved_0 :63 ; +/* +* overflow recovery cpuid bit indicates that overflow +* conditions are not fatal +*/ +__u64 overflow_recov :1 , + +/* +* SUCCOR stands for S/W UnCorrectable error COntainment +* and Recovery. It indicates support for data poisoning +* in HW and deferred error interrupts. +*/ + succor :1 , + __reserved_0 :62 ; };extern struct mce_vendor_flags mce_flags;
@@ -223,6 +234,9 @@ void do_machine_check(struct pt_regs *, long);extern void (*mce_threshold_vector)(void );extern void (*threshold_cpu_callback)(unsigned long action,unsigned int cpu); +/* Deferred error interrupt handler */ +extern void (*deferred_error_int_vector)(void ); +/* * Thermal handler */
arch/x86/include/asm/trace/irq_vectors.h +6 -0
@@ -101,6 +101,12 @@ DEFINE_IRQ_VECTOR_EVENT(call_function_single);DEFINE_IRQ_VECTOR_EVENT (threshold_apic);/* +* deferred_error_apic - called when entering/exiting a deferred apic interrupt +* vector handler +*/ +DEFINE_IRQ_VECTOR_EVENT (deferred_error_apic); + +/* * thermal_apic - called when entering/exiting a thermal apic interrupt * vector handler */
arch/x86/include/asm/traps.h +2 -1
@@ -108,7 +108,8 @@ extern int panic_on_unrecovered_nmi;void math_emulate (struct math_emu_info *);#ifndef CONFIG_X86_32 asmlinkage void smp_thermal_interrupt(void); -asmlinkage void mce_threshold_interrupt(void); +asmlinkage void smp_threshold_interrupt(void); +asmlinkage void smp_deferred_error_interrupt(void);#endif extern enum ctx_state ist_enter (struct pt_regs *regs);
arch/x86/kernel/cpu/mcheck/mce.c +8 -2
@@ -1637,10 +1637,16 @@ static void __mcheck_cpu_init_vendor(struct cpuinfo_x86 *c)mce_intel_feature_init (c); mce_adjust_timer = cmci_intel_adjust_timer;break ; -case X86_VENDOR_AMD : + +case X86_VENDOR_AMD : { +u32 ebx =cpuid_ebx (0x80000007 ); +mce_amd_feature_init (c); - mce_flags.overflow_recov =cpuid_ebx (0x80000007 ) &0x1 ; + mce_flags.overflow_recov = !!(ebx &BIT (0 )); + mce_flags.succor = !!(ebx &BIT (1 ));break ; + } +default :break ; }
arch/x86/kernel/cpu/mcheck/mce_amd.c +121 -20
211 lines not on this page · raw message
arch/x86/kernel/entry_64.S +5 -0
@@ -935,6 +935,11 @@ apicinterrupt THRESHOLD_APIC_VECTOR \ threshold_interrupt smp_threshold_interrupt #endif +#ifdef CONFIG_X86_MCE_AMD +apicinterrupt DEFERRED_ERROR_VECTOR \ + deferred_error_interrupt smp_deferred_error_interrupt +#endif + #ifdef CONFIG_X86_THERMAL_VECTOR apicinterrupt THERMAL_APIC_VECTOR \ thermal_interrupt smp_thermal_interrupt
arch/x86/kernel/irq.c +6 -0
@@ -116,6 +116,12 @@ int arch_show_interrupts(struct seq_file *p, int prec)seq_printf (p,"%10u " ,irq_stats (j)->irq_threshold_count);seq_puts (p," Threshold APIC interrupts\n" );#endif +#ifdef CONFIG_X86_MCE_AMD +seq_printf (p,"%*s: " , prec,"DFR" ); +for_each_online_cpu (j) +seq_printf (p,"%10u " ,irq_stats (j)->irq_deferred_error_count); +seq_puts (p," Deferred Error APIC interrupts\n" ); +#endif #ifdef CONFIG_X86_MCE seq_printf (p,"%*s: " , prec,"MCE" );for_each_online_cpu (j)
arch/x86/kernel/irqinit.c +4 -0
@@ -135,6 +135,10 @@ static void __init apic_intr_init(void)alloc_intr_gate (THRESHOLD_APIC_VECTOR , threshold_interrupt);#endif +#ifdef CONFIG_X86_MCE_AMD +alloc_intr_gate (DEFERRED_ERROR_VECTOR , deferred_error_interrupt); +#endif +#ifdef CONFIG_X86_LOCAL_APIC /* self generated IPI for local APIC timer */ alloc_intr_gate (LOCAL_TIMER_VECTOR , apic_timer_interrupt);
arch/x86/kernel/traps.c +0 -12
@@ -813,18 +813,6 @@ dotraplinkage void do_spurious_interrupt_bug(struct pt_regs *regs, long error_code) {conditional_sti (regs); -#if 0 -/* No need to warn about this any longer. */ -pr_info ("Ignoring P6 Local APIC Spurious Interrupt Bug...\n" ); -#endif -} - -asmlinkage __visible void __attribute__((weak)) smp_thermal_interrupt(void) -{ -} - -asmlinkage __visible void __attribute__((weak)) smp_threshold_interrupt(void) -{ }/*
Signature · 5 lines
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--