arm-cci: Do not enable CCI-400 PMU by default
PATCH 1/1 arm-cci: Do not enable CCI-400 PMU by default
From: "Suzuki K. Poulose" <[email protected]>
Do not enable CCI-400 PMU by default and fix the dependency on PERF_EVENTS than HW_PERF_EVENTS.
--- drivers/bus/Kconfig | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/bus/Kconfig +4 -6
@@ -13,15 +13,13 @@ config ARM_CCI400_COMMON config ARM_CCI400_PMU bool "ARM CCI400 PMU support" - default y depends on ARM || ARM64 - depends on HW_PERF_EVENTS + depends on PERF_EVENTS select ARM_CCI400_COMMON help - Support for PMU events monitoring on the ARM CCI cache coherent - interconnect. - - If unsure, say Y + Support for PMU events monitoring on the ARM CCI-400 (cache coherent + interconnect). CCI-400 supports counting events related to the + connected slave/master interfaces. config ARM_CCI400_PORT_CTRL bool
Signature · 1 line
1.7.9.5
PATCH 1/1 arm-cci: Do not enable CCI-400 PMU by default
Quoted 5 lines · Suzuki K. Poulose
config
ARM_CCI400_PMUdrivers/bus/Kconfig +0
-2bool "ARM CCI400 PMU support" - default y depends on ARM || ARM64 - depends on HW_PERF_EVENTS
drivers/bus/Kconfig config ARM_CCI400_COMMON · line 22
Quoted 10 lines
drivers/bus/Kconfig +4
-4+ depends on PERF_EVENTS select ARM_CCI400_COMMON help - Support for PMU events monitoring on the ARM CCI cache coherent - interconnect. - - If unsure, say Y + Support for PMU events monitoring on the ARM CCI-400 (cache coherent + interconnect). CCI-400 supports counting events related to the + connected slave/master interfaces.
This still needs to be better. How do I know whether it should be enabled for my platform or not?
Presumably, we can say that CCI-400 does not appear on CPUs older than X, which means we can add "The CCI-400 may be provided on ARM CPUs X or later."
I doubt that you'll find CCI-400 on ARMv6 or older ARM architectures for example. Maybe then we need "depends on ARM || ARM64" to be tighter? "depends on (ARM && CPU_V7) || ARM64" ?
Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.
PATCH 1/1 arm-cci: Do not enable CCI-400 PMU by default
Quoted 20 lines · Russell King - ARM Linux
Quoted 5 lines · Suzuki K. Poulose
config
ARM_CCI400_PMU
bool "ARM CCI400 PMU support"drivers/bus/Kconfig +0
-2- default y depends on ARM || ARM64 - depends on HW_PERF_EVENTSdrivers/bus/Kconfig config ARM_CCI400_COMMON · line 22
Quoted 10 lines
drivers/bus/Kconfig +4
-4+ depends on PERF_EVENTS select ARM_CCI400_COMMON help - Support for PMU events monitoring on the ARM CCI cache coherent - interconnect. - - If unsure, say Y + Support for PMU events monitoring on the ARM CCI-400 (cache coherent + interconnect). CCI-400 supports counting events related to the + connected slave/master interfaces.This still needs to be better. How do I know whether it should be enabled for my platform or not?
Quoted 8 lines
Presumably, we can say that CCI-400 does not appear on CPUs older than X, which means we can add "The CCI-400 may be provided on ARM CPUs X or later."
I doubt that you'll find CCI-400 on ARMv6 or older ARM architectures for example. Maybe then we need "depends on ARM || ARM64" to be tighter? "depends on (ARM &&
CPU_V7) || ARM64" ?
Yes, the CCI-400 could be found only on V7 or later (which could include 32bit only V8) for ARM32.
I can fix that.
Suzuki