Skip to contentSkip to conversation

ARM: socfpga: dts: Add a clock node for sdmmc CIU

PATCH Superseded dinguyen at opensource.altera.com 2 participants 4 messages Apr 14, 2015 – May 13, 2015 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: socfpga: dts: Add a clock node for sdmmc CIU

From: Dinh Nguyen <[email protected]>

The CIU(Card Interface Unit) get its clock from the sdmmc_clk_divided clock which is used to clock the card. The sdmmc_clk_divided clock is the sdmmc_clk passed through a fixed divider of 4. This patch adds the sdmmc_clk_divided node and makes the sdmmc_clk it's parent.

---
v2: renamed ciu_clk to sdmmc_clk_divided

---
 arch/arm/boot/dts/socfpga.dtsi | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
arch/arm/boot/dts/socfpga.dtsi +9 -1
index d9176e6..be4beda 100644
@@ -451,6 +451,14 @@
 						clk-phase = <0 135>;
 					};
 
+					sdmmc_clk_divided: sdmmc_clk_divided {
+						#clock-cells = <0>;
+						compatible = "altr,socfpga-gate-clk";
+						clocks = <&sdmmc_clk>;
+						clk-gate = <0xa0 8>;
+						fixed-divider = <4>;
+					};
+
 					nand_x_clk: nand_x_clk {
 						#clock-cells = <0>;
 						compatible = "altr,socfpga-gate-clk";
@@ -635,7 +643,7 @@
 			fifo-depth = <0x400>;
 			#address-cells = <1>;
 			#size-cells = <0>;
-			clocks = <&l4_mp_clk>, <&sdmmc_clk>;
+			clocks = <&l4_mp_clk>, <&sdmmc_clk_divided>;
 			clock-names = "biu", "ciu";
 		};
 
Signature · 1 line
2.2.1
#1 lore raw

PATCH v2 1/1 ARM: socfpga: dts: Add a clock node for sdmmc CIU

Quoted 9 lines · dinguyen at opensource.altera.com

From: Dinh Nguyen <[email protected]>

The CIU(Card Interface Unit) get its clock from the sdmmc_clk_divided clock which is used to clock the card. The sdmmc_clk_divided clock is the sdmmc_clk passed through a fixed divider of 4. This patch adds the sdmmc_clk_divided node and makes the sdmmc_clk it's parent.

---

Is this a fix of some sort? I'm confused why this was sent to the clk maintainers when it seems to be more appropriate to go through the arm-soc tree.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
#2 lore raw

PATCH v2 1/1 ARM: socfpga: dts: Add a clock node for sdmmc CIU

Quoted 8 lines · Stephen Boyd
Quoted 7 lines · dinguyen at opensource.altera.com

From: Dinh Nguyen <[email protected]>

The CIU(Card Interface Unit) get its clock from the sdmmc_clk_divided clock which is used to clock the card. The sdmmc_clk_divided clock is the sdmmc_clk passed through a fixed divider of 4. This patch adds the sdmmc_clk_divided node and makes the sdmmc_clk it's parent.

Quoted 7 lines
Quoted 2 lines

---

Is this a fix of some sort? I'm confused why this was sent to the clk maintainers when it seems to be more appropriate to go through the arm-soc tree.

Ok, sorry about that. I thought since it was clock nodes, it would appropriate to CC clk maintainers.

BTW, can I take patches from drivers/clk/socfpga/* through the arm-soc tree or would that go through you guys?

Thanks,
Dinh

#3 lore raw

PATCH v2 1/1 ARM: socfpga: dts: Add a clock node for sdmmc CIU

Quoted 14 lines · Dinh Nguyen
Quoted 11 lines · Stephen Boyd
Quoted 9 lines · dinguyen at opensource.altera.com

From: Dinh Nguyen <[email protected]>

The CIU(Card Interface Unit) get its clock from the sdmmc_clk_divided clock which is used to clock the card. The sdmmc_clk_divided clock is the sdmmc_clk passed through a fixed divider of 4. This patch adds the sdmmc_clk_divided node and makes the sdmmc_clk it's parent.

---

Quoted 7 lines
Quoted 4 lines

Is this a fix of some sort? I'm confused why this was sent to the clk maintainers when it seems to be more appropriate to go through the arm-soc tree.

Ok, sorry about that. I thought since it was clock nodes, it would appropriate to CC clk maintainers.

Sure, Cc is fine, but I believe the mail was sent "To" us so that led to my confusion.

Quoted 4 lines

BTW, can I take patches from drivers/clk/socfpga/* through the arm-soc tree or would that go through you guys?

Unless there's some sort of complicated dependency between the clk tree and the arm-soc tree I'd prefer any patches against drivers/clk/* go through the clk tree.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project