dt/bindings: Add binding for the BCM2835 mailbox driver
Subsystems (4)
PATCH v6 1/3 dt/bindings: Add binding for the BCM2835 mailbox driver
From: Lubomir Rintel <[email protected]>
This patch was split out of Lubomir's original mailbox patch by Eric Anholt, and the required properties documentation and examples have been filled out more completely and updated for the driver being changed to expose a single channel.
---
v2: Split into a separate patch for submitting to the devicetree list.
Consistently start node docs with a capital letter. device's address in the example shouldn't have "0x". Drop machine-specific interrupt numbers from the docs. (changes by anholt).
v3: Move the file to just bcm2835-mbox.txt, clean up formatting
(changes by anholt, from review by Lee Jones).
v4: Move file back by consensus from various Broadcom platform
maintainers (changes by anholt, acked by Lee Jones).
v5: Document that the mailbox cell should be 0 in clients, and add an
example of a client.
v6: Add change description to commit message separate from this
version section. Update for #mbox-cells 0 change.
.../bindings/mailbox/brcm,bcm2835-mbox.txt | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt
Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt new file +26 -0
@@ -0,0 +1,26 @@ +Broadcom BCM2835 VideoCore mailbox IPC + +Required properties: + +- compatible: Should be "brcm,bcm2835-mbox" +- reg: Specifies base physical address and size of the registers +- interrupts: The interrupt number + See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt +- #mbox-cells: Specifies the number of cells needed to encode a mailbox + channel. The value shall be 0, since there is only one + mailbox channel implemented by the device. + +Example: + +mailbox: mailbox at 7e00b800 { + compatible = "brcm,bcm2835-mbox"; + reg = <0x7e00b880 0x40>; + interrupts = <0 1>; + #mbox-cells = <0>; +}; + +firmware: firmware { + compatible = "raspberrypi,firmware"; + mboxes = <&mailbox>; + #power-domain-cells = <1>; +};
Signature · 1 line
2.1.4
PATCH v8 2/3 mailbox: Enable BCM2835 mailbox support
From: Lubomir Rintel <[email protected]>
This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2 (despite being derived from the same firmware tree) doesn't.
The driver was originally submitted by Lubomir, based on the out-of-tree 2708 mailbox driver. Eric Anholt fixed it up for upstreaming, with the major functional change being that it now has no notion of multiple channels (since that is a firmware-dependent concept) and instead the raspberrypi-firmware driver will do that bit-twiddling in its own messages.
---
v2: Squashed Craig's work for review, carried over to new version of
Mailbox framework (changes by Lubomir)
v3: Fix multi-line comment style. Refer to the documentation by
filename. Only declare one MODULE_AUTHOR. Alphabetize includes. Drop some excessive dev_dbg()s (changes by anholt).
v4: Use the new bcm2835_peripheral_read_workaround(), drop the
unnecessary wmb()s, make the messages be a pointer to u32, rather than u32-cast-as-pointer, fold in small static functions, drop extra error messages, clean up sizeof() arg for malloc, disable interrupts on unload (changes by anholt).
v5: Rewrite as a single-channel driver, where the old notion of
channels will now be interpreted by an rpi-specific driver. Minor style fix. Drop peripheral_read_workaround() since it's been noted that readl() covers the non-interrupt half of it, and I found that we would need to resolve read ordering in the interrupt handler anyway (changes by anholt).
v6: rewrite commit message, only turn on interrupts when a client is
present, drop the started flag, use BIT() macro, update Broadcom copyright (changes by anholt, from Jassi's review). Drop s-o-b of Jassi and Suman, who appear to have been accidentally added by Craig (noted by Lubomir).
v7: Drop the txdone-style check in send_data, since the core will make
sure we're not called until the previous one is done. Fix "mbox" to be static (changes by anholt, from review by Jassi).
v8: Fix compiler warning from txdone check removal. Add a summary of
anholt's changes to the commit message. Supply our own of_xlate to insist that 0 mbox-cells are provided. Replace global *mbox with container_of()s. Drop our driver's extra "struct device *dev".
drivers/mailbox/Kconfig | 8 ++ drivers/mailbox/Makefile | 2 + drivers/mailbox/bcm2835-mailbox.c | 217 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 227 insertions(+) create mode 100644 drivers/mailbox/bcm2835-mailbox.c
drivers/mailbox/Kconfig +8 -0
@@ -60,4 +60,12 @@ config ALTERA_MBOX An implementation of the Altera Mailbox soft core. It is used to send message between processors. Say Y here if you want to use the Altera mailbox support. + +config BCM2835_MBOX + tristate "BCM2835 Mailbox" + depends on ARCH_BCM2835 + help + An implementation of the BCM2385 Mailbox. It is used to invoke + the services of the Videocore. Say Y here if you want to use the + BCM2835 Mailbox. endif
drivers/mailbox/Makefile +2 -0
@@ -11,3 +11,5 @@ obj-$(CONFIG_OMAP2PLUS_MBOX) += omap-mailbox.o obj-$(CONFIG_PCC) += pcc.o obj-$(CONFIG_ALTERA_MBOX) += mailbox-altera.o + +obj-$(CONFIG_BCM2835_MBOX) += bcm2835-mailbox.o
drivers/mailbox/bcm2835-mailbox.c new file +217 -0
217 lines not on this page · raw message
Signature · 1 line
2.1.4
Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support
Den 05.05.2015 22:27, skrev Eric Anholt:
Quoted 13 lines
From: Lubomir Rintel <[email protected]>
This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2 (despite being derived from the same firmware tree) doesn't.
The driver was originally submitted by Lubomir, based on the out-of-tree 2708 mailbox driver. Eric Anholt fixed it up for upstreaming, with the major functional change being that it now has no notion of multiple channels (since that is a firmware-dependent concept) and instead the raspberrypi-firmware driver will do that bit-twiddling in its own messages.
...
drivers/mailbox/bcm2835-mailbox.c line 213
Quoted 10 lines
drivers/mailbox/bcm2835-mailbox.c new file +10
-0+static struct platform_driver bcm2835_mbox_driver = { + .driver = { + .name ="bcm2835-mbox" , + .owner =THIS_MODULE , + .of_match_table = bcm2835_mbox_of_match, + }, + .probe = bcm2835_mbox_probe, + .remove = bcm2835_mbox_remove, +}; +module_platform_driver (bcm2835_mbox_driver);
I have tested this driver and the firmware driver booting directly from the VideoCore bootloader (no uboot).
The mailbox driver loads too late to turn on USB power:
[ 0.754258] platform soc:firmware: Driver raspberrypi-firmware
requests probe deferral
[ 2.041136] dwc2 20980000.usb: 256 invalid for host_nperio_tx_fifo_size. Check HW configuration. [ 2.050058] dwc2 20980000.usb: 512 invalid for host_perio_tx_fifo_size. Check HW configuration. [ 4.140894] dwc2 20980000.usb: dwc2_core_reset() HANG! Soft Reset GRSTCTL=80000001 [ 4.148583] dwc2 20980000.usb: dwc2_core_init(): Reset failed, aborting [ 4.155281] dwc2 20980000.usb: dwc2_hcd_init() FAILED, returning -16 [ 4.161720] dwc2: probe of 20980000.usb failed with error -16
[ 4.272027] bcm2835-mbox 2000b880.mailbox: mailbox enabled
When I move mailbox module init to arch_initcall, USB power is turned on.
[ 0.548481] bcm2835-mbox 2000b880.mailbox: mailbox enabled
[ 1.733669] raspberrypi_firmware_set_power *** I have added this [ 2.242699] USB: Power-on latency exceeded, new value 509026000 ns [ 3.109748] dwc2 20980000.usb: DWC OTG Controller [ 3.114690] dwc2 20980000.usb: new USB bus registered, assigned bus number 1 [ 3.121890] dwc2 20980000.usb: irq 33, io mem 0x00000000
This silences the warning:
struct raspberrypi_power_domain raspberrypi_power_domain_usb = {
.base = {
.power_on_latency_ns = 600000000,Noralf.
Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support
Quoted 15 lines · Noralf Tr?nnes
Den 05.05.2015 22:27, skrev Eric Anholt:
Quoted 13 lines
From: Lubomir Rintel <[email protected]>
This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2 (despite being derived from the same firmware tree) doesn't.
The driver was originally submitted by Lubomir, based on the out-of-tree 2708 mailbox driver. Eric Anholt fixed it up for upstreaming, with the major functional change being that it now has no notion of multiple channels (since that is a firmware-dependent concept) and instead the raspberrypi-firmware driver will do that bit-twiddling in its own messages.
...
Quoted 14 lines
drivers/mailbox/bcm2835-mailbox.c line 213
Quoted 10 lines
drivers/mailbox/bcm2835-mailbox.c new file +10
-0+static struct platform_driver bcm2835_mbox_driver = { + .driver = { + .name ="bcm2835-mbox" , + .owner =THIS_MODULE , + .of_match_table = bcm2835_mbox_of_match, + }, + .probe = bcm2835_mbox_probe, + .remove = bcm2835_mbox_remove, +}; +module_platform_driver (bcm2835_mbox_driver);I have tested this driver and the firmware driver booting directly from the VideoCore bootloader (no uboot).
The mailbox driver loads too late to turn on USB power:
Yeah, I have a patch on my branches that returns -EPROBE_DEFER when trying to get a power domain and not finding the provider. It was rejected by the maintainers in favor of a proposed solution whose description I didn't quite follow.
Quoted 4 lines
This silences the warning:
struct raspberrypi_power_domain raspberrypi_power_domain_usb = { .base = { .power_on_latency_ns = 600000000,
Oh, nice. Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150507/9068aea6/attachment.sig>
Re: Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support
On Thursday 07 May 2015, 12:54:20 wrote Eric Anholt:
Quoted 32 lines
Quoted 15 lines · Noralf Tr?nnes
Den 05.05.2015 22:27, skrev Eric Anholt:
Quoted 13 lines
From: Lubomir Rintel <[email protected]>
This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2 (despite being derived from the same firmware tree) doesn't.
The driver was originally submitted by Lubomir, based on the out-of-tree 2708 mailbox driver. Eric Anholt fixed it up for upstreaming, with the major functional change being that it now has no notion of multiple channels (since that is a firmware-dependent concept) and instead the raspberrypi-firmware driver will do that bit-twiddling in its own messages.
...
Quoted 14 lines
drivers/mailbox/bcm2835-mailbox.c line 213
Quoted 10 lines
drivers/mailbox/bcm2835-mailbox.c new file +10
-0+static struct platform_driver bcm2835_mbox_driver = { + .driver = { + .name ="bcm2835-mbox" , + .owner =THIS_MODULE , + .of_match_table = bcm2835_mbox_of_match, + }, + .probe = bcm2835_mbox_probe, + .remove = bcm2835_mbox_remove, +}; +module_platform_driver (bcm2835_mbox_driver);I have tested this driver and the firmware driver booting directly from the VideoCore bootloader (no uboot).
The mailbox driver loads too late to turn on USB power:
Quoted 4 lines
Yeah, I have a patch on my branches that returns -EPROBE_DEFER when trying to get a power domain and not finding the provider. It was rejected by the maintainers in favor of a proposed solution whose description I didn't quite follow.
Do you have a link for this thread?
Quoted 6 lines
Quoted 4 lines
This silences the warning:
struct raspberrypi_power_domain raspberrypi_power_domain_usb = { .base = { .power_on_latency_ns = 600000000,Oh, nice. Thanks!
Well, Using a timeout for dependencies seems odd to me.
Regards,
Alexander
Re: Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support
Quoted 33 lines · Alexander Stein
On Thursday 07 May 2015, 12:54:20 wrote Eric Anholt:
Quoted 32 lines
Quoted 29 lines · Noralf Tr?nnes
Den 05.05.2015 22:27, skrev Eric Anholt:
Quoted 13 lines
From: Lubomir Rintel <[email protected]>
This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2 (despite being derived from the same firmware tree) doesn't.
The driver was originally submitted by Lubomir, based on the out-of-tree 2708 mailbox driver. Eric Anholt fixed it up for upstreaming, with the major functional change being that it now has no notion of multiple channels (since that is a firmware-dependent concept) and instead the raspberrypi-firmware driver will do that bit-twiddling in its own messages.
...
drivers/mailbox/bcm2835-mailbox.c line 213
Quoted 10 lines
drivers/mailbox/bcm2835-mailbox.c new file +10
-0+static struct platform_driver bcm2835_mbox_driver = { + .driver = { + .name ="bcm2835-mbox" , + .owner =THIS_MODULE , + .of_match_table = bcm2835_mbox_of_match, + }, + .probe = bcm2835_mbox_probe, + .remove = bcm2835_mbox_remove, +}; +module_platform_driver (bcm2835_mbox_driver);I have tested this driver and the firmware driver booting directly from the VideoCore bootloader (no uboot).
The mailbox driver loads too late to turn on USB power:
Quoted 6 lines
Quoted 4 lines
Yeah, I have a patch on my branches that returns -EPROBE_DEFER when trying to get a power domain and not finding the provider. It was rejected by the maintainers in favor of a proposed solution whose description I didn't quite follow.
Do you have a link for this thread?
https://lkml.org/lkml/2015/3/11/483
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150508/4b533b38/attachment.sig>
Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support
Quoted 33 lines · Eric Anholt
Quoted 31 lines · Alexander Stein
On Thursday 07 May 2015, 12:54:20 wrote Eric Anholt:
Quoted 30 lines
Quoted 27 lines · Noralf Tr?nnes
Den 05.05.2015 22:27, skrev Eric Anholt:
Quoted 15 lines
From: Lubomir Rintel <[email protected]>
This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2 (despite being derived from the same firmware tree) doesn't.
The driver was originally submitted by Lubomir, based on the out-of-tree 2708 mailbox driver. Eric Anholt fixed it up for upstreaming, with the major functional change being that it now has no notion of multiple channels (since that is a firmware-dependent concept) and instead the raspberrypi-firmware driver will do that bit-twiddling in its own messages.
...
Quoted 6 lines
+static struct
platform_driverbcm2835_mbox_driver= { +
.driver = { + .name = "bcm2835-mbox", + .owner =THIS_MODULE, + .of_match_table =bcm2835_mbox_of_match, +
}, + .probe =bcm2835_mbox_probe, + .remove =bcm2835_mbox_remove, +}; +module_platform_driver(bcm2835_mbox_driver);I have tested this driver and the firmware driver booting directly from the VideoCore bootloader (no uboot). The mailbox driver loads too late to turn on USB power:
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Yeah, I have a patch on my branches that returns -EPROBE_DEFER when trying to get a power domain and not finding the provider. It was rejected by the maintainers in favor of a proposed solution whose description I didn't quite follow.
Do you have a link for this thread?
That's really odd; -EPROBE_DEFER was clearly invented exactly to handle dependencies just like this. Playing with initcall levels simply isn't scalable, and in the main people are actively working not to use them for dependencies like this; they're far too implicit. While the timeout mentioned earlier in the thread might work (I didn't really look at the details), again it's far too indirect/accidental to be a good solution.
Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support
In reply to Alexander SteinDen 08.05.2015 10:33, skrev Alexander Stein:
Quoted 35 lines
On Thursday 07 May 2015, 12:54:20 wrote Eric Anholt:
Quoted 30 lines
Quoted 15 lines · Noralf Tr?nnes
Den 05.05.2015 22:27, skrev Eric Anholt:
Quoted 13 lines
From: Lubomir Rintel <[email protected]>
This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2 (despite being derived from the same firmware tree) doesn't.
The driver was originally submitted by Lubomir, based on the out-of-tree 2708 mailbox driver. Eric Anholt fixed it up for upstreaming, with the major functional change being that it now has no notion of multiple channels (since that is a firmware-dependent concept) and instead the raspberrypi-firmware driver will do that bit-twiddling in its own messages.
...
Quoted 13 lines
drivers/mailbox/bcm2835-mailbox.c line 213
Quoted 10 lines
drivers/mailbox/bcm2835-mailbox.c new file +10
-0+static struct platform_driver bcm2835_mbox_driver = { + .driver = { + .name ="bcm2835-mbox" , + .owner =THIS_MODULE , + .of_match_table = bcm2835_mbox_of_match, + }, + .probe = bcm2835_mbox_probe, + .remove = bcm2835_mbox_remove, +}; +module_platform_driver (bcm2835_mbox_driver);I have tested this driver and the firmware driver booting directly from the VideoCore bootloader (no uboot).
The mailbox driver loads too late to turn on USB power:Quoted 4 lines
Yeah, I have a patch on my branches that returns -EPROBE_DEFER when trying to get a power domain and not finding the provider. It was rejected by the maintainers in favor of a proposed solution whose description I didn't quite follow.
Quoted 8 lines
Do you have a link for this thread?
Quoted 5 lines
Quoted 4 lines
This silences the warning:
struct raspberrypi_power_domain raspberrypi_power_domain_usb = { .base = { .power_on_latency_ns = 600000000,Oh, nice. Thanks!
Well, Using a timeout for dependencies seems odd to me.
I can only find one place where power_on_latency_ns is set, arch/arm/mach-imx/gpc.c:
static struct pu_domain imx6q_pu_domain = {
.base = {
.name = "PU",
.power_off = imx6q_pm_pu_power_off,
.power_on = imx6q_pm_pu_power_on,
.power_off_latency_ns = 25000,
.power_on_latency_ns = 2000000,
},
};power_on_latency_ns is not set by the core, so it defaults to zero. So in the default case, genpd_power_on() will always issue a warning on the first power on.
I would say that power_on_latency_ns is a characteristic of the power domain, like enable_time for regulators.
Noralf.
Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support
In reply to Eric AnholtDen 05.05.2015 22:27, skrev Eric Anholt:
Quoted 20 lines
From: Lubomir Rintel <[email protected]>
This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2 (despite being derived from the same firmware tree) doesn't.
The driver was originally submitted by Lubomir, based on the out-of-tree 2708 mailbox driver. Eric Anholt fixed it up for upstreaming, with the major functional change being that it now has no notion of multiple channels (since that is a firmware-dependent concept) and instead the raspberrypi-firmware driver will do that bit-twiddling in its own messages.
Signed-off-by Lubomir Rintel <[email protected]>Signed-off-by Craig McGeachie <[email protected]>Signed-off-by Eric Anholt <[email protected]>Cc Jassi Brar <[email protected]>Acked-by Stephen Warren <[email protected]>---
[...]
Quoted 1 line
drivers/mailbox/bcm2835-mailbox.c +0
-0
[...]
drivers/mailbox/bcm2835-mailbox.c line 121
Quoted 7 lines
drivers/mailbox/bcm2835-mailbox.c +7
-0+static bool bcm2835_last_tx_done (struct mbox_chan *link) +{ +struct bcm2835_mbox *mbox =bcm2835_link_mbox (link); +bool ret; + +spin_lock (&mbox->lock); + ret = !(readl (mbox->regs +MAIL0_STA ) &ARM_MS_FULL );
I don't know how the mailbox framework uses this function, but MAIL0_STA might be wrong here.
Phil Elwell detected a bug in the downstream mailbox driver in the mbox_write function where it waits for space to be available in the FIFO. His observation:
With the VC reader blocked and the ARM writing, MAIL0_STA reads empty permanently while MAIL1_STA goes from empty (0x40000000) to non-empty (0x00000001-0x00000007) to full (0x80000008).
See:
https://github.com/raspberrypi/linux/commit/3018d8a0996ad2340ba1b3f473f705ef285b01b5
PATCH v2 3/3 ARM: bcm2835: Add the mailbox to the device tree
In reply to Eric Anholt---
v2: Update for #mbox-cells 0 change in the driver.
arch/arm/boot/dts/bcm2835.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm/boot/dts/bcm2835.dtsi +7 -0
@@ -61,6 +61,13 @@ reg = <0x7e104000 0x10>; }; + mailbox: mailbox at 7e00b800 { + compatible = "brcm,bcm2835-mbox"; + reg = <0x7e00b880 0x40>; + interrupts = <0 1>; + #mbox-cells = <0>; + }; + gpio: gpio at 7e200000 { compatible = "brcm,bcm2835-gpio"; reg = <0x7e200000 0xb4>;
Signature · 1 line
2.1.4
Lee Jones
AppliedRe: [PATCH 3/3 v2] ARM: bcm2835: Add the mailbox to the device tree
Quoted 9 lines · Eric Anholt
Signed-off-by Eric Anholt <[email protected]>Acked-by Lee Jones <[email protected]>Acked-by Stephen Warren <[email protected]>---
v2: Update for #mbox-cells 0 change in the driver.
arch/arm/boot/dts/bcm2835.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
Applied, thanks.
Quoted 18 lines
arch/arm/boot/dts/bcm2835.dtsi +7
-0@@ -61,6 +61,13 @@ reg = <0x7e104000 0x10>; }; + mailbox: mailbox at 7e00b800 { + compatible = "brcm,bcm2835-mbox"; + reg = <0x7e00b880 0x40>; + interrupts = <0 1>; + #mbox-cells = <0>; + }; + gpio: gpio at 7e200000 { compatible = "brcm,bcm2835-gpio"; reg = <0x7e200000 0xb4>;
Jassi Brar
maintainerQuoted 7 lines · Eric Anholt
From: Lubomir Rintel <[email protected]>
This patch was split out of Lubomir's original mailbox patch by Eric Anholt, and the required properties documentation and examples have been filled out more completely and updated for the driver being changed to expose a single channel.
Quoted 6 lines
Signed-off-by Lubomir Rintel <[email protected]>Signed-off-by Craig McGeachie <[email protected]>Signed-off-by Eric Anholt <[email protected]>Acked-by Lee Jones <[email protected]>Acked-by Stephen Warren <[email protected]>---
Thanks to the reviewers. Applied all 3 patches.
Thanks.
Quoted 8 lines · Jassi Brar
Quoted 7 lines · Eric Anholt
From: Lubomir Rintel <[email protected]>
This patch was split out of Lubomir's original mailbox patch by Eric Anholt, and the required properties documentation and examples have been filled out more completely and updated for the driver being changed to expose a single channel.
Quoted 7 lines
Quoted 6 lines
Signed-off-by Lubomir Rintel <[email protected]>Signed-off-by Craig McGeachie <[email protected]>Signed-off-by Eric Anholt <[email protected]>Acked-by Lee Jones <[email protected]>Acked-by Stephen Warren <[email protected]>---
Thanks to the reviewers. Applied all 3 patches.
Jassi, can you remove patch 3/3 from your tree please? Changes to DTS(I) files should go in via ARM-SoC. If SS Maintainers took DT changes, there would be carnage.
I'm going to apply it now.
Jassi Brar
maintainerQuoted 15 lines · Lee Jones
Quoted 14 lines · Jassi Brar
Quoted 13 lines · Eric Anholt
From: Lubomir Rintel <[email protected]>
This patch was split out of Lubomir's original mailbox patch by Eric Anholt, and the required properties documentation and examples have been filled out more completely and updated for the driver being changed to expose a single channel.
Signed-off-by Lubomir Rintel <[email protected]>Signed-off-by Craig McGeachie <[email protected]>Signed-off-by Eric Anholt <[email protected]>Acked-by Lee Jones <[email protected]>Acked-by Stephen Warren <[email protected]>---
Quoted 8 lines
Quoted 1 line
Thanks to the reviewers. Applied all 3 patches.
Jassi, can you remove patch 3/3 from your tree please? Changes to DTS(I) files should go in via ARM-SoC. If SS Maintainers took DT changes, there would be carnage.
I'm going to apply it now.
Done. Thanks for the heads up.