Skip to contentSkip to conversation

HID: i2c-hid: fix harmless test_bit() issue

PATCH Applied Dan Carpenter 3 participants 3 messages May 14, 2015 – May 18, 2015

Subsystems (2)
Kernel janitors HID
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 HID: i2c-hid: fix harmless test_bit() issue

These defines are used like this:

	if (test_bit(I2C_HID_STARTED, &ihid->flags))

The intent was to use bits 0, 1, and 2 but because of the extra shifts we're using bits 1, 2, and 4. It's harmless becuase it's done consistently but it's not the intent and static checkers will complain.

Fixes 4a200c3b9a40 ('HID: i2c-hid: introduce HID over i2c specification implementation')
Signed-off-by Dan Carpenter <[email protected]>
drivers/hid/i2c-hid/i2c-hid.c +3 -3
index 92d6cdf..cadec6a 100644
@@ -42,9 +42,9 @@
 #include <linux/i2c/i2c-hid.h>
 
 /* flags */
-#define I2C_HID_STARTED		(1 << 0)
-#define I2C_HID_RESET_PENDING	(1 << 1)
-#define I2C_HID_READ_PENDING	(1 << 2)
+#define I2C_HID_STARTED		0
+#define I2C_HID_RESET_PENDING	1
+#define I2C_HID_READ_PENDING	2
 
 #define I2C_HID_PWR_ON		0x00
 #define I2C_HID_PWR_SLEEP	0x01
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Dan Carpenter

These defines are used like this:

	if (test_bit(I2C_HID_STARTED, &ihid->flags))

The intent was to use bits 0, 1, and 2 but because of the extra shifts we're using bits 1, 2, and 4. It's harmless becuase it's done consistently but it's not the intent and static checkers will complain.

Fixes 4a200c3b9a40 ('HID: i2c-hid: introduce HID over i2c specification implementation')
Signed-off-by Dan Carpenter <[email protected]>

Same as the other one:

Oops. Looks good to me:

Reviewed-by Benjamin Tissoires <[email protected]>

Cheers,
Benjamin

Quoted 18 lines
drivers/hid/i2c-hid/i2c-hid.c +3 -3
index 92d6cdf..cadec6a 100644
@@ -42,9 +42,9 @@
 #include <linux/i2c/i2c-hid.h>
 
 /* flags */
-#define I2C_HID_STARTED		(1 << 0)
-#define I2C_HID_RESET_PENDING	(1 << 1)
-#define I2C_HID_READ_PENDING	(1 << 2)
+#define I2C_HID_STARTED		0
+#define I2C_HID_RESET_PENDING	1
+#define I2C_HID_READ_PENDING	2
 
 #define I2C_HID_PWR_ON		0x00
 #define I2C_HID_PWR_SLEEP	0x01
Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 10 lines · Dan Carpenter

These defines are used like this:

	if (test_bit(I2C_HID_STARTED, &ihid->flags))

The intent was to use bits 0, 1, and 2 but because of the extra shifts we're using bits 1, 2, and 4. It's harmless becuase it's done consistently but it's not the intent and static checkers will complain.

Fixes 4a200c3b9a40 ('HID: i2c-hid: introduce HID over i2c specification implementation')
Signed-off-by Dan Carpenter <[email protected]>

Applied to for-4.2/upstream, thanks Dan.

Signature · 2 lines
Jiri Kosina
SUSE Labs