Skip to contentSkip to conversation

Window watchdog driver design

DISCUSSION Andreas Werner 3 participants 9 messages May 14, 2015 – May 15, 2015 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

Hi,
in the next few weeks I need to write a driver for a window wachtdog implemented in a CPLD. I have some questions about the design of the driver and the best way to write this driver to also be able to submit it.

The triggering and configuration of the Watchdog is done by several GPIOs which are connected to the CPLD watchdog device. The correct GPIOs are configurable using the Device Tree.

1. Timeout
The timeout values are defined in ms and start from 20ms to 2560ms. The timout is set by 3 GPIOs this means we have only 8 different timout values. It is also possible that a future Watchdog CPLD device does have different timeout values.

Is it possible to set ms timeouts? It seems that the WDT API does only support a resolution of 1sec.

One idea would be to use the API timeout as something like a timeout index to set the different values. Of course this needs to be documented.

e.g.
timeout (API) timeout in device
1 20ms
2 100ms
3 500ms
... ...

2. Upper/Lower Window
There is currently no support for a windowed watchdog in the wdt core. The lower window can be activated by a gpio and its timeout is defined as "upper windows timeout/4"

What is the best way to implement those additional settings? Adding additional ioctl or export these in sysfs?

maintainer
#1 lore raw
Quoted 29 lines · Andreas Werner

Hi,
in the next few weeks I need to write a driver for a window wachtdog implemented in a CPLD. I have some questions about the design of the driver and the best way to write this driver to also be able to submit it.

The triggering and configuration of the Watchdog is done by several GPIOs which are connected to the CPLD watchdog device. The correct GPIOs are configurable using the Device Tree.

1. Timeout
The timeout values are defined in ms and start from 20ms to 2560ms. The timout is set by 3 GPIOs this means we have only 8 different timout values. It is also possible that a future Watchdog CPLD device does have different timeout values.

Is it possible to set ms timeouts? It seems that the WDT API does only support a resolution of 1sec.

One idea would be to use the API timeout as something like a timeout index to set the different values. Of course this needs to be documented.

e.g.
timeout (API) timeout in device
1 20ms
2 100ms
3 500ms
... ...

Quoted 8 lines

2. Upper/Lower Window
There is currently no support for a windowed watchdog in the wdt core. The lower window can be activated by a gpio and its timeout is defined as "upper windows timeout/4"

What is the best way to implement those additional settings? Adding additional ioctl or export these in sysfs?
--

Sorry for the maybe dumb question, but what is a window watchdog, and what is the lower window timeout for (assuming the upper window timeout causes the watchdog to expire) ?

Guenter

#2 lore raw
Quoted 39 lines · Guenter Roeck
Quoted 29 lines · Andreas Werner

Hi,
in the next few weeks I need to write a driver for a window wachtdog implemented in a CPLD. I have some questions about the design of the driver and the best way to write this driver to also be able to submit it.

The triggering and configuration of the Watchdog is done by several GPIOs which are connected to the CPLD watchdog device. The correct GPIOs are configurable using the Device Tree.

1. Timeout
The timeout values are defined in ms and start from 20ms to 2560ms. The timout is set by 3 GPIOs this means we have only 8 different timout values. It is also possible that a future Watchdog CPLD device does have different timeout values.

Is it possible to set ms timeouts? It seems that the WDT API does only support a resolution of 1sec.

One idea would be to use the API timeout as something like a timeout index to set the different values. Of course this needs to be documented.

e.g.
timeout (API) timeout in device
1 20ms
2 100ms
3 500ms
... ...

Quoted 8 lines

2. Upper/Lower Window
There is currently no support for a windowed watchdog in the wdt core. The lower window can be activated by a gpio and its timeout is defined as "upper windows timeout/4"

What is the best way to implement those additional settings? Adding additional ioctl or export these in sysfs?
--

Quoted 6 lines

Sorry for the maybe dumb question, but what is a window watchdog, and what is the lower window timeout for (assuming the upper window timeout causes the watchdog to expire) ?

Guenter

Oh sorry forgot to describe it in more detail.

If you have a watchdog window you do not have just one timeout where the watchdog can expire. You have a so called "window" to trigger it within.

		|<----trig---->|

---lower timeout----------------upper timeout

This means you have to trigger the watchdog not to late and not to early. This kind of watchdog is often used in embedded applications or more often in safety cases to fullfil requirements given e.g. by SIL1-SIL4 certifications.

The lower timeout is set by a dedicated GPIO and the value will then "Upper timeout / 4". The upper timeout is set by 3 GPIOs to get different timeout values.

If you have any further questions, to not hesitate to ask me.

Regards
Andy

maintainer
#3 lore raw
Quoted 53 lines · Andreas Werner
Quoted 39 lines · Guenter Roeck
Quoted 29 lines · Andreas Werner

Hi,
in the next few weeks I need to write a driver for a window wachtdog implemented in a CPLD. I have some questions about the design of the driver and the best way to write this driver to also be able to submit it.

The triggering and configuration of the Watchdog is done by several GPIOs which are connected to the CPLD watchdog device. The correct GPIOs are configurable using the Device Tree.

1. Timeout
The timeout values are defined in ms and start from 20ms to 2560ms. The timout is set by 3 GPIOs this means we have only 8 different timout values. It is also possible that a future Watchdog CPLD device does have different timeout values.

Is it possible to set ms timeouts? It seems that the WDT API does only support a resolution of 1sec.

One idea would be to use the API timeout as something like a timeout index to set the different values. Of course this needs to be documented.

e.g.
timeout (API) timeout in device
1 20ms
2 100ms
3 500ms
... ...

Quoted 8 lines

2. Upper/Lower Window
There is currently no support for a windowed watchdog in the wdt core. The lower window can be activated by a gpio and its timeout is defined as "upper windows timeout/4"

What is the best way to implement those additional settings? Adding additional ioctl or export these in sysfs?
--

Quoted 6 lines

Sorry for the maybe dumb question, but what is a window watchdog, and what is the lower window timeout for (assuming the upper window timeout causes the watchdog to expire) ?

Guenter

Oh sorry forgot to describe it in more detail.

If you have a watchdog window you do not have just one timeout where the watchdog can expire. You have a so called "window" to trigger it within.

		|<----trig---->|
Quoted 9 lines

---lower timeout----------------upper timeout

This means you have to trigger the watchdog not to late and not to early. This kind of watchdog is often used in embedded applications or more often in safety cases to fullfil requirements given e.g. by SIL1-SIL4 certifications.

The lower timeout is set by a dedicated GPIO and the value will then "Upper timeout / 4". The upper timeout is set by 3 GPIOs to get different timeout values.

Thanks a lot for the explanation.

I would suggest to use a module parameter to enable the "lower timeout" functionality.

Timeouts have to be specified in seconds.

Hope this helps,
Guenter

#4 lore raw
Quoted 64 lines · Guenter Roeck
Quoted 53 lines · Andreas Werner
Quoted 39 lines · Guenter Roeck
Quoted 29 lines · Andreas Werner

Hi,
in the next few weeks I need to write a driver for a window wachtdog implemented in a CPLD. I have some questions about the design of the driver and the best way to write this driver to also be able to submit it.

The triggering and configuration of the Watchdog is done by several GPIOs which are connected to the CPLD watchdog device. The correct GPIOs are configurable using the Device Tree.

1. Timeout
The timeout values are defined in ms and start from 20ms to 2560ms. The timout is set by 3 GPIOs this means we have only 8 different timout values. It is also possible that a future Watchdog CPLD device does have different timeout values.

Is it possible to set ms timeouts? It seems that the WDT API does only support a resolution of 1sec.

One idea would be to use the API timeout as something like a timeout index to set the different values. Of course this needs to be documented.

e.g.
timeout (API) timeout in device
1 20ms
2 100ms
3 500ms
... ...

Quoted 8 lines

2. Upper/Lower Window
There is currently no support for a windowed watchdog in the wdt core. The lower window can be activated by a gpio and its timeout is defined as "upper windows timeout/4"

What is the best way to implement those additional settings? Adding additional ioctl or export these in sysfs?
--

Quoted 6 lines

Sorry for the maybe dumb question, but what is a window watchdog, and what is the lower window timeout for (assuming the upper window timeout causes the watchdog to expire) ?

Guenter

Oh sorry forgot to describe it in more detail.

If you have a watchdog window you do not have just one timeout where the watchdog can expire. You have a so called "window" to trigger it within.

		|<----trig---->|
Quoted 9 lines

---lower timeout----------------upper timeout

This means you have to trigger the watchdog not to late and not to early. This kind of watchdog is often used in embedded applications or more often in safety cases to fullfil requirements given e.g. by SIL1-SIL4 certifications.

The lower timeout is set by a dedicated GPIO and the value will then "Upper timeout / 4". The upper timeout is set by 3 GPIOs to get different timeout values.

Quoted 9 lines

Thanks a lot for the explanation.

I would suggest to use a module parameter to enable the "lower timeout" functionality.

Timeouts have to be specified in seconds.

Hope this helps,
Guenter

Thanks for the answer.

The module parameter would be ok for me, but it would be better if i can enable/disable the lower window by the application.

I know that the API defines the timout in seconds but what about ms? Is there no watchdog out there which has timout values < seconds?.

In my case I can only set 2 timouts (1sec and 2sec) but I need to support all 8 timeout values.

The other thing is that my Watchdog can have differen timeout values depending on the CPLD and the customer requirements. I can not read out this values, they are only defined in the specification.

This is why i had the idea with the table to only set some "indexes" for the timout to handle all the cases.

Regards
Andy

maintainer
#5 lore raw
Quoted 71 lines · Andreas Werner
Quoted 70 lines · Guenter Roeck
Quoted 53 lines · Andreas Werner
Quoted 39 lines · Guenter Roeck
Quoted 29 lines · Andreas Werner

Hi,
in the next few weeks I need to write a driver for a window wachtdog implemented in a CPLD. I have some questions about the design of the driver and the best way to write this driver to also be able to submit it.

The triggering and configuration of the Watchdog is done by several GPIOs which are connected to the CPLD watchdog device. The correct GPIOs are configurable using the Device Tree.

1. Timeout
The timeout values are defined in ms and start from 20ms to 2560ms. The timout is set by 3 GPIOs this means we have only 8 different timout values. It is also possible that a future Watchdog CPLD device does have different timeout values.

Is it possible to set ms timeouts? It seems that the WDT API does only support a resolution of 1sec.

One idea would be to use the API timeout as something like a timeout index to set the different values. Of course this needs to be documented.

e.g.
timeout (API) timeout in device
1 20ms
2 100ms
3 500ms
... ...

Quoted 8 lines

2. Upper/Lower Window
There is currently no support for a windowed watchdog in the wdt core. The lower window can be activated by a gpio and its timeout is defined as "upper windows timeout/4"

What is the best way to implement those additional settings? Adding additional ioctl or export these in sysfs?
--

Quoted 6 lines

Sorry for the maybe dumb question, but what is a window watchdog, and what is the lower window timeout for (assuming the upper window timeout causes the watchdog to expire) ?

Guenter

Oh sorry forgot to describe it in more detail.

If you have a watchdog window you do not have just one timeout where the watchdog can expire. You have a so called "window" to trigger it within.

		|<----trig---->|
Quoted 9 lines

---lower timeout----------------upper timeout

This means you have to trigger the watchdog not to late and not to early. This kind of watchdog is often used in embedded applications or more often in safety cases to fullfil requirements given e.g. by SIL1-SIL4 certifications.

The lower timeout is set by a dedicated GPIO and the value will then "Upper timeout / 4". The upper timeout is set by 3 GPIOs to get different timeout values.

Thanks a lot for the explanation.

I would suggest to use a module parameter to enable the "lower timeout" functionality.

Timeouts have to be specified in seconds.

Quoted 9 lines
Quoted 3 lines

Hope this helps,
Guenter

Thanks for the answer.

The module parameter would be ok for me, but it would be better if i can enable/disable the lower window by the application.

You could try adding a sysfs attribute.

Quoted 3 lines

I know that the API defines the timout in seconds but what about ms? Is there no watchdog out there which has timout values < seconds?.

The ABI is the ABI, it has been there for a long time, and it only supports second intervals.

Quoted 3 lines

In my case I can only set 2 timouts (1sec and 2sec) but I need to support all 8 timeout values.

Kind of strict for a Linux watchdog. Most if not all other timeouts are much higher. The drivers for hardware with low maximum timeout values often implement a two-stage timeout, one handled in the driver that pings the actual hardware timeout, and a soft-timeout to be triggered from user space with a more relaxed timing.

Quoted 4 lines

The other thing is that my Watchdog can have differen timeout values depending on the CPLD and the customer requirements. I can not read out this values, they are only defined in the specification.

Normally you'd expect such platform specific details to be configured via devicetree or platform data if that is not available (or ACPI, of course).

The userspace/kernel ABI/API needs to be standardized, so that user space doesn't need to know implementation details.

Quoted 3 lines

This is why i had the idea with the table to only set some "indexes" for the timout to handle all the cases.

Such an "index" would not be a well defined number. A standard application, such as watchdogd or systemd, would not know what to do with it.

After all, the common use case of a watchdog driver is for it to interface with a standard userspace application, so its interface to userspace needs to be well defined. We can not permit "wildcards" such as redefining the meaning of a time interval from seconds to something driver-specific; that would break all kinds of applications.

Guenter

#6 lore raw
Quoted 76 lines · Guenter Roeck
Quoted 75 lines · Andreas Werner
Quoted 73 lines · Guenter Roeck
Quoted 53 lines · Andreas Werner
Quoted 39 lines · Guenter Roeck
Quoted 29 lines · Andreas Werner

Hi,
in the next few weeks I need to write a driver for a window wachtdog implemented in a CPLD. I have some questions about the design of the driver and the best way to write this driver to also be able to submit it.

The triggering and configuration of the Watchdog is done by several GPIOs which are connected to the CPLD watchdog device. The correct GPIOs are configurable using the Device Tree.

1. Timeout
The timeout values are defined in ms and start from 20ms to 2560ms. The timout is set by 3 GPIOs this means we have only 8 different timout values. It is also possible that a future Watchdog CPLD device does have different timeout values.

Is it possible to set ms timeouts? It seems that the WDT API does only support a resolution of 1sec.

One idea would be to use the API timeout as something like a timeout index to set the different values. Of course this needs to be documented.

e.g.
timeout (API) timeout in device
1 20ms
2 100ms
3 500ms
... ...

Quoted 8 lines

2. Upper/Lower Window
There is currently no support for a windowed watchdog in the wdt core. The lower window can be activated by a gpio and its timeout is defined as "upper windows timeout/4"

What is the best way to implement those additional settings? Adding additional ioctl or export these in sysfs?
--

Quoted 6 lines

Sorry for the maybe dumb question, but what is a window watchdog, and what is the lower window timeout for (assuming the upper window timeout causes the watchdog to expire) ?

Guenter

Oh sorry forgot to describe it in more detail.

If you have a watchdog window you do not have just one timeout where the watchdog can expire. You have a so called "window" to trigger it within.

		|<----trig---->|
Quoted 9 lines

---lower timeout----------------upper timeout

This means you have to trigger the watchdog not to late and not to early. This kind of watchdog is often used in embedded applications or more often in safety cases to fullfil requirements given e.g. by SIL1-SIL4 certifications.

The lower timeout is set by a dedicated GPIO and the value will then "Upper timeout / 4". The upper timeout is set by 3 GPIOs to get different timeout values.

Thanks a lot for the explanation.

I would suggest to use a module parameter to enable the "lower timeout" functionality.

Timeouts have to be specified in seconds.

Hope this helps,
Guenter

Quoted 6 lines
Quoted 5 lines

Thanks for the answer.

The module parameter would be ok for me, but it would be better if i can enable/disable the lower window by the application.

You could try adding a sysfs attribute.

Yes that would be the best solution for that. Module Parameter would be also ok because normally you just want to enable the lower timeout or not but if you can do this in the application this would be the best.

Quoted 7 lines
Quoted 4 lines

I know that the API defines the timout in seconds but what about ms? Is there no watchdog out there which has timout values < seconds?.

The ABI is the ABI, it has been there for a long time, and it only supports second intervals.

Yes of course I'm with you.

Quoted 9 lines
Quoted 3 lines

In my case I can only set 2 timouts (1sec and 2sec) but I need to support all 8 timeout values.

Kind of strict for a Linux watchdog. Most if not all other timeouts are much higher. The drivers for hardware with low maximum timeout values often implement a two-stage timeout, one handled in the driver that pings the actual hardware timeout, and a soft-timeout to be triggered from user space with a more relaxed timing.

Yes I've seen such kind of a watchdog but this is not possible for my design. The watchdog must be used by the application because the application shall be monitored and not the whole system/kernel.

Quoted 10 lines
Quoted 4 lines

The other thing is that my Watchdog can have differen timeout values depending on the CPLD and the customer requirements. I can not read out this values, they are only defined in the specification.

Normally you'd expect such platform specific details to be configured via devicetree or platform data if that is not available (or ACPI, of course).

The userspace/kernel ABI/API needs to be standardized, so that user space doesn't need to know implementation details.

Yes you are right, that should be no problem.

Quoted 12 lines
Quoted 3 lines

This is why i had the idea with the table to only set some "indexes" for the timout to handle all the cases.

Such an "index" would not be a well defined number. A standard application, such as watchdogd or systemd, would not know what to do with it.

After all, the common use case of a watchdog driver is for it to interface with a standard userspace application, so its interface to userspace needs to be well defined. We can not permit "wildcards" such as redefining the meaning of a time interval from seconds to something driver-specific; that would break all kinds of applications.

Yes, i just wanted to discuss about it what possiblity I/we have to design a proper driver.

But it seems that this CPLD/Watchdog design is too specific to be also able to get it upstream. I think I need to define my own ABI for this special watchdog to get all the requirements full filled.

Quoted 2 lines

Guenter

Thanks a lot for discussing :-)

Regards
Andy

#7 lore raw
In reply to Guenter Roeck
Quoted 114 lines · Guenter Roeck
Quoted 71 lines · Andreas Werner
Quoted 70 lines · Guenter Roeck
Quoted 53 lines · Andreas Werner
Quoted 39 lines · Guenter Roeck
Quoted 29 lines · Andreas Werner

Hi,
in the next few weeks I need to write a driver for a window wachtdog implemented in a CPLD. I have some questions about the design of the driver and the best way to write this driver to also be able to submit it.

The triggering and configuration of the Watchdog is done by several GPIOs which are connected to the CPLD watchdog device. The correct GPIOs are configurable using the Device Tree.

1. Timeout
The timeout values are defined in ms and start from 20ms to 2560ms. The timout is set by 3 GPIOs this means we have only 8 different timout values. It is also possible that a future Watchdog CPLD device does have different timeout values.

Is it possible to set ms timeouts? It seems that the WDT API does only support a resolution of 1sec.

One idea would be to use the API timeout as something like a timeout index to set the different values. Of course this needs to be documented.

e.g.
timeout (API) timeout in device
1 20ms
2 100ms
3 500ms
... ...

Quoted 8 lines

2. Upper/Lower Window
There is currently no support for a windowed watchdog in the wdt core. The lower window can be activated by a gpio and its timeout is defined as "upper windows timeout/4"

What is the best way to implement those additional settings? Adding additional ioctl or export these in sysfs?
--

Quoted 6 lines

Sorry for the maybe dumb question, but what is a window watchdog, and what is the lower window timeout for (assuming the upper window timeout causes the watchdog to expire) ?

Guenter

Oh sorry forgot to describe it in more detail.

If you have a watchdog window you do not have just one timeout where the watchdog can expire. You have a so called "window" to trigger it within.

		|<----trig---->|
Quoted 9 lines

---lower timeout----------------upper timeout

This means you have to trigger the watchdog not to late and not to early. This kind of watchdog is often used in embedded applications or more often in safety cases to fullfil requirements given e.g. by SIL1-SIL4 certifications.

The lower timeout is set by a dedicated GPIO and the value will then "Upper timeout / 4". The upper timeout is set by 3 GPIOs to get different timeout values.

Thanks a lot for the explanation.

I would suggest to use a module parameter to enable the "lower timeout" functionality.

Timeouts have to be specified in seconds.

Quoted 9 lines
Quoted 3 lines

Hope this helps,
Guenter

Thanks for the answer.

The module parameter would be ok for me, but it would be better if i can enable/disable the lower window by the application.

You could try adding a sysfs attribute.

Quoted 3 lines

I know that the API defines the timout in seconds but what about ms? Is there no watchdog out there which has timout values < seconds?.

The ABI is the ABI, it has been there for a long time, and it only supports second intervals.

Quoted 3 lines

In my case I can only set 2 timouts (1sec and 2sec) but I need to support all 8 timeout values.

Kind of strict for a Linux watchdog. Most if not all other timeouts are much higher. The drivers for hardware with low maximum timeout values often implement a two-stage timeout, one handled in the driver that pings the actual hardware timeout, and a soft-timeout to be triggered from user space with a more relaxed timing.

Quoted 4 lines

The other thing is that my Watchdog can have differen timeout values depending on the CPLD and the customer requirements. I can not read out this values, they are only defined in the specification.

Normally you'd expect such platform specific details to be configured via devicetree or platform data if that is not available (or ACPI, of course).

The userspace/kernel ABI/API needs to be standardized, so that user space doesn't need to know implementation details.

Quoted 3 lines

This is why i had the idea with the table to only set some "indexes" for the timout to handle all the cases.

Such an "index" would not be a well defined number. A standard application, such as watchdogd or systemd, would not know what to do with it.

Quoted 8 lines

After all, the common use case of a watchdog driver is for it to interface with a standard userspace application, so its interface to userspace needs to be well defined. We can not permit "wildcards" such as redefining the meaning of a time interval from seconds to something driver-specific; that would break all kinds of applications.

Guenter

I have one other idea which does not brake the "whole" WDT ABI and the interface to things like systemd.

The plan is to support the mandatory features like start,stop,ping through the ioctl this are the features which are checked by the watchdog core. If no min/max timeout values are set, the driver core would set it to 0.

With this features I can support e.g. systemd to start/stop and trigger the Watchdog with a default timeout value.

I would like to export all the other stuff (enable/disable lower window, set/get the time intervals) through sysfs.

Ok i would just break one have of the ABI (set/get timeout) but not the whole one by redefining the timeout.

Of course the sysfs attributes needs to be documented for this device and yes this is not a generic interface or abstartion and I think this could be the problem for upstreaming this. I think this is the way I will go regardless if it is possible to get it into the kernel or not.

What do you think about it?

Regards
Andy

#8 lore raw
In reply to Andreas Werner

Hi Andy,

Quoted 75 lines · Andreas Werner
Quoted 64 lines · Guenter Roeck
Quoted 53 lines · Andreas Werner
Quoted 39 lines · Guenter Roeck
Quoted 29 lines · Andreas Werner

Hi,
in the next few weeks I need to write a driver for a window wachtdog implemented in a CPLD. I have some questions about the design of the driver and the best way to write this driver to also be able to submit it.

The triggering and configuration of the Watchdog is done by several GPIOs which are connected to the CPLD watchdog device. The correct GPIOs are configurable using the Device Tree.

1. Timeout
The timeout values are defined in ms and start from 20ms to 2560ms. The timout is set by 3 GPIOs this means we have only 8 different timout values. It is also possible that a future Watchdog CPLD device does have different timeout values.

Is it possible to set ms timeouts? It seems that the WDT API does only support a resolution of 1sec.

One idea would be to use the API timeout as something like a timeout index to set the different values. Of course this needs to be documented.

e.g.
timeout (API) timeout in device
1 20ms
2 100ms
3 500ms
... ...

Quoted 8 lines

2. Upper/Lower Window
There is currently no support for a windowed watchdog in the wdt core. The lower window can be activated by a gpio and its timeout is defined as "upper windows timeout/4"

What is the best way to implement those additional settings? Adding additional ioctl or export these in sysfs?
--

Quoted 6 lines

Sorry for the maybe dumb question, but what is a window watchdog, and what is the lower window timeout for (assuming the upper window timeout causes the watchdog to expire) ?

Guenter

Oh sorry forgot to describe it in more detail.

If you have a watchdog window you do not have just one timeout where the watchdog can expire. You have a so called "window" to trigger it within.

		|<----trig---->|
Quoted 9 lines

---lower timeout----------------upper timeout

This means you have to trigger the watchdog not to late and not to early. This kind of watchdog is often used in embedded applications or more often in safety cases to fullfil requirements given e.g. by SIL1-SIL4 certifications.

The lower timeout is set by a dedicated GPIO and the value will then "Upper timeout / 4". The upper timeout is set by 3 GPIOs to get different timeout values.

Quoted 9 lines

Thanks a lot for the explanation.

I would suggest to use a module parameter to enable the "lower timeout" functionality.

Timeouts have to be specified in seconds.

Hope this helps,
Guenter

Quoted 7 lines

Thanks for the answer.

The module parameter would be ok for me, but it would be better if i can enable/disable the lower window by the application.

I know that the API defines the timout in seconds but what about ms? Is there no watchdog out there which has timout values < seconds?.

There are a few. But the user space api specifies the timeout in seconds so you can't really do anything about it as long as you wish to remain compatible with the current watchdog API.

I am working on extending the kernel watchdog core api so that the driver would fill in hw_max_timeout parameter that tells the core the maximum supported timeout in HW. I was thinking that millisecond resolution would be good for this.

Also there are already at least one watchdog driver (Atmel's at91sam9_wdt.c) that has already concept of "minimum watchdog timeout" in a sense that pinging the watchdog too often is considered to be a failure. This is also something that is not handled with the current watchdog api at all.

As I am working on changing the core so that it takes over more of the generic watchdog behaviour and work around watchdog hardware constraints so that user space does not need to know about them, I am interested in hearing opinions about how I should care this kind of constraints. Right now I am not trying to "fix" an user space daemon behaviour where the daemon is pinging more often than what is allowed by the hardware. I don't know if that is something what the watchdog core should be doing or not. I can't think why it would be bad if watchdog daemon pings the hardware too often and why it should be considered as a failure. Therefore I can't think where one should think the failure to be in such case.

Right now I am assuming that kernel should not try to be clever about minimum ping interval at all. But as there clearly are hardware that has this kind of window definition, I'm sure there should be some kind of software support for it too. I'm open to hear more about it.

-Timo

Quoted 18 lines

In my case I can only set 2 timouts (1sec and 2sec) but I need to support all 8 timeout values.

The other thing is that my Watchdog can have differen timeout values depending on the CPLD and the customer requirements. I can not read out this values, they are only defined in the specification.

This is why i had the idea with the table to only set some "indexes" for the timout to handle all the cases.

Regards
Andy

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html