Skip to contentSkip to conversation

Fatal error: exception Failure("not supported")

Cocci Nicholas Mc Guire 4 participants 6 messages May 17, 2015

lore
Share & tools
lore
#0 lore raw

Hi !

Writing some simple checks for user-space sample code to check that a read loop has some error checking in it - the read loop should look something like this:

        do {
                len = read(fd, buff + off, BUFFSIZE);
                if (len < 0 && len != -EAGAIN) {
                        perror("read failed");
                        exit(-1);
                }
                off += len;
        } while (len > 0);

to check this the following cocci spatch was intended

<snip>
virtual report
virtual org

@check_open@
identifier f,retval;
idexpression int fd;
idexpression int l;
idexpression int o;
idexpression char * b;
position p;
@@

f(...) {
<+...
do {
...
l = read@p(fd,b+o,...);
if (l < 0 && l != -EAGAIN) {
? perror(...);
(
exit(...);
|
return ...;
)
}
l = l + o;
} while ( l > 0);
return retval;
...+>
}

@script: python@
p<<check_open.p;
fn<<check_open.f;
@@
print "OK: read loop in %s:%s line %s checking errors" % (p[0].file,fn, p[0].line) <snip>

spatch --parse-cocci gives no errors and the output looks fine (just the iso expansions basically) - but when run with:
spatch --sp-file check_read_loop.cocci open_read_ok.c
its giving me:
init_defs_builtins: /usr/local/share/coccinelle/standard.h Fatal error: exception Failure("not supported")

how can I figure out what is "not supported" here ?

thx!
hofrat

#1 lore raw

Hi Nicholas,

Nicholas Mc Guire (2015/05/17 08:18 +0200):

Quoted 7 lines

Hi !

Writing some simple checks for user-space sample code to check that a read loop has some error checking in it - the read loop should look something like this:

Quoted 8 lines
        do {
                len = read(fd, buff + off, BUFFSIZE);
                if (len < 0 && len != -EAGAIN) {
                        perror("read failed");
                        exit(-1);
                }
                off += len;
        } while (len > 0);

I know it is not relevant for your problem, but the last argumentof the read system call looks suspiscious to me. I'd rather write BUFFSIZE-of but perhaps you wrote it that way just to simplify.

Quoted 42 lines

to check this the following cocci spatch was intended

<snip>
virtual report
virtual org

@check_open@
identifier f,retval;
idexpression int fd;
idexpression int l;
idexpression int o;
idexpression char * b;
position p;
@@

f(...) {
<+...
do {
...
l = read at p(fd,b+o,...);
if (l < 0 && l != -EAGAIN) {
? perror(...);
(
exit(...);
|
return ...;
)
}
l = l + o;
} while ( l > 0);
return retval;
...+>
}

@script: python@
p<<check_open.p;
fn<<check_open.f;
@@
print "OK: read loop in %s:%s line %s checking errors" % (p[0].file,fn, p[0].line) <snip>

Quoted 8 lines

spatch --parse-cocci gives no errors and the output looks fine (just the iso expansions basically) - but when run with:
spatch --sp-file check_read_loop.cocci open_read_ok.c
its giving me:
init_defs_builtins: /usr/local/share/coccinelle/standard.h Fatal error: exception Failure("not supported")

how can I figure out what is "not supported" here ?

just try this:

export OCAMLRUNPARAM=b
And then re-run the spatch that caused the exception. You should get a backtrace that you can post here.

In case you do not get it, it will probably mean that you have compiled a native-code version of coccinelle. We will have to get a byte-code one to be able to have a backtrace.

And by the way, do you really need <+... and ...+> ? Wouldn't two mere ... be enough?

hth,
S?bastien.

#2 lore raw

do while is not supported. Sorry.

julia

Quoted 94 lines · S?bastien Hinderer

Hi Nicholas,

Nicholas Mc Guire (2015/05/17 08:18 +0200):

Quoted 7 lines

Hi !

Writing some simple checks for user-space sample code to check that a read loop has some error checking in it - the read loop should look something like this:

Quoted 8 lines
        do {
                len = read(fd, buff + off, BUFFSIZE);
                if (len < 0 && len != -EAGAIN) {
                        perror("read failed");
                        exit(-1);
                }
                off += len;
        } while (len > 0);

I know it is not relevant for your problem, but the last argumentof the read system call looks suspiscious to me. I'd rather write BUFFSIZE-of but perhaps you wrote it that way just to simplify.

Quoted 42 lines

to check this the following cocci spatch was intended

<snip>
virtual report
virtual org

@check_open@
identifier f,retval;
idexpression int fd;
idexpression int l;
idexpression int o;
idexpression char * b;
position p;
@@

f(...) {
<+...
do {
...
l = read at p(fd,b+o,...);
if (l < 0 && l != -EAGAIN) {
? perror(...);
(
exit(...);
|
return ...;
)
}
l = l + o;
} while ( l > 0);
return retval;
...+>
}

@script: python@
p<<check_open.p;
fn<<check_open.f;
@@
print "OK: read loop in %s:%s line %s checking errors" % (p[0].file,fn, p[0].line) <snip>

Quoted 8 lines

spatch --parse-cocci gives no errors and the output looks fine (just the iso expansions basically) - but when run with:
spatch --sp-file check_read_loop.cocci open_read_ok.c
its giving me:
init_defs_builtins: /usr/local/share/coccinelle/standard.h Fatal error: exception Failure("not supported")

how can I figure out what is "not supported" here ?

just try this:

export OCAMLRUNPARAM=b
And then re-run the spatch that caused the exception. You should get a backtrace that you can post here.

In case you do not get it, it will probably mean that you have compiled a native-code version of coccinelle. We will have to get a byte-code one to be able to have a backtrace.

And by the way, do you really need <+... and ...+> ? Wouldn't two mere ... be enough?

hth,
S?bastien.
_______________________________________________
Cocci mailing list
Cocci at systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

#3 lore raw
Quoted 2 lines · Julia Lawall

do while is not supported. Sorry.

interesting - did this just not get done or
is there a theoretical issue with do while constructs ?

thx!
hofrat

#4 lore raw
Quoted 7 lines · Nicholas Mc Guire
Quoted 2 lines · Julia Lawall

do while is not supported. Sorry.

interesting - did this just not get done or
is there a theoretical issue with do while constructs ?

It just never got done...

How about

* x = read at p(...)
... when != x < 0

      when != x > 0
      when != x == -C

* x = read at p(...)

julia