zmqpp: fix compilation with some toolchains
PATCH 1/1 zmqpp: fix compilation with some toolchains
Fixes:
http://autobuild.buildroot.net/results/d9ec39dc5829aac1b25bfea7484458fcebd68412/
add cstdlib header to ensure EXIT_FAILURE presence
Using some cross-compiling toolchains, EXIT_FAILURE is not always properly defined without this inclusion.
Patch is upstream:
https://github.com/zeromq/zmqpp/pull/109
--- package/zmqpp/0001-add-ctsdlib-header.patch | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 package/zmqpp/0001-add-ctsdlib-header.patch
package/zmqpp/0001-add-ctsdlib-header.patch new file +23 -0
@@ -0,0 +1,23 @@ +commit 57a27ccebdc2bc375267fcf0b82f5a66b20f86fa +Author: Lionel Orry <[email protected]> +Date: Fri May 15 14:13:22 2015 +0200 + + add cstdlib header to ensure EXIT_FAILURE presence + + Using some cross-compiling toolchains, EXIT_FAILURE is not always + properly defined without this inclusion. + + Signed-off-by: Lionel Orry <[email protected]> + +diff --git a/src/client/main.cpp b/src/client/main.cpp +index 082c06b..760f01a 100644 +--- a/src/client/main.cpp ++++ b/src/client/main.cpp +@@ -3,6 +3,7 @@ + * Author: @benjamg + */ + ++#include <cstdlib> + #include <array> + #include <iostream> + #include <tuple>
Signature · 1 line
2.1.0
PATCH 1/1 zmqpp: fix compilation with some toolchains
Dear Lionel Orry,
Quoted 8 lines · Lionel Orry
Fixes:
http://autobuild.buildroot.net/results/d9ec39dc5829aac1b25bfea7484458fcebd68412/add cstdlib header to ensure
EXIT_FAILUREpresenceUsing some cross-compiling toolchains,
EXIT_FAILUREis not always properly defined without this inclusion.
Quoted 8 lines
Patch is upstream:
https://github.com/zeromq/zmqpp/pull/109Signed-off-by Lionel Orry <[email protected]>--- package/zmqpp/0001-add-ctsdlib-header.patch | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 package/zmqpp/0001-add-ctsdlib-header.patch
I've applied your patch, but I've replaced the patch you included which was just the output of 'git show' or 'git log -p' by a patch properly formatted with 'git format-patch', so that it can be applied with 'git am'.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 zmqpp: fix compilation with some toolchains
Hi Thomas,
Quoted 20 lines · Thomas Petazzoni
Dear Lionel Orry,
Quoted 8 lines · Lionel Orry
Fixes:
http://autobuild.buildroot.net/results/d9ec39dc5829aac1b25bfea7484458fcebd68412/add cstdlib header to ensure
EXIT_FAILUREpresenceUsing some cross-compiling toolchains,
EXIT_FAILUREis not always properly defined without this inclusion.Quoted 8 lines
Patch is upstream:
https://github.com/zeromq/zmqpp/pull/109Signed-off-by Lionel Orry <[email protected]>--- package/zmqpp/0001-add-ctsdlib-header.patch | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 package/zmqpp/0001-add-ctsdlib-header.patch
Quoted 4 lines
I've applied your patch, but I've replaced the patch you included which was just the output of 'git show' or 'git log -p' by a patch properly formatted with 'git format-patch', so that it can be applied with 'git am'.
I did not know it was a preferred format, thanks for making that.
Maybe it could be interesting to give some more precisions about the
preferred package patches format in the manual, and how to prepare
them? cf. http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
(of course it depends on the upstream software SCM and the method used to make the patch...)
Quoted 8 lines
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
BR,
Lionel
PATCH 1/1 zmqpp: fix compilation with some toolchains
Lionel,
Quoted 9 lines · Lionel Orry
Quoted 4 lines
I've applied your patch, but I've replaced the patch you included which was just the output of 'git show' or 'git log -p' by a patch properly formatted with 'git format-patch', so that it can be applied with 'git am'.
I did not know it was a preferred format, thanks for making that.
Maybe it could be interesting to give some more precisions about the
preferred package patches format in the manual, and how to prepare
them? cf. http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
Sure, feel free to send patches to the Buildroot documentation!
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com