Skip to contentSkip to conversation

V4L/DVB (6059): ivtv: log stereo/bilingual audio modes

DISCUSSION Dan Carpenter 1 participant 1 message May 18, 2015 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hello Hans Verkuil,

The patch 25e3f8f40ecf: "V4L/DVB (6059): ivtv: log stereo/bilingual audio modes" from Aug 19, 2007, leads to the following static checker warning:

	drivers/media/pci/ivtv/ivtv-ioctl.c:1533 ivtv_log_status()
	warn: masked condition is always false. '(itv->dualwatch_stereo_mode & ~768) == 512'

drivers/media/pci/ivtv/ivtv-ioctl.c

  1529          ivtv_call_all(itv, core, log_status);
  1530          ivtv_get_input(itv, itv->active_input, &vidin);
  1531          ivtv_get_audio_input(itv, itv->audio_input, &audin);
  1532          IVTV_INFO("Video Input:  %s\n", vidin.name);
  1533          IVTV_INFO("Audio Input:  %s%s\n", audin.name,
  1534                  (itv->dualwatch_stereo_mode & ~0x300) == 0x200 ? " (Bilingual)" : "");
                                                      ^

Probably this bitwise NOT is a typo? In other words:

			(itv->dualwatch_stereo_mode & 0x300) == 0x200 ? " (Bilingual)" : "");
  1535          if (has_output) {

regards,
dan carpenter