Skip to contentSkip to conversation

stable fix for IOSF in Kconfig

DISCUSSION William Dauchy 3 participants 9 messages May 20, 2015 – Jul 9, 2015 Stable branch

lore
Share & tools
lore
#0 lore raw

Hello,

Using a stable 3.14.x kernel, I had an issue where I was unable to set IOSF_MBI as builtin.

I applied the following commit on top of my 3.14.x:

commit aa8e4f22ab7773352ba3895597189b8097f2c307
Author: David E. Box <[email protected]>
Date: Wed Aug 27 14:40:39 2014 -0700
x86/iosf: Add Kconfig prompt for IOSF_MBI selection

This fixes my issue.
Do you think it's a good candidate for stable branches?

we may also consider the following commit for stable:
commit ced3ce760b8df08e8bafba44f6b40407df2d0402
Author: David E. Box <[email protected]>
Date: Wed Sep 17 22:13:50 2014 -0700
x86/platform/intel/iosf: Add better description of IOSF driver in config

Regards,

Signature · 1 line
William
#1 lore raw
Quoted 7 lines · William Dauchy

Hello,

Using a stable 3.14.x kernel, I had an issue where I was unable to set IOSF_MBI as builtin.

I applied the following commit on top of my 3.14.x:

Quoted 7 lines

commit aa8e4f22ab7773352ba3895597189b8097f2c307
Author: David E. Box <[email protected]>
Date: Wed Aug 27 14:40:39 2014 -0700
x86/iosf: Add Kconfig prompt for IOSF_MBI selection

This fixes my issue.
Do you think it's a good candidate for stable branches?

Yes, that makes sense, I'll queue it up soon.

Quoted 5 lines

we may also consider the following commit for stable:
commit ced3ce760b8df08e8bafba44f6b40407df2d0402
Author: David E. Box <[email protected]>
Date: Wed Sep 17 22:13:50 2014 -0700
x86/platform/intel/iosf: Add better description of IOSF driver in config

Does this fix a problem? I don't mind it, but is it really needed?

thanks,

greg k-h

#2 lore raw

Hi Greg,

Thanks for your reply.

Quoted 7 lines · Greg KH
Quoted 5 lines

we may also consider the following commit for stable:
commit ced3ce760b8df08e8bafba44f6b40407df2d0402
Author: David E. Box <[email protected]>
Date: Wed Sep 17 22:13:50 2014 -0700
x86/platform/intel/iosf: Add better description of IOSF driver in config

Does this fix a problem? I don't mind it, but is it really needed?

as you may have seen in full commit message, it's just an improvement of the previous commit, but it does not change anything for my particular issue at the end; I was just suggesting (i.e not showing the entry in the main menu)

Best regards,

Signature · 1 line
William
#3 lore raw
Quoted 11 lines · William Dauchy

Hi Greg,

Thanks for your reply.

Quoted 6 lines · Greg KH
Quoted 5 lines

we may also consider the following commit for stable:
commit ced3ce760b8df08e8bafba44f6b40407df2d0402
Author: David E. Box <[email protected]>
Date: Wed Sep 17 22:13:50 2014 -0700
x86/platform/intel/iosf: Add better description of IOSF driver in config

Quoted 6 lines
Quoted 1 line

Does this fix a problem? I don't mind it, but is it really needed?

as you may have seen in full commit message, it's just an improvement of the previous commit, but it does not change anything for my particular issue at the end; I was just suggesting (i.e not showing the entry in the main menu)

As it doesn't fix a real bug, I'll not apply it, thanks.

See Documentation/stable_kernel_rules.txt for the details as to what makes up a valid stable kernel patch.

greg k-h

#4 lore raw
Quoted 1 line · Greg KH

As it doesn't fix a real bug, I'll not apply it, thanks.

agreed; but the first one is targeted for future stables releases, right?

Thanks,

Signature · 1 line
William
#5 lore raw
Quoted 5 lines · William Dauchy
Quoted 1 line · Greg KH

As it doesn't fix a real bug, I'll not apply it, thanks.

agreed; but the first one is targeted for future stables releases, right?

The first "what"? There is no context here :(

#6 lore raw
Quoted 8 lines · Greg KH
Quoted 5 lines · William Dauchy
Quoted 1 line · Greg KH

As it doesn't fix a real bug, I'll not apply it, thanks.

agreed; but the first one is targeted for future stables releases, right?

The first "what"? There is no context here :(

sorry: http://www.spinics.net/lists/stable/msg91732.html
"Yes, that makes sense, I'll queue it up soon." Wed, 20 May 2015 but since then I did not saw it yet.

Quoted 4 lines

commit aa8e4f22ab7773352ba3895597189b8097f2c307
Author: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
Date: Wed Aug 27 14:40:39 2014 -0700
x86/iosf: Add Kconfig prompt for IOSF_MBI selection

Regards,

Signature · 1 line
William
#7 lore raw
Quoted 5 lines · William Dauchy
Quoted 4 lines · Greg KH
Quoted 3 lines · William Dauchy
Quoted 1 line · Greg KH

As it doesn't fix a real bug, I'll not apply it, thanks.

Quoted 13 lines
Quoted 4 lines
Quoted 2 lines

agreed; but the first one is targeted for future stables releases, right?

The first "what"? There is no context here :(

sorry: http://www.spinics.net/lists/stable/msg91732.html
"Yes, that makes sense, I'll queue it up soon." Wed, 20 May 2015 but since then I did not saw it yet.

Quoted 4 lines

commit aa8e4f22ab7773352ba3895597189b8097f2c307
Author: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
Date: Wed Aug 27 14:40:39 2014 -0700
x86/iosf: Add Kconfig prompt for IOSF_MBI selection

Ah, missed that somehow, sorry, now queued up.

greg k-h

#8 lore raw
In reply to William Dauchy
Quoted 5 lines · William Dauchy

Hello,

Using a stable 3.14.x kernel, I had an issue where I was unable to set IOSF_MBI as builtin.

Quoted 7 lines

I applied the following commit on top of my 3.14.x:

commit aa8e4f22ab7773352ba3895597189b8097f2c307
Author: David E. Box <[email protected]>
Date: Wed Aug 27 14:40:39 2014 -0700
x86/iosf: Add Kconfig prompt for IOSF_MBI selection

Thanks, I'm queuing this commit for the 3.16 kernel as well.

Cheers,
--
Lu�s

Quoted 14 lines

This fixes my issue.
Do you think it's a good candidate for stable branches?

we may also consider the following commit for stable:
commit ced3ce760b8df08e8bafba44f6b40407df2d0402
Author: David E. Box <[email protected]>
Date: Wed Sep 17 22:13:50 2014 -0700
x86/platform/intel/iosf: Add better description of IOSF driver in config

Regards,

Signature · 1 line
William