Skip to contentSkip to conversation

qt5base: remove never set QT5BASE_CONFIGURE_ENV

PATCH New Baruch Siach 2 participants 3 messages May 20, 2015

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 qt5base: remove never set QT5BASE_CONFIGURE_ENV

Since 1b54fbc925f4 (qt5base: fix postgresql plugin compile, 2015-02-19) QT5BASE_CONFIGURE_ENV is never set. Remove it.

Cc Peter Seiderer <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/qt5/qt5base/qt5base.mk | 1 -
 1 file changed, 1 deletion(-)
package/qt5/qt5base/qt5base.mk +0 -1
index 3de824f5424b..e2db5d1e029c 100644
@@ -174,7 +174,6 @@ define QT5BASE_CONFIGURE_CMDS
 		PKG_CONFIG_LIBDIR="$(STAGING_DIR)/usr/lib/pkgconfig" \
 		PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
 		MAKEFLAGS="$(MAKEFLAGS) -j$(PARALLEL_JOBS)" \
-		$(QT5BASE_CONFIGURE_ENV) \
 		./configure \
 		-v \
 		-prefix /usr \
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 1/1 qt5base: remove never set QT5BASE_CONFIGURE_ENV

Hi Buildroot list,

Quoted 5 lines · Baruch Siach

Since 1b54fbc925f4 (qt5base: fix postgresql plugin compile, 2015-02-19) QT5BASE_CONFIGURE_ENV is never set. Remove it.

Cc Peter Seiderer <[email protected]>
Signed-off-by Baruch Siach <[email protected]>

Adding Peter's Reviewed-by tag from the other email with a proper In-Reply-To header for patchwork:

Reviewed-by Peter Seiderer <[email protected]>

Thanks,
baruch

Quoted 16 lines
---
 package/qt5/qt5base/qt5base.mk | 1 -
 1 file changed, 1 deletion(-)
package/qt5/qt5base/qt5base.mk +0 -1
index 3de824f5424b..e2db5d1e029c 100644
@@ -174,7 +174,6 @@ define QT5BASE_CONFIGURE_CMDS
 		PKG_CONFIG_LIBDIR="$(STAGING_DIR)/usr/lib/pkgconfig" \
 		PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
 		MAKEFLAGS="$(MAKEFLAGS) -j$(PARALLEL_JOBS)" \
-		$(QT5BASE_CONFIGURE_ENV) \
 		./configure \
 		-v \
 		-prefix /usr \
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Applied
#2 lore raw

PATCH 1/1 qt5base: remove never set QT5BASE_CONFIGURE_ENV

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 8 lines · Baruch Siach

Since 1b54fbc925f4 (qt5base: fix postgresql plugin compile, 2015-02-19) QT5BASE_CONFIGURE_ENV is never set. Remove it.

Cc Peter Seiderer <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/qt5/qt5base/qt5base.mk | 1 -
 1 file changed, 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com