Skip to contentSkip to conversation

iproute2: disable xtables on static build

PATCH New Baruch Siach 3 participants 3 messages May 21, 2015

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 iproute2: disable xtables on static build

iproute2 always builds m_xt.so as a shared library.

Fixes:
http://autobuild.buildroot.net/results/f42/f42bbbf5be4594a8806d0e571586ce2bf119582d/
http://autobuild.buildroot.net/results/3b3/3b37871bdf5766677fc20dca22c13177091d104f/

Signed-off-by Baruch Siach <[email protected]>
---
 package/iproute2/iproute2.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/iproute2/iproute2.mk +2 -1
index 9595165ec6a5..3315d67c467c 100644
@@ -18,7 +18,7 @@ IPROUTE2_DEPENDENCIES += busybox
 endif
 
 # If we've got iptables enable xtables support for tc
-ifeq ($(BR2_PACKAGE_IPTABLES),y)
+ifeq ($(BR2_PACKAGE_IPTABLES)x$(BR2_STATIC_LIBS),yx)
 IPROUTE2_DEPENDENCIES += iptables
 define IPROUTE2_WITH_IPTABLES
 	# Makefile is busted so it never passes IPT_LIB_DIR properly

@@ -29,6 +29,7 @@ else
 define IPROUTE2_WITH_IPTABLES
 	# em_ipset needs xtables, but configure misdetects it
 	echo "TC_CONFIG_IPSET:=n" >>$(IPROUTE2_DIR)/Config
+	echo "TC_CONFIG_XT:=n" >>$(IPROUTE2_DIR)/Config
 endef
 endif
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 iproute2: disable xtables on static build

Dear Baruch Siach,

Quoted 10 lines · Baruch Siach

iproute2 always builds m_xt.so as a shared library.

Fixes:
http://autobuild.buildroot.net/results/f42/f42bbbf5be4594a8806d0e571586ce2bf119582d/
http://autobuild.buildroot.net/results/3b3/3b37871bdf5766677fc20dca22c13177091d104f/

Signed-off-by Baruch Siach <[email protected]>
---
 package/iproute2/iproute2.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

There was already a patch posted by Romain for the same issue,
http://patchwork.ozlabs.org/patch/473600/. Some discussion with Peter/Gustavo followed. Not clear what the conclusion was, though.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 iproute2: disable xtables on static build

In reply to Baruch Siach
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

iproute2 always builds m_xt.so as a shared library. Fixes:
http://autobuild.buildroot.net/results/f42/f42bbbf5be4594a8806d0e571586ce2bf119582d/
http://autobuild.buildroot.net/results/3b3/3b37871bdf5766677fc20dca22c13177091d104f/

Signed-off-by Baruch Siach <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard