Skip to contentSkip to conversation

package/sqlite: fix parallel build failures

PATCH New Yann E. MORIN 2 participants 4 messages May 20, 2015 – May 21, 2015

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 package/sqlite: fix parallel build failures

Fixes:

    http://autobuild.buildroot.org/results/aed/aed3690689b60844e3278626da3c3eb75f2a2586/
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/sqlite/0001-fix-parallel-build.patch | 22 ++++++++++++++++++++++
 package/sqlite/sqlite.mk                     |  3 +++
 2 files changed, 25 insertions(+)
 create mode 100644 package/sqlite/0001-fix-parallel-build.patch
package/sqlite/0001-fix-parallel-build.patch new file +22 -0
new file mode 100644
index 0000000..79d80fb
@@ -0,0 +1,22 @@
+Use correct dependency in Makefile.am
+
+Depending on a libtool library should be done using the .la name, not on
+the object file.
+
+Fixes hard-to-reproduce parallel build failures, like so:
+    http://autobuild.buildroot.org/results/aed/aed3690689b60844e3278626da3c3eb75f2a2586/build-end.log
+
+Signed-off-by: "Yann E. MORIN" <[email protected]>
+
+diff -durN sqlite-3081000.orig/Makefile.am sqlite-3081000/Makefile.am
+--- sqlite-3081000.orig/Makefile.am	2015-05-07 16:59:22.000000000 +0200
++++ sqlite-3081000/Makefile.am	2015-05-20 23:30:03.878784079 +0200
+@@ -7,7 +7,7 @@
+ 
+ bin_PROGRAMS = sqlite3
+ sqlite3_SOURCES = shell.c sqlite3.h
+-sqlite3_LDADD = sqlite3.$(OBJEXT) @READLINE_LIBS@
++sqlite3_LDADD = libsqlite3.la @READLINE_LIBS@
+ 
+ include_HEADERS = sqlite3.h sqlite3ext.h
+
package/sqlite/sqlite.mk +3 -0
index fff219a..b2283f0 100644
@@ -10,6 +10,9 @@ SQLITE_SITE = http://www.sqlite.org/2015
 SQLITE_LICENSE = Public domain
 SQLITE_INSTALL_STAGING = YES
 
+# Patching Makefile.am:
+SQLITE_AUTORECONF = YES
+
 ifeq ($(BR2_PACKAGE_SQLITE_STAT3),y)
 SQLITE_CFLAGS += -DSQLITE_ENABLE_STAT3
 endif
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/sqlite: fix parallel build failures

Dear Yann E. MORIN,

Quoted 9 lines · Yann E. MORIN

Fixes:

    http://autobuild.buildroot.org/results/aed/aed3690689b60844e3278626da3c3eb75f2a2586/
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/sqlite/0001-fix-parallel-build.patch | 22 ++++++++++++++++++++++
 package/sqlite/sqlite.mk                     |  3 +++
 2 files changed, 25 insertions(+)
 create mode 100644 package/sqlite/0001-fix-parallel-build.patch

Applied, thanks. I guess you've submitted this patch upstream, right?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 package/sqlite: fix parallel build failures

Thomas, All,

On 2015-05-21 12:07 +0200, Thomas Petazzoni spake thusly:

Quoted 12 lines · Yann E. MORIN
Quoted 9 lines

Fixes:

    http://autobuild.buildroot.org/results/aed/aed3690689b60844e3278626da3c3eb75f2a2586/
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/sqlite/0001-fix-parallel-build.patch | 22 ++++++++++++++++++++++
 package/sqlite/sqlite.mk                     |  3 +++
 2 files changed, 25 insertions(+)
 create mode 100644 package/sqlite/0001-fix-parallel-build.patch

Applied, thanks. I guess you've submitted this patch upstream, right?

TLD;DR: no.

Full story:

- sqlite uses fossil as its VCS;

- cloning a fossil repo creates a single file (the DB) in the current

    directory;

- "checking out" the repository is also done in the curent directory,

    polluting it;

- there is no "fossil log" command;

- the content of the fossil repository is clearly not aligned with

    that of the tarball;

- there is autostuff in the repository, but it is in a sub-dorectory, and there is no explanation on how to use it; there is no explanation on how to generate the archive from the repository;

- the mailing list are not very newbie-friendly: they are subscription-only (OK) but even the archives require subscription to be browsed (not OK).

So, in the end, I just threw in the towel...

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/sqlite: fix parallel build failures

Dear Yann E. MORIN,

Quoted 19 lines · Yann E. MORIN

Full story:

- sqlite uses fossil as its VCS;

- cloning a fossil repo creates a single file (the DB) in the current

    directory;

- "checking out" the repository is also done in the curent directory,

    polluting it;

- there is no "fossil log" command;

- the content of the fossil repository is clearly not aligned with

    that of the tarball;

- there is autostuff in the repository, but it is in a sub-dorectory, and there is no explanation on how to use it; there is no explanation on how to generate the archive from the repository;

Quoted 5 lines

- the mailing list are not very newbie-friendly: they are subscription-only (OK) but even the archives require subscription to be browsed (not OK).

So, in the end, I just threw in the towel...

Seems fun :)

Maybe you could just send a mail to the mailing list to report the bug, as suggested at https://www.sqlite.org/src/wiki?name=Bug+Reports ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com