Skip to contentSkip to conversation

New libtirpc vs fedfs-utils.

PATCH NeilBrown 2 participants 3 messages May 22, 2015 – May 25, 2015

Subsystems (2)
lore
Share & tools
lore

NeilBrown

author
#0 lore raw

Hi Chuck / Steve,

It seems that fedfs-utils doesn't build with the new libtirpc.

Specifically fedfsd requires symbols

svcauth_gss_set_svc_name
svcauth_gss_get_principal

but libtirpc doesn't expose them any longer - it never included them in .h files or provided documentation.

As far as I can tell fedfs-utils really does need these interfaces, there is no alternate.
Would it be appropriate to make them "official" with header and doco support?

A simple hack is:

src/libtirpc.map +2 -0
@@ -284,4 +284,6 @@ TIRPC_PRIVATE {
     __libc_clntudp_bufcreate;
   # private, but used by rpcbind:
     __svc_clean_idle; svc_auth_none; libtirpc_set_debug;
+  # private, but used by fedfsd:
+   svcauth_gss_set_svc_name; svcauth_gss_get_principal;
 };

but I suspect something better is really needed.

Are there other server-side routines that need to be exported?

Thanks,
NeilBrown

#1 lore raw

Hi Neil-

Quoted 8 lines · NeilBrown

Hi Chuck / Steve,

It seems that fedfs-utils doesn't build with the new libtirpc.

Specifically fedfsd requires symbols

Quoted 8 lines

svcauth_gss_set_svc_name
svcauth_gss_get_principal

but libtirpc doesn't expose them any longer - it never included them in .h files or provided documentation.

As far as I can tell fedfs-utils really does need these interfaces, there is no alternate.

fedfs-utils needs to be updated, now that the new rpc_gss API is merged into libtirpc, to use rpc_gss_set_svc_name(3t) and rpc_gss_getcred(3t). That’s on my to-do list.

In the meantime . . .

Quoted 1 line

Would it be appropriate to make them "official" with header and doco support?

A fix for this issue was proposed yesterday on libtirpc-devel.

Quoted 13 lines

A simple hack is:

src/libtirpc.map +2 -0
@@ -284,4 +284,6 @@ TIRPC_PRIVATE {
    __libc_clntudp_bufcreate;
  # private, but used by rpcbind:
    __svc_clean_idle; svc_auth_none; libtirpc_set_debug;
+  # private, but used by fedfsd:
+   svcauth_gss_set_svc_name; svcauth_gss_get_principal;
 };
Quoted 6 lines

but I suspect something better is really needed.

Are there other server-side routines that need to be exported?

Thanks,
NeilBrown

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

author
#2 lore raw
Quoted 26 lines · On Fri, 22 May 2015 10:25:20 -0400 Chuck Lever <[email protected]> wrote:

Hi Neil-

Quoted 8 lines · NeilBrown

Hi Chuck / Steve,

It seems that fedfs-utils doesn't build with the new libtirpc.

Specifically fedfsd requires symbols

Quoted 8 lines

svcauth_gss_set_svc_name
svcauth_gss_get_principal

but libtirpc doesn't expose them any longer - it never included them in .h files or provided documentation.

As far as I can tell fedfs-utils really does need these interfaces, there is no alternate.

fedfs-utils needs to be updated, now that the new rpc_gss API is merged into libtirpc, to use rpc_gss_set_svc_name(3t) and rpc_gss_getcred(3t). That’s on my to-do list.

Quoted 6 lines

In the meantime . . .

Quoted 1 line

Would it be appropriate to make them "official" with header and doco support?

A fix for this issue was proposed yesterday on libtirpc-devel.

Ahh, thanks. I should have looked in the archives first, shouldn't I ?

I'll go see.

Thanks,
NeilBrown