Bluetooth: btusb: Add routine for applying Intel DDC parameters

This patch adds the routine to apply the DDC parameter from device specific ddc file.

Once the device is rest to operational mode, optionally, it can download the device specific configration (DDC) parameters before the BlueZ starts the stack initialization.

It opens the DDC file based on HW_VARIANT and send ID/Value with HCI_Intel_Write_DDC command.

Format of DDC file
DDC file consists of one or more number of DDC structure that has a 'Length' field of one octet, DDC 'ID' field of two octets followed by the array of DDC 'Value' that gives the value of parameters itself. 'Length' contains the length of DDC 'ID' and DDC 'Value'.

+------------+----------+
| Size(byte) |    Name  |
+------------+----------+
|      1     | Length   |
+------------+----------+
|      2     | ID       |
+------------+----------+
| Length - 2 | Value    |
+------------+----------+

In case of command failure, it returns the command complete with parameter that contains the ID that failed to apply.

Signed-off-by Tedd Ho-Jeong An <[email protected]>

---
drivers/bluetooth/btintel.h | 5 +++
drivers/bluetooth/btusb.c | 75 +++++++++++++++++++++++++++++++++++++++++++++

2 files changed, 80 insertions(+)

drivers/bluetooth/btintel.h +5 -0

index 4bda6ab..affb216 100644
@@ -69,6 +69,11 @@ struct intel_secure_send_result {
 	__u8     status;
 } __packed;
 
+struct intel_write_ddc {
+	__u8	status;
+	__le16	failed_id;
+} __packed;
+
 #if IS_ENABLED(CONFIG_BT_INTEL)
 
 int btintel_check_bdaddr(struct hci_dev *hdev);

drivers/bluetooth/btusb.c +0 -0

index 13b9969..bc3697f 100644
@@ -2318,6 +2318,66 @@ static void btusb_intel_version_info(struct hci_dev *hdev,
 		ver->fw_build_num, ver->fw_build_ww, 2000 + ver->fw_build_yy);
 }

drivers/bluetooth/btusb.c +7 -0

+		return 0;
+	}
+
+	BT_INFO("%s: Intel DDC file opened: %s", hdev->name, fwname);
+
+	fw_ptr = fw->data;
+	while (fw->size > fw_ptr - fw->data) {

drivers/bluetooth/btusb.c +19 -0

+		}
+
+		fw_ptr += cmd_len;
+
+		kfree_skb(skb);
+	}
+
+	release_firmware(fw);
+
+	BT_INFO("%s: Completed to apply Intel DDC parameters", hdev->name);
+
+	return 0;
+}
+
 static int btusb_setup_intel_new(struct hci_dev *hdev)
 {
 	static const u8 reset_param[] = { 0x00, 0x01, 0x00, 0x01,

@@ -2331,6 +2391,7 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
 	char fwname[64];
 	ktime_t calltime, delta, rettime;
 	unsigned long long duration;
+	u8 hw_variant;
 	int err;
 
 	BT_DBG("%s", hdev->name);

@@ -2385,6 +2446,10 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
 		return -EINVAL;
 	}
 
+	/* Keep this variable for later use with DDC
+	 */
+	hw_variant = ver->hw_variant;
+
 	btusb_intel_version_info(hdev, ver);
 
 	/* The firmware variant determines if the device is in bootloader

@@ -2660,6 +2725,16 @@ done:
 
 	clear_bit(BTUSB_BOOTLOADER, &data->flags);
 

Hi Tedd,

Quoted 16 lines

This patch adds the routine to apply the DDC parameter from device specific ddc file.

Once the device is rest to operational mode, optionally, it can download the device specific configration (DDC) parameters before the BlueZ starts the stack initialization.

It opens the DDC file based on HW_VARIANT and send ID/Value with HCI_Intel_Write_DDC command.

Format of DDC file
DDC file consists of one or more number of DDC structure that has a 'Length' field of one octet, DDC 'ID' field of two octets followed by the array of DDC 'Value' that gives the value of parameters itself. 'Length' contains the length of DDC 'ID' and DDC 'Value'.

Quoted 9 lines

+------------+----------+
| Size(byte) |    Name  |
+------------+----------+
|      1     | Length   |
+------------+----------+
|      2     | ID       |
+------------+----------+
| Length - 2 | Value    |
+------------+----------+

I wonder if we should add some sort of header to this file structure.

Quoted 26 lines

Quoted 25 lines

This patch adds the routine to apply the DDC parameter from device specific ddc file.

Once the device is rest to operational mode, optionally, it can download the device specific configration (DDC) parameters before the BlueZ starts the stack initialization.

It opens the DDC file based on HW_VARIANT and send ID/Value with HCI_Intel_Write_DDC command.

Format of DDC file
DDC file consists of one or more number of DDC structure that has a 'Length' field of one octet, DDC 'ID' field of two octets followed by the array of DDC 'Value' that gives the value of parameters itself. 'Length' contains the length of DDC 'ID' and DDC 'Value'.

+------------+----------+
| Size(byte) |    Name  |
+------------+----------+
|      1     | Length   |
+------------+----------+
|      2     | ID       |
+------------+----------+
| Length - 2 | Value    |
+------------+----------+

Quoted 2 lines

I wonder if we should add some sort of header to this file structure.

Could you explain more about the "header"? DDC header is Length and ID. The DDC file can have more than one DDC. Do you mean the header for all DDC contents? Then it will be same as HCI plen.

Also, how do you think about saving this file in ASCII format instead of binary? then I can add some comments that start with # and ignore the line like bash script.