ARM: imx6: gpc: don't register power domain if DT data is missing
Subsystems (3)
PATCH 1/1 ARM: imx6: gpc: don't register power domain if DT data is missing
If the devicetree is too old and does not provide the regulator and clocks for the power domain, we need to avoid registering the power domain. Otherwise runtime PM will try to control the domain, which will lead to machine hangs without the proper DT configuration data.
This restores functionality to the kernel 4.0 level if an old DT is detected, where the power domain is constantly powered on.
--- arch/arm/mach-imx/gpc.c | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/mach-imx/gpc.c +4 -0
@@ -449,6 +449,10 @@ static int imx_gpc_probe(struct platform_device *pdev)struct regulator *pu_reg;int ret; +/* bail out if DT too old and doesn't provide the necessary info */ +if (!of_property_read_bool (pdev->dev.of_node,"#power-domain-cells" )) +return 0 ; + pu_reg =devm_regulator_get_optional (&pdev->dev,"pu" );if (PTR_ERR (pu_reg) == -ENODEV ) pu_reg =NULL ;
Signature · 1 line
2.1.4
Shawn Guo
AppliedPATCH 1/1 ARM: imx6: gpc: don't register power domain if DT data is missing
Quoted 9 lines · Lucas Stach
If the devicetree is too old and does not provide the regulator and clocks for the power domain, we need to avoid registering the power domain. Otherwise runtime PM will try to control the domain, which will lead to machine hangs without the proper DT configuration data.
This restores functionality to the kernel 4.0 level if an old DT is detected, where the power domain is constantly powered on.
Signed-off-by Lucas Stach <[email protected]>
Applied, thanks.
Quoted 22 lines
--- arch/arm/mach-imx/gpc.c | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/mach-imx/gpc.c +4
-0@@ -449,6 +449,10 @@ static int imx_gpc_probe(struct platform_device *pdev)struct regulator *pu_reg;int ret; +/* bail out if DT too old and doesn't provide the necessary info */ +if (!of_property_read_bool (pdev->dev.of_node,"#power-domain-cells" )) +return 0 ; + pu_reg =devm_regulator_get_optional (&pdev->dev,"pu" );if (PTR_ERR (pu_reg) == -ENODEV ) pu_reg =NULL ;Signature · 1 line
2.1.4