kms_rotation_crc: Update rotation direction for kernel changes
PATCH 1/1 kms_rotation_crc: Update rotation direction for kernel changes
From: Tvrtko Ursulin <[email protected]>
commit 1e8df16778b0d8fd8102b3ee799b028f8f961089
Author: Sonika Jindal <[email protected]> Date: Wed May 20 13:40:48 2015 +0530
drm/i915/skl: Swapping 90 and 270 to be compliant with Xrand
Changed the rotation direction so IGT needs to be told.
--- tests/kms_rotation_crc.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-)
tests/kms_rotation_crc.c +7 -9
@@ -61,21 +61,19 @@ paint_squares(data_t *data, drmModeModeInfo *mode, igt_rotation_t rotation, }if (rotation ==IGT_ROTATION_90 ) { -/* Paint 4 squares with width == height in Blue, Red, -Green, White Clockwise order to look like 90 degree rotated*/ -igt_paint_color (cr,0 ,0 , w /2 , h /2 ,0.0 ,0.0 ,1.0 ); -igt_paint_color (cr, w /2 ,0 , w /2 , h /2 ,1.0 ,0.0 ,0.0 ); -igt_paint_color (cr,0 , h /2 , w /2 , h /2 ,1.0 ,1.0 ,1.0 ); -igt_paint_color (cr, w /2 , h /2 , w /2 , h /2 ,0.0 ,1.0 ,0.0 ); - - }else if (rotation ==IGT_ROTATION_270 ) {/* Paint 4 squares with width == height in Green, White, Blue, Red Clockwise order to look like 270 degree rotated*/ igt_paint_color (cr,0 ,0 , w /2 , h /2 ,0.0 ,1.0 ,0.0 );igt_paint_color (cr, w /2 ,0 , w /2 , h /2 ,1.0 ,1.0 ,1.0 );igt_paint_color (cr,0 , h /2 , w /2 , h /2 ,1.0 ,0.0 ,0.0 );igt_paint_color (cr, w /2 , h /2 , w /2 , h /2 ,0.0 ,0.0 ,1.0 ); - + }else if (rotation ==IGT_ROTATION_270 ) { +/* Paint 4 squares with width == height in Blue, Red, +Green, White Clockwise order to look like 90 degree rotated*/ +igt_paint_color (cr,0 ,0 , w /2 , h /2 ,0.0 ,0.0 ,1.0 ); +igt_paint_color (cr, w /2 ,0 , w /2 , h /2 ,1.0 ,0.0 ,0.0 ); +igt_paint_color (cr,0 , h /2 , w /2 , h /2 ,1.0 ,1.0 ,1.0 ); +igt_paint_color (cr, w /2 , h /2 , w /2 , h /2 ,0.0 ,1.0 ,0.0 ); }else {/* Paint with 4 squares of Red, Green, White, Blue Clockwise */ igt_paint_color (cr,0 ,0 , w /2 , h /2 ,1.0 ,0.0 ,0.0 );
Signature · 6 lines
2.4.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Thanks for sending this.. I realized that I had a patch for this which I never sent :)
-----Original Message-----
From: Tvrtko Ursulin [mailto:[email protected]]
Sent: Friday, May 22, 2015 3:31 PM
To: [email protected]
Cc: Ursulin, Tvrtko; Ville Syrjälä; Jindal, Sonika
Subject: [PATCH i-g-t] kms_rotation_crc: Update rotation direction for kernel changes
From: Tvrtko Ursulin <[email protected]>
commit 1e8df16778b0d8fd8102b3ee799b028f8f961089
Author: Sonika Jindal <[email protected]> Date: Wed May 20 13:40:48 2015 +0530
drm/i915/skl: Swapping 90 and 270 to be compliant with Xrand
Changed the rotation direction so IGT needs to be told.
--- tests/kms_rotation_crc.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-)
tests/kms_rotation_crc.c +7 -9
@@ -61,21 +61,19 @@ paint_squares(data_t *data, drmModeModeInfo *mode, igt_rotation_t rotation, }if (rotation ==IGT_ROTATION_90 ) { -/* Paint 4 squares with width == height in Blue, Red, -Green, White Clockwise order to look like 90 degree rotated*/ -igt_paint_color (cr,0 ,0 , w /2 , h /2 ,0.0 ,0.0 ,1.0 ); -igt_paint_color (cr, w /2 ,0 , w /2 , h /2 ,1.0 ,0.0 ,0.0 ); -igt_paint_color (cr,0 , h /2 , w /2 , h /2 ,1.0 ,1.0 ,1.0 ); -igt_paint_color (cr, w /2 , h /2 , w /2 , h /2 ,0.0 ,1.0 ,0.0 ); - - }else if (rotation ==IGT_ROTATION_270 ) {/* Paint 4 squares with width == height in Green, White, Blue, Red Clockwise order to look like 270 degree rotated*/ igt_paint_color (cr,0 ,0 , w /2 , h /2 ,0.0 ,1.0 ,0.0 );igt_paint_color (cr, w /2 ,0 , w /2 , h /2 ,1.0 ,1.0 ,1.0 );igt_paint_color (cr,0 , h /2 , w /2 , h /2 ,1.0 ,0.0 ,0.0 );igt_paint_color (cr, w /2 , h /2 , w /2 , h /2 ,0.0 ,0.0 ,1.0 ); - + }else if (rotation ==IGT_ROTATION_270 ) { +/* Paint 4 squares with width == height in Blue, Red, +Green, White Clockwise order to look like 90 degree rotated*/ +igt_paint_color (cr,0 ,0 , w /2 , h /2 ,0.0 ,0.0 ,1.0 ); +igt_paint_color (cr, w /2 ,0 , w /2 , h /2 ,1.0 ,0.0 ,0.0 ); +igt_paint_color (cr,0 , h /2 , w /2 , h /2 ,1.0 ,1.0 ,1.0 ); +igt_paint_color (cr, w /2 , h /2 , w /2 , h /2 ,0.0 ,1.0 ,0.0 ); }else {/* Paint with 4 squares of Red, Green, White, Blue Clockwise */ igt_paint_color (cr,0 ,0 , w /2 , h /2 ,1.0 ,0.0 ,0.0 );
--
2.4.0
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Sonika
Thanks for sending this.. I realized that I had a patch for this which I never sent :)
Reviewed-by Sonika Jindal <[email protected]>
Pushed, thanks for the patch and review. Probably a good time to start thinking about applying for an fdo account to push patches yourself?
Signature · 5 lines
Damien _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx