Skip to contentSkip to conversation

USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

PATCH In review Abhishek Bist 3 participants 5 messages May 27, 2015 USB

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

This function is used to call before 2.6.x version of linux kernel but since then I haven't seen it's relative usage and it's not being used any where right now after checking it through linux.crossrefrence.So, IMHO it would be relevant to remove this obselete function from kernel mainline.

---
 include/linux/usb/hcd.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/usb/hcd.h +0 -2
index 68b1e83..c9aa779 100644
@@ -622,8 +622,6 @@ extern struct list_head usb_bus_list;
 extern struct mutex usb_bus_list_lock;
 extern wait_queue_head_t usb_kill_urb_queue;
 
-extern int usb_find_interface_driver(struct usb_device *dev,
-	struct usb_interface *interface);
 
 #define usb_endpoint_out(ep_dir)	(!((ep_dir) & USB_DIR_IN))
 
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 3 lines · Abhishek Bist

This function is used to call before 2.6.x version of linux kernel but since then I haven't seen it's relative usage and it's not being used any where right now after checking it through linux.crossrefrence.So, IMHO it would be relevant to remove this obselete function from kernel mainline.

Please properly wrap your changelog lines at 72 columns.

Quoted 10 lines
---
 include/linux/usb/hcd.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/usb/hcd.h +0 -0
index 68b1e83..c9aa779 100644

include/linux/usb/hcd.h extern struct list_head usb_bus_list; · line 626

Quoted 5 lines
include/linux/usb/hcd.h +0 -2
@@ -622,8 +622,6 @@ extern struct list_head usb_bus_list;
 extern struct mutex usb_bus_list_lock;
 extern wait_queue_head_t usb_kill_urb_queue;
 
-extern int usb_find_interface_driver(struct usb_device *dev,
-	struct usb_interface *interface);

Good catch, care to fix up the wording in your changelog and resend this?

thanks,

greg k-h

maintainer
#2 lore raw
In reply to Abhishek Bist
Quoted 8 lines · Abhishek Bist

This function is used to call before 2.6.x version of linux kernel but since then I haven't seen it's relative usage and it's not being used any where right now after checking it through linux.crossrefrence.So, IMHO it would be relevant to remove this obselete function from kernel mainline.

---
 include/linux/usb/hcd.h | 2 --
 1 file changed, 2 deletions(-)

Where is patch 1/2? I didn't get a copy of it...

#3 lore raw
In reply to Abhishek Bist
Quoted 4 lines · Abhishek Bist

This function is used to call before 2.6.x version of linux kernel but since then I haven't seen it's relative usage and it's not being used any where right now after checking it through linux.crossrefrence.

This goes into detail way beyond what anyone sane cares for:
usb_find_interface_driver() was removed in v2.5.36 through a patch titled "USB: Convert the core code to use struct device_driver.".

Quoted 2 lines

So, IMHO it would be relevant to remove this obselete function from kernel mainline.

Thanks,

Paul Bolle

#4 lore raw

PATCH 1/1 USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

In reply to Abhishek Bist

This function is used to call in early version of linux kernel in order to find out the interface used by a usb device. But now it's use is completely abolished. So,it would be relevant to remove this obselete function from kernel mainline.

---
 include/linux/usb/hcd.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/usb/hcd.h +0 -2
index 68b1e83..c9aa779 100644
@@ -622,8 +622,6 @@ extern struct list_head usb_bus_list;
 extern struct mutex usb_bus_list_lock;
 extern wait_queue_head_t usb_kill_urb_queue;
 
-extern int usb_find_interface_driver(struct usb_device *dev,
-	struct usb_interface *interface);
 
 #define usb_endpoint_out(ep_dir)	(!((ep_dir) & USB_DIR_IN))
 
Signature · 1 line
1.8.3.1