gpio/crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip
Subsystems (2)
PATCH 1/1 gpio/crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip
The CrystalCove GPIO irqchip doesn't have irq_set_wake callback defined so we should set IRQCHIP_SKIP_SET_WAKE for it or it would cause an irq desc's wake_depth unbalanced warning during system resume phase from the gpio_keys driver, which is the driver for the power button of the ASUS T100 laptop.
Signed-off-by Aaron Lu <[email protected]>
Cc <[email protected]>
--- drivers/gpio/gpio-crystalcove.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpio/gpio-crystalcove.c +1 -0
@@ -255,6 +255,7 @@ static struct irq_chip crystalcove_irqchip = { .irq_set_type = crystalcove_irq_type, .irq_bus_lock = crystalcove_bus_lock, .irq_bus_sync_unlock = crystalcove_bus_sync_unlock, + .flags = IRQCHIP_SKIP_SET_WAKE, };static irqreturn_t crystalcove_gpio_irq_handler (int irq,void *data)
Signature · 1 line
2.4.1
Quoted 8 lines · Aaron Lu
The CrystalCove GPIO irqchip doesn't have
irq_set_wakecallback defined so we should setIRQCHIP_SKIP_SET_WAKEfor it or it would cause an irq desc'swake_depthunbalanced warning during system resume phase from thegpio_keysdriver, which is the driver for the power button of the ASUS T100 laptop.Signed-off-by Aaron Lu <[email protected]>Cc <[email protected]>
Patch applied.
Yours,
Linus Walleij