Skip to contentSkip to conversation

Staging: vt6655: Remove unnecessary equality checks for a bool variable

PATCH In review Harisangam, Sharvari (S.) 3 participants 3 messages May 28, 2015 – May 31, 2015 Staging

lore
Share & tools
lore

Harisangam, Sharvari (S.)

author
#0 lore raw

PATCH 1/1 Staging: vt6655: Remove unnecessary equality checks for a bool variable

Modified the if-else statements to remove unnecessary comparisons. This change was detected with the help of coccinelle tool

Signed-off-by Harisangam Sharvari <[email protected]>
---
 drivers/staging/vt6655/rxtx.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/vt6655/rxtx.c +4 -4
index 7468776..7fedde3 100644
@@ -1093,7 +1093,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
 	if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {/* 802.11g packet */
 
 		if (byFBOption == AUTO_FB_NONE) {
-			if (bRTS == true) {/* RTS_need */
+			if (bRTS) {/* RTS_need */
 				pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
 				pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
 				pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);

@@ -1115,7 +1115,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
 			}
 		} else {
 			/* Auto Fall Back */
-			if (bRTS == true) {/* RTS_need */
+			if (bRTS) {/* RTS_need */
 				pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
 				pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
 				pvRTS = (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);

@@ -1138,7 +1138,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
 	} else {/* 802.11a/b packet */
 
 		if (byFBOption == AUTO_FB_NONE) {
-			if (bRTS == true) {
+			if (bRTS) {
 				pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
 				pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab));
 				pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR);

@@ -1158,7 +1158,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
 			}
 		} else {
 			/* Auto Fall Back */
-			if (bRTS == true) { /* RTS_need */
+			if (bRTS) { /* RTS_need */
 				pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
 				pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab));
 				pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR);
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 2 lines · Sharvari (S.)

Modified the if-else statements to remove unnecessary comparisons. This change was detected with the help of coccinelle tool

Your commit subject implies you are doing this for the directory, not a single file.

If you are going to do this, please do it for all files in the directory.

$ git grep  -w -E "if\s*\(.*(true|false)" drivers/staging/vt6655/
drivers/staging/vt6655/card.c:  if (pDevice->bRadioOff == true)
drivers/staging/vt6655/card.c:  if (pDevice->bRadioControlOff == true) {
drivers/staging/vt6655/card.c:          if (pDevice->bHWRadioOff == true)
drivers/staging/vt6655/card.c:          if (pDevice->bRadioControlOff == true)
drivers/staging/vt6655/card.c:  if (pDevice->bRadioOff == false) {
drivers/staging/vt6655/rxtx.c:                  if (bRTS == true) {/* RTS_need */
drivers/staging/vt6655/rxtx.c:                  if (bRTS == true) {/* RTS_need */
drivers/staging/vt6655/rxtx.c:                  if (bRTS == true) {
drivers/staging/vt6655/rxtx.c:                  if (bRTS == true) { /* RTS_need */