Skip to contentSkip to conversation

ARM: imx: imx7d requires anatop

PATCH Superseded Arnd Bergmann 2 participants 3 messages May 28, 2015 – May 29, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: imx: imx7d requires anatop

Like i.MX6, the i.MX7 code calls into the anatop driver, which fails if that is disabled:

arch/arm/mach-imx/built-in.o: In function `imx7d_init_machine':
arch/arm/mach-imx/mach-imx7d.c:24: undefined reference to imx_anatop_init' arch/arm/mach-imx/built-in.o: In function imx7d_init_irq':
arch/arm/mach-imx/mach-imx7d.c:29: undefined reference to `imx_init_revision_from_anatop'

This patch ensures that for an imx7-only build, we still get anatop built-in, matching what we do for imx6.

arch/arm/mach-imx/Kconfig +1 -0
index bb2d058f4d11..e472746b01d2 100644
@@ -551,6 +551,7 @@ config SOC_IMX7D
 	bool "i.MX7 Dual support"
 	select PINCTRL_IMX7D
 	select ARM_GIC
+	select HAVE_IMX_ANATOP
 	help
 		This enables support for Freescale i.MX7 Dual processor.
 
#1 lore raw

PATCH v2 1/1 ARM: imx: imx7d requires anatop

Like i.MX6, the i.MX7 code calls into the anatop driver, which fails if that is disabled:

arch/arm/mach-imx/built-in.o: In function `imx7d_init_machine':
arch/arm/mach-imx/mach-imx7d.c:24: undefined reference to imx_anatop_init' arch/arm/mach-imx/built-in.o: In function imx7d_init_irq':
arch/arm/mach-imx/mach-imx7d.c:29: undefined reference to `imx_init_revision_from_anatop'

This patch ensures that for an imx7-only build, we still get anatop built-in, matching what we do for imx6. We also need to select HAVE_IMX_MMDC, as that is needed by the anatop code.

---
I ran into a related problem, please use this version instead of the first one, to cover all cases.

arch/arm/mach-imx/Kconfig +2 -0
index bb2d058f4d11..fd3c5b348586 100644
@@ -551,6 +551,8 @@ config SOC_IMX7D
 	bool "i.MX7 Dual support"
 	select PINCTRL_IMX7D
 	select ARM_GIC
+	select HAVE_IMX_ANATOP
+	select HAVE_IMX_MMDC
 	help
 		This enables support for Freescale i.MX7 Dual processor.
 
Applied
#2 lore raw

PATCH v2 1/1 ARM: imx: imx7d requires anatop

Quoted 8 lines · Arnd Bergmann

Like i.MX6, the i.MX7 code calls into the anatop driver, which fails if that is disabled:

arch/arm/mach-imx/built-in.o: In function `imx7d_init_machine':
arch/arm/mach-imx/mach-imx7d.c:24: undefined reference to imx_anatop_init' arch/arm/mach-imx/built-in.o: In function imx7d_init_irq':
arch/arm/mach-imx/mach-imx7d.c:29: undefined reference to `imx_init_revision_from_anatop'

Quoted 8 lines

This patch ensures that for an imx7-only build, we still get anatop built-in, matching what we do for imx6. We also need to select HAVE_IMX_MMDC, as that is needed by the anatop code.

---
I ran into a related problem, please use this version instead of the first one, to cover all cases.

Applied, thanks.