Caring at91bootstrap3

PATCH Superseded Angelo Compagnucci 3 participants 8 messages May 29, 2015 – Jun 1, 2015 Arm/Microchip (AT91) SoC support

lore

Share & tools

lore

Angelo Compagnucci

author

2015-05-29 09:38 UTC #0 lore raw

cover Caring at91bootstrap3

This patch series:
* Add license information to at91bootstrap
* Bumps to v3.7.2
* Add the option to download via git from custom url

Angelo Compagnucci (3):
boot/at91bootstrap3: add license information
boot/at91bootstrap3: bump to version 3.7.2
boot/at91bootstrap3: download via cutom git url

 boot/at91bootstrap3/Config.in         | 34 ++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk | 11 ++++++++++-
 2 files changed, 44 insertions(+), 1 deletion(-)

Signature · 1 line

1.9.1

Angelo Compagnucci

author

2015-05-29 09:38 UTC #1 lore raw

PATCH 1/3 boot/at91bootstrap3: add license information

This patch adds licensing informations to at91bootstrap3

Signed-off-by Angelo Compagnucci <[email protected]>

---
 boot/at91bootstrap3/at91bootstrap3.mk | 2 ++
 1 file changed, 2 insertions(+)

boot/at91bootstrap3/at91bootstrap3.mk +2 -0

index ff49e14..2164a74 100644
@@ -6,6 +6,8 @@
 
 AT91BOOTSTRAP3_VERSION = v3.7.1
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+AT91BOOTSTRAP3_LICENSE = BSD-2c
+AT91BOOTSTRAP3_LICENSE_FILES = main.c
 
 AT91BOOTSTRAP3_INSTALL_IMAGES = YES
 AT91BOOTSTRAP3_INSTALL_TARGET = NO

Signature · 1 line

1.9.1

Thomas Petazzoni

2015-05-31 08:43 UTC #2 lore raw

PATCH 1/3 boot/at91bootstrap3: add license information

Dear Angelo Compagnucci,

Quoted 12 lines · Angelo Compagnucci

This patch adds licensing informations to at91bootstrap3
Signed-off-by Angelo Compagnucci <[email protected]>
---
 boot/at91bootstrap3/at91bootstrap3.mk | 2 ++
 1 file changed, 2 insertions(+)
boot/at91bootstrap3/at91bootstrap3.mk +0 -0
index ff49e14..2164a74 100644

boot/at91bootstrap3/at91bootstrap3.mk line 10

Quoted 5 lines

boot/at91bootstrap3/at91bootstrap3.mk +2 -0

@@ -6,6 +6,8 @@
 
 AT91BOOTSTRAP3_VERSION = v3.7.1
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+AT91BOOTSTRAP3_LICENSE = BSD-2c
+AT91BOOTSTRAP3_LICENSE_FILES = main.c

I *think* it is actually closer to a BSD-3c, since it has the following text:

* Atmel's name may not be used to endorse or promote products derived from
* this software without specific prior written permission.

However, the wording is not 100% the one of the BSD-3c, so I'm not sure if we should call it BSD-3c or not.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Angelo Compagnucci

author

2015-06-01 16:03 UTC #3 lore raw

PATCH 1/3 boot/at91bootstrap3: add license information

Dear Thomas Petazzoni,

2015-05-31 10:43 GMT+02:00 Thomas Petazzoni
<[email protected]>:

Quoted 24 lines

Dear Angelo Compagnucci,
Quoted 12 lines · Angelo Compagnucci
This patch adds licensing informations to at91bootstrap3
Signed-off-by Angelo Compagnucci <[email protected]>
---
 boot/at91bootstrap3/at91bootstrap3.mk | 2 ++
 1 file changed, 2 insertions(+)
boot/at91bootstrap3/at91bootstrap3.mk +0 -0
index ff49e14..2164a74 100644
boot/at91bootstrap3/at91bootstrap3.mk line 10
Quoted 5 lines
boot/at91bootstrap3/at91bootstrap3.mk +2 -0
@@ -6,6 +6,8 @@
 
 AT91BOOTSTRAP3_VERSION = v3.7.1
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+AT91BOOTSTRAP3_LICENSE = BSD-2c
+AT91BOOTSTRAP3_LICENSE_FILES = main.c
I *think* it is actually closer to a BSD-3c, since it has the following text:

Quoted 5 lines

* Atmel's name may not be used to endorse or promote products derived from
* this software without specific prior written permission.
However, the wording is not 100% the one of the BSD-3c, so I'm not sure if we should call it BSD-3c or not.

Probably you are right, the wording is more similar to a BSD-3c instead of a BSD-2c, but it's different. Can we use something like BSD-custom or BSD-modified?

Sincerely, Angelo

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Signature · 1 line

Profile: http://it.linkedin.com/in/compagnucciangelo

Arnout Vandecappelle

2015-06-01 19:17 UTC #4 lore raw

PATCH 1/3 boot/at91bootstrap3: add license information

Quoted 31 lines · Angelo Compagnucci

Dear Thomas Petazzoni,
2015-05-31 10:43 GMT+02:00 Thomas Petazzoni
<[email protected]>:
Quoted 27 lines
Dear Angelo Compagnucci,
Quoted 12 lines · Angelo Compagnucci
This patch adds licensing informations to at91bootstrap3
Signed-off-by Angelo Compagnucci <[email protected]>
---
 boot/at91bootstrap3/at91bootstrap3.mk | 2 ++
 1 file changed, 2 insertions(+)
boot/at91bootstrap3/at91bootstrap3.mk +0 -0
index ff49e14..2164a74 100644
boot/at91bootstrap3/at91bootstrap3.mk line 10
Quoted 5 lines
boot/at91bootstrap3/at91bootstrap3.mk +2 -0
@@ -6,6 +6,8 @@
 
 AT91BOOTSTRAP3_VERSION = v3.7.1
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+AT91BOOTSTRAP3_LICENSE = BSD-2c
+AT91BOOTSTRAP3_LICENSE_FILES = main.c
I *think* it is actually closer to a BSD-3c, since it has the following text:
* Atmel's name may not be used to endorse or promote products derived from
* this software without specific prior written permission.

Quoted 6 lines

Quoted 2 lines
However, the wording is not 100% the one of the BSD-3c, so I'm not sure if we should call it BSD-3c or not.
Probably you are right, the wording is more similar to a BSD-3c instead of a BSD-2c, but it's different. Can we use something like BSD-custom or BSD-modified?

I would say

BSD-2c with endorsement clause

That's still relatively short but also clear.

Regards,
Arnout

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Angelo Compagnucci

author

2015-05-29 09:38 UTC #5 lore raw

PATCH 2/3 boot/at91bootstrap3: bump to version 3.7.2

In reply to Angelo Compagnucci

This patch bumps at91bootstrap3 version to 3.7.2

Signed-off-by Angelo Compagnucci <[email protected]>

---
 boot/at91bootstrap3/at91bootstrap3.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

boot/at91bootstrap3/at91bootstrap3.mk +1 -1

index 2164a74..b73821e 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.1
+AT91BOOTSTRAP3_VERSION = v3.7.2
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
 AT91BOOTSTRAP3_LICENSE = BSD-2c
 AT91BOOTSTRAP3_LICENSE_FILES = main.c

Signature · 1 line

1.9.1

Angelo Compagnucci

author

2015-05-29 09:38 UTC #6 lore raw

PATCH 3/3 boot/at91bootstrap3: download via custom git url

In reply to Angelo Compagnucci

This patch adds the option to download at91bootstrap3 from a custom git URL. This is a requirement for all that boards that use a custom at91bootstrap3 version.

Signed-off-by Angelo Compagnucci <[email protected]>

---
 boot/at91bootstrap3/Config.in         | 34 ++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk |  9 ++++++++-
 2 files changed, 42 insertions(+), 1 deletion(-)

boot/at91bootstrap3/Config.in +34 -0

index 8ac40ed..9f2f49b 100644
@@ -10,6 +10,40 @@ config BR2_TARGET_AT91BOOTSTRAP3
 
 if BR2_TARGET_AT91BOOTSTRAP3
 
+choice
+
+	prompt "AT91 Bootstrap 3 version"
+
+config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	bool "3.7.2"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+	bool "Custom Git repository"
+	help
+	  This option allows Buildroot to get the AT91 Bootstrap 3 source
+	  code from a Git repository.
+
+endchoice
+
+if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
+	string "URL of custom repository"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
+	string "Custom repository version"
+	help
+	  Revision to use in the typical format used by Git
+	  E.G. a sha id, a tag, branch, ..
+
+endif
+
+config BR2_TARGET_AT91BOOTSTRAP3_VERSION
+	string
+	default "v3.7.2" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
+		if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
 config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
 	string "custom patch dir"
 	help

boot/at91bootstrap3/at91bootstrap3.mk +8 -1

index b73821e..fae2e8e 100644
@@ -4,8 +4,15 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.2
+AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
+
+ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
+AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
+AT91BOOTSTRAP3_SITE_METHOD = git
+else
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+endif
+
 AT91BOOTSTRAP3_LICENSE = BSD-2c
 AT91BOOTSTRAP3_LICENSE_FILES = main.c

Signature · 1 line

1.9.1

Arnout Vandecappelle

2015-06-01 19:35 UTC #7 lore raw

PATCH 3/3 boot/at91bootstrap3: download via custom git url

Quoted 65 lines · Angelo Compagnucci

This patch adds the option to download at91bootstrap3 from a custom git URL. This is a requirement for all that boards that use a custom at91bootstrap3 version.

Signed-off-by Angelo Compagnucci <[email protected]>

---
 boot/at91bootstrap3/Config.in         | 34 ++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk |  9 ++++++++-
 2 files changed, 42 insertions(+), 1 deletion(-)

boot/at91bootstrap3/Config.in +34 -0

index 8ac40ed..9f2f49b 100644
@@ -10,6 +10,40 @@ config BR2_TARGET_AT91BOOTSTRAP3
 
 if BR2_TARGET_AT91BOOTSTRAP3
 
+choice
+
+	prompt "AT91 Bootstrap 3 version"
+
+config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	bool "3.7.2"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+	bool "Custom Git repository"
+	help
+	  This option allows Buildroot to get the AT91 Bootstrap 3 source
+	  code from a Git repository.
+
+endchoice
+
+if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
+	string "URL of custom repository"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
+	string "Custom repository version"
+	help
+	  Revision to use in the typical format used by Git
+	  E.G. a sha id, a tag, branch, ..
+
+endif
+
+config BR2_TARGET_AT91BOOTSTRAP3_VERSION
+	string
+	default "v3.7.2" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
+		if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
 config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
 	string "custom patch dir"
 	help

boot/at91bootstrap3/at91bootstrap3.mk +1 -1

index b73821e..fae2e8e 100644
@@ -4,8 +4,15 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.2
+AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))

boot/at91bootstrap3/at91bootstrap3.mk line 17

Quoted 10 lines

boot/at91bootstrap3/at91bootstrap3.mk +7 -0

+
+ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
+AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
+AT91BOOTSTRAP3_SITE_METHOD = git
+else
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+endif
+
 AT91BOOTSTRAP3_LICENSE = BSD-2c
 AT91BOOTSTRAP3_LICENSE_FILES = main.c

There should be a check against an empty version in the custom repo case,
similar like it's done for uboot. Otherwise you get the cryptic:

Quoted 1 line

Quoted 1 line
Quoted 1 line
at91bootstrap3 Downloading

Doing full clone
fatal: The empty string is not a valid path
--2015-06-01 21:29:11-- http://sources.buildroot.net/at91bootstrap3-.tar.gz
Resolving sources.buildroot.net (sources.buildroot.net)... 176.9.16.109 Connecting to sources.buildroot.net (sources.buildroot.net)|176.9.16.109|:80... connected.
HTTP request sent, awaiting response... 404 Not Found

2015-06-01 21:29:12 ERROR 404: Not Found.

Otherwise, looks good to me.

Regards,
Arnout

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F