Skip to contentSkip to conversation

Add -mshared option to x86 ELF assembler

PATCH Andy Lutomirski 2 participants 2 messages Jun 1, 2015 – Jun 2, 2015 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 20150601083214.GA381@x4

A message that is not in the archive (sent off-list or not yet received): CAMe9rOrdqc1v7Dzm3T=CO2a7mVNypOXkAZMFxRMJwwcu61jxGQ@mail.gmail.com

#3 lore raw
Quoted 31 lines · H.J. Lu
Quoted 20 lines · Markus Trippelsdorf
Quoted 19 lines · H.J. Lu

This patch adds -mshared option to x86 ELF assembler. By default, assembler will optimize out non-PLT relocations against defined non-weak global branch targets with default visibility. The -mshared option tells the assembler to generate code which may go into a shared library where all non-weak global branch targets with default visibility can be preempted. The resulting code is slightly bigger. This option only affects the handling of branch instructions.

This Linux kernel patch is needed to create a working x86 Linux kernel if it hasn't been applied:

arch/x86/kernel/head_64.S +0 -0
index ae6588b..b91a00c 100644
@@ -339,8 +339,8 @@ early_idt_handlers:
      i = i + 1
      .endr
 
Quoted 8 lines

arch/x86/kernel/head_64.S early_idt_handlers: · line 344

Quoted 5 lines
arch/x86/kernel/head_64.S +2 -2
-/* This is global to keep gas from relaxing the jumps */
-ENTRY(early_idt_handler)
+/* This is weak to keep gas from relaxing the jumps */
+WEAK(early_idt_handler)
      cld

Have you posted the patch to LKML already?
(I hit this issue today and it took me a while to figure out the cause.)

Quoted 2 lines

A kernel patch will be checked in soon.

It already is:

https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=x86/asm&id=cdeb6048940fa4bfb429e2f1cba0d28a11e20cd5

It's currently queued for 4.2.

Ingo, would it make sense to promote this to 4.1? It's definitely a violation of the "no development after the merge window" rule, but it's sort of a build fix. Alternatively, we could ask Greg et al to backport it.

--Andy

#4 lore raw
Quoted 37 lines · Andy Lutomirski
Quoted 31 lines · H.J. Lu
Quoted 20 lines · Markus Trippelsdorf
Quoted 19 lines · H.J. Lu

This patch adds -mshared option to x86 ELF assembler. By default, assembler will optimize out non-PLT relocations against defined non-weak global branch targets with default visibility. The -mshared option tells the assembler to generate code which may go into a shared library where all non-weak global branch targets with default visibility can be preempted. The resulting code is slightly bigger. This option only affects the handling of branch instructions.

This Linux kernel patch is needed to create a working x86 Linux kernel if it hasn't been applied:

arch/x86/kernel/head_64.S +0 -0
index ae6588b..b91a00c 100644
@@ -339,8 +339,8 @@ early_idt_handlers:
      i = i + 1
      .endr
 
Quoted 8 lines

arch/x86/kernel/head_64.S early_idt_handlers: · line 344

Quoted 5 lines
arch/x86/kernel/head_64.S +2 -2
-/* This is global to keep gas from relaxing the jumps */
-ENTRY(early_idt_handler)
+/* This is weak to keep gas from relaxing the jumps */
+WEAK(early_idt_handler)
      cld

Have you posted the patch to LKML already?
(I hit this issue today and it took me a while to figure out the cause.)

Quoted 2 lines

A kernel patch will be checked in soon.

It already is:

Quoted 7 lines

https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=x86/asm&id=cdeb6048940fa4bfb429e2f1cba0d28a11e20cd5

It's currently queued for 4.2.

Ingo, would it make sense to promote this to 4.1? It's definitely a violation of the "no development after the merge window" rule, but it's sort of a build fix. [...]

Yeah, agreed - the commit was problem-free in testing, so I've cherry-picked it over into tip:x86/urgent and will push it to Linus for v4.1.

Thanks,

Ingo