rcu: Use WRITE_ONCE in RCU_INIT_POINTER
RFC PATCH 1/1 rcu: Use WRITE_ONCE in RCU_INIT_POINTER
For the paranoid amongst us GCC would be in its right to use byte stores to write our NULL value, tell it not to do that.
Signed-off-by Peter Zijlstra (Intel) <[email protected]>
--- include/linux/rcupdate.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/rcupdate.h +1 -1
@@ -1046,7 +1046,7 @@ static inline notrace void rcu_read_unlock_sched_notrace(void)#define RCU_INIT_POINTER (p, v) \ do { \ rcu_dereference_sparse(p, __rcu); \ - p = RCU_INITIALIZER(v); \ + WRITE_ONCE(p, RCU_INITIALIZER(v)); \ } while (0)/**
Quoted 5 lines · Peter Zijlstra
For the paranoid amongst us GCC would be in its right to use byte stores to write our NULL value, tell it not to do that.
Signed-off-by Peter Zijlstra (Intel) <[email protected]>
Good point, queued for 4.3.
Thanx, Paul
Quoted 18 lines
--- include/linux/rcupdate.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/rcupdate.h +1
-1@@ -1046,7 +1046,7 @@ static inline notrace void rcu_read_unlock_sched_notrace(void)#define RCU_INIT_POINTER (p, v) \ do { \ rcu_dereference_sparse(p, __rcu); \ - p = RCU_INITIALIZER(v); \ + WRITE_ONCE(p, RCU_INITIALIZER(v)); \ } while (0)/**