Skip to contentSkip to conversation

staging: rtl8192e: fix some confusing indenting

PATCH In review Dan Carpenter 2 participants 2 messages Jun 5, 2015 – Jun 7, 2015

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 staging: rtl8192e: fix some confusing indenting

The indenting here causes a static checker warning:

drivers/staging/rtl8192e/rtllib_rx.c:626 RxReorderIndicatePacket()
warn: curly braces intended?

The code is actually correct, it's just that these lines were pushed in an extra indent level by mistake in 35e33b0468ab ('staging: rtl8192e:
Fix LONG_LINE warnings').

Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/rtl8192e/rtllib_rx.c +3 -3
index 6977f04..2bef1f6 100644
@@ -623,9 +623,9 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 		else
 			pTS->RxIndicateSeq = 4095 -
 					     (WinSize - (SeqNum + 1)) + 1;
-			netdev_dbg(ieee->dev,
-				   "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
-				   pTS->RxIndicateSeq, SeqNum);
+		netdev_dbg(ieee->dev,
+			   "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
+			   pTS->RxIndicateSeq, SeqNum);
 	}
 
 	/* Indication process.
#1 lore raw
Quoted 19 lines · Dan Carpenter

The indenting here causes a static checker warning:

drivers/staging/rtl8192e/rtllib_rx.c:626 RxReorderIndicatePacket()
warn: curly braces intended?

The code is actually correct, it's just that these lines were pushed in an extra indent level by mistake in 35e33b0468ab ('staging: rtl8192e:
Fix LONG_LINE warnings').

Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/rtl8192e/rtllib_rx.c +0 -0
index 6977f04..2bef1f6 100644
@@ -623,9 +623,9 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
 		else
 			pTS->RxIndicateSeq = 4095 -

drivers/staging/rtl8192e/rtllib_rx.c static void RxReorderIndicatePacket(struct rtllib_device *ieee, · line 631

Quoted 10 lines
drivers/staging/rtl8192e/rtllib_rx.c +3 -3
 					     (WinSize - (SeqNum + 1)) + 1;
-			netdev_dbg(ieee->dev,
-				   "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
-				   pTS->RxIndicateSeq, SeqNum);
+		netdev_dbg(ieee->dev,
+			   "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
+			   pTS->RxIndicateSeq, SeqNum);
 	}
 
 	/* Indication process.

Ouch, Thanks!

I've missed this one.

M.