Skip to contentSkip to conversation

drivers: usb: fsl: Return if USB_MAX_CONTROLLER_COUNT is incorrect

PATCH New Nikhil Badola 2 participants 2 messages Jun 7, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drivers: usb: fsl: Return if USB_MAX_CONTROLLER_COUNT is incorrect

Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller to be initialised is incorrect

---
Changes for v2
- Added space between tags in Subject
- Replaced return value from -1 to -EINVAL

 drivers/usb/host/ehci-fsl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/ehci-fsl.c +1 -1
index 5fd618d..97b7f14 100644
@@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init,
 		break;
 	default:
 		printf("ERROR: wrong controller index!!\n");
-		break;
+		return -EINVAL;
 	};
 
 	*hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
Signature · 1 line
1.7.11.7
#1 lore raw

PATCH v2 1/1 drivers: usb: fsl: Return if USB_MAX_CONTROLLER_COUNT is incorrect

Quoted 2 lines · Nikhil Badola

Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller to be initialised is incorrect

This text doesn't really make much sense, but the fix is reasonable. I'll pick it, thanks!

Quoted 14 lines

---
Changes for v2
- Added space between tags in Subject
- Replaced return value from -1 to -EINVAL

 drivers/usb/host/ehci-fsl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/ehci-fsl.c +0 -0
index 5fd618d..97b7f14 100644

drivers/usb/host/ehci-fsl.c int ehci_hcd_init(int index, enum usb_init_type init, · line 82

Quoted 8 lines
drivers/usb/host/ehci-fsl.c +1 -1
@@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init,
 		break;
 	default:
 		printf("ERROR: wrong controller index!!\n");
-		break;
+		return -EINVAL;
 	};
 
 	*hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);

Best regards,
Marek Vasut