Skip to contentSkip to conversation

VPMU: add lost Intel processor

PATCH In review Dietmar Hahn 5 participants 5 messages Jun 3, 2015 – Jun 11, 2015

lore
Share & tools
lore

Dietmar Hahn

author
#0 lore raw

PATCH 1/1 VPMU: add lost Intel processor

Hi,

it seems somewhere the Intel processor
cpu family : 6
model : 47
model name : Intel(R) Xeon(R) CPU E7- 8837 @ 2.67GHz
got lost.

Dietmar.

Signed-off-by Dietmar Hahn <[email protected]>
xen/arch/x86/hvm/vmx/vpmu_core2.c +1 -0
index 8ad522a..bbe6197 100644
@@ -849,6 +849,7 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags)
         case 0x25: /* 32 nm nehalem, "Clarkdale", "Arrandale" */
         case 0x2c: /* 32 nm nehalem, "Gulftown", "Westmere-EP" */
         case 0x27: /* 32 nm Westmere-EX */
+        case 0x2f: /* 32 nm Westmere-EX */
 
         case 0x3a: /* IvyBridge */
         case 0x3e: /* IvyBridge EP */
Signature · 1 line
Company details: http://ts.fujitsu.com/imprint.html
#1 lore raw

xen/arch/x86/hvm/vmx/vpmu_core2.c int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags) · line 852

Quoted 8 lines
Quoted 1 line
Quoted 1 line · On 03.06.15 at 13:44, <[email protected]> wrote:
xen/arch/x86/hvm/vmx/vpmu_core2.c +1 -0
@@ -849,6 +849,7 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags)
         case 0x25: /* 32 nm nehalem, "Clarkdale", "Arrandale" */
         case 0x2c: /* 32 nm nehalem, "Gulftown", "Westmere-EP" */
         case 0x27: /* 32 nm Westmere-EX */
+        case 0x2f: /* 32 nm Westmere-EX */

Hmm, 0x27 isn't Westmere - commit 6d112f2b50 ("x86/vPMU: change Intel model numbers from decimal to hex") translated 47 to 0x27. So the correct fix is to replace that entry.

Jan

#2 lore raw

PATCH v2 1/1 VPMU: add lost Intel processor

In reply to Dietmar Hahn

From: Alan Robinson <[email protected]>

commit 6d112f2b50 ("x86/vPMU: change Intel model numbers from decimal to hex") translated 47 to 0x27, now corrected to 0x2f.

Signed-off-by Alan Robinson <[email protected]>
Signed-off-by Dietmar Hahn <[email protected]>

---
Changed since v1:
(after talking to Dietmar, he's away from his email for a while)
* removed non existent model number 0x27 as suggested by Jan Beulich
* included reference to when the problem was introduced (also from Jan)

 xen/arch/x86/hvm/vmx/vpmu_core2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/hvm/vmx/vpmu_core2.c +1 -1
index 8ad522a..311f35f 100644
@@ -848,7 +848,7 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags)
         /* Westmere: */
         case 0x25: /* 32 nm nehalem, "Clarkdale", "Arrandale" */
         case 0x2c: /* 32 nm nehalem, "Gulftown", "Westmere-EP" */
-        case 0x27: /* 32 nm Westmere-EX */
+        case 0x2f: /* 32 nm Westmere-EX */
 
         case 0x3a: /* IvyBridge */
         case 0x3e: /* IvyBridge EP */
Signature · 1 line
2.2.0
Reviewed-by on v2 1/1
#3 lore raw
Quoted 7 lines · Alan Robinson

From: Alan Robinson <[email protected]>

commit 6d112f2b50 ("x86/vPMU: change Intel model numbers from decimal to hex") translated 47 to 0x27, now corrected to 0x2f.

Signed-off-by Alan Robinson <[email protected]>
Signed-off-by Dietmar Hahn <[email protected]>
Reviewed-by Konrad Rzeszutek Wilk <[email protected]>
Quoted 31 lines

---
Changed since v1:
(after talking to Dietmar, he's away from his email for a while)
* removed non existent model number 0x27 as suggested by Jan Beulich
* included reference to when the problem was introduced (also from Jan)

 xen/arch/x86/hvm/vmx/vpmu_core2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/hvm/vmx/vpmu_core2.c +1 -1
index 8ad522a..311f35f 100644
@@ -848,7 +848,7 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags)
         /* Westmere: */
         case 0x25: /* 32 nm nehalem, "Clarkdale", "Arrandale" */
         case 0x2c: /* 32 nm nehalem, "Gulftown", "Westmere-EP" */
-        case 0x27: /* 32 nm Westmere-EX */
+        case 0x2f: /* 32 nm Westmere-EX */
 
         case 0x3a: /* IvyBridge */
         case 0x3e: /* IvyBridge EP */
Signature · 7 lines
2.2.0


_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Acked-by on v2 1/1
#4 lore raw
In reply to Alan Robinson
Quoted 10 lines

From: Alan Robinson [mailto:[email protected]]
Sent: Monday, June 08, 2015 6:05 PM

From: Alan Robinson <[email protected]>

commit 6d112f2b50 ("x86/vPMU: change Intel model numbers from decimal to hex") translated 47 to 0x27, now corrected to 0x2f.

Signed-off-by Alan Robinson <[email protected]>
Signed-off-by Dietmar Hahn <[email protected]>
Acked-by Kevin Tian <[email protected]>
Quoted 26 lines

---
Changed since v1:
(after talking to Dietmar, he's away from his email for a while)
* removed non existent model number 0x27 as suggested by Jan Beulich
* included reference to when the problem was introduced (also from Jan)

 xen/arch/x86/hvm/vmx/vpmu_core2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/hvm/vmx/vpmu_core2.c +1 -2
index 8ad522a..311f35f 100644
@@ -848,7 +848,7 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int vpmu_flags)
         /* Westmere: */
         case 0x25: /* 32 nm nehalem, "Clarkdale", "Arrandale" */
         case 0x2c: /* 32 nm nehalem, "Gulftown", "Westmere-EP" */
-        case 0x27: /* 32 nm Westmere-EX */
+        case 0x2f: /* 32 nm Westmere-EX */
 
         case 0x3a: /* IvyBridge */
         case 0x3e: /* IvyBridge EP */
--

2.2.0