Skip to contentSkip to conversation

: git-completion.tcsh fails w/ noclobber

PATCH In review Ariel Faigon 2 participants 2 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : git-completion.tcsh fails w/ noclobber

tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated. Adding a ! in the redirect works correctly for both clobber (default) and 'set noclobber' users.

---

 contrib/completion/git-completion.tcsh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
contrib/completion/git-completion.tcsh +1 -1
index 6104a42..4a790d8 100644
@@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then
 	exit
 endif
 
-cat << EOF > ${__git_tcsh_completion_script}
+cat << EOF >! ${__git_tcsh_completion_script}
 #!bash
 #
 # This script is GENERATED and will be overwritten automatically.
#1 lore raw

The subject is better but still not quite there. I suggest:

[PATCH] git-completion.tcsh: fix redirect with noclobber

Quoted 3 lines · Ariel Faigon

tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated. Adding a ! in the redirect works correctly for both clobber (default) and 'set noclobber' users.

The email address look wrong. If he really helped you, he probably emailed you using another address.

Quoted 1 line

"Mentored-by:" is used by Google Summer of Code students. If someone helps you and you want to acknowledge that, you can add an "Helped-by:" trailer (unless your helper tells you that you can add a "Reviewed-by:" or maybe a "Signed-off-by:").

Quoted 2 lines

---